* [PATCH] drm/rockchip: Balance irq refcount on failure
@ 2016-09-16 18:22 Sean Paul
2016-09-19 4:18 ` Daniel Kurtz
0 siblings, 1 reply; 2+ messages in thread
From: Sean Paul @ 2016-09-16 18:22 UTC (permalink / raw)
To: mark.yao, heiko, dri-devel; +Cc: linux-rockchip
If create_crtc fails in vop bind, ensure the irq refcount is zeroed
back out before exiting.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 57650c9..131ae0f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1551,11 +1551,15 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
ret = vop_create_crtc(vop);
if (ret)
- return ret;
+ goto err_enable_irq;
pm_runtime_enable(&pdev->dev);
return 0;
+
+err_enable_irq:
+ enable_irq(vop->irq); /* To balance out the disable_irq above */
+ return ret;
}
static void vop_unbind(struct device *dev, struct device *master, void *data)
--
2.8.0.rc3.226.g39d4020
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/rockchip: Balance irq refcount on failure
2016-09-16 18:22 [PATCH] drm/rockchip: Balance irq refcount on failure Sean Paul
@ 2016-09-19 4:18 ` Daniel Kurtz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kurtz @ 2016-09-19 4:18 UTC (permalink / raw)
To: Sean Paul; +Cc: open list:ARM/Rockchip SoC..., dri-devel
On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul <seanpaul@chromium.org> wrote:
> If create_crtc fails in vop bind, ensure the irq refcount is zeroed
> back out before exiting.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 57650c9..131ae0f 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -1551,11 +1551,15 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
>
> ret = vop_create_crtc(vop);
> if (ret)
> - return ret;
> + goto err_enable_irq;
>
> pm_runtime_enable(&pdev->dev);
>
> return 0;
> +
> +err_enable_irq:
> + enable_irq(vop->irq); /* To balance out the disable_irq above */
> + return ret;
> }
>
> static void vop_unbind(struct device *dev, struct device *master, void *data)
> --
> 2.8.0.rc3.226.g39d4020
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 18:22 [PATCH] drm/rockchip: Balance irq refcount on failure Sean Paul
2016-09-19 4:18 ` Daniel Kurtz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.