* [PATCH] f2fs: No need to wait for data page writeback by force
@ 2016-09-21 10:41 Yunlei He
2016-09-22 10:50 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Yunlei He @ 2016-09-21 10:41 UTC (permalink / raw)
To: linux-f2fs-devel, jaegeuk, yuchao0; +Cc: heyunlei
No need to wait for data page writeback, wait or not
can be decided by device.
Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index e78501c..71e4a0f 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1658,7 +1658,7 @@ void f2fs_wait_on_encrypted_page_writeback(struct f2fs_sb_info *sbi,
cpage = find_lock_page(META_MAPPING(sbi), blkaddr);
if (cpage) {
- f2fs_wait_on_page_writeback(cpage, DATA, true);
+ f2fs_wait_on_page_writeback(cpage, DATA, false);
f2fs_put_page(cpage, 1);
}
}
--
1.9.1
------------------------------------------------------------------------------
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: No need to wait for data page writeback by force
2016-09-21 10:41 [PATCH] f2fs: No need to wait for data page writeback by force Yunlei He
@ 2016-09-22 10:50 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2016-09-22 10:50 UTC (permalink / raw)
To: Yunlei He, linux-f2fs-devel, jaegeuk; +Cc: heyunlei
Hi Yunlei,
On 2016/9/21 18:41, Yunlei He wrote:
> No need to wait for data page writeback, wait or not
> can be decided by device.
>
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index e78501c..71e4a0f 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1658,7 +1658,7 @@ void f2fs_wait_on_encrypted_page_writeback(struct f2fs_sb_info *sbi,
>
> cpage = find_lock_page(META_MAPPING(sbi), blkaddr);
> if (cpage) {
> - f2fs_wait_on_page_writeback(cpage, DATA, true);
> + f2fs_wait_on_page_writeback(cpage, DATA, false);
You can see why we need to wait page writebacked in this commit 08b39fbd5978
("f2fs crypto: fix racing of accessing encrypted page among"), here, I think we
should not let that page slip during writebacking even driver supports accessing
writebacking page.
Thanks,
> f2fs_put_page(cpage, 1);
> }
> }
>
------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-22 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 10:41 [PATCH] f2fs: No need to wait for data page writeback by force Yunlei He
2016-09-22 10:50 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.