* [PATCH] ARC: CONFIG_NODES_SHIFT fix default values
@ 2016-09-21 10:51 ` Noam Camus
0 siblings, 0 replies; 4+ messages in thread
From: Noam Camus @ 2016-09-21 10:51 UTC (permalink / raw)
To: vgupta; +Cc: linux-snps-arc, linux-kernel, Noam Camus
From: Noam Camus <noamca@mellanox.com>
Seem like values assigned as absolute number and not and
shift value, i.e. should be 0 for one node (2^0) and 1 for
couple of nodes (2^1)
Signed-off-by: Noam Camus <noamca@mellanox.com>
---
arch/arc/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index 6af0b43..f347715 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -383,8 +383,8 @@ endchoice
config NODES_SHIFT
int "Maximum NUMA Nodes (as a power of 2)"
- default "1" if !DISCONTIGMEM
- default "2" if DISCONTIGMEM
+ default "0" if !DISCONTIGMEM
+ default "1" if DISCONTIGMEM
depends on NEED_MULTIPLE_NODES
---help---
Accessing memory beyond 1GB (with or w/o PAE) requires 2 memory
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARC: CONFIG_NODES_SHIFT fix default values
@ 2016-09-21 10:51 ` Noam Camus
0 siblings, 0 replies; 4+ messages in thread
From: Noam Camus @ 2016-09-21 10:51 UTC (permalink / raw)
To: linux-snps-arc
From: Noam Camus <noamca@mellanox.com>
Seem like values assigned as absolute number and not and
shift value, i.e. should be 0 for one node (2^0) and 1 for
couple of nodes (2^1)
Signed-off-by: Noam Camus <noamca at mellanox.com>
---
arch/arc/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index 6af0b43..f347715 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -383,8 +383,8 @@ endchoice
config NODES_SHIFT
int "Maximum NUMA Nodes (as a power of 2)"
- default "1" if !DISCONTIGMEM
- default "2" if DISCONTIGMEM
+ default "0" if !DISCONTIGMEM
+ default "1" if DISCONTIGMEM
depends on NEED_MULTIPLE_NODES
---help---
Accessing memory beyond 1GB (with or w/o PAE) requires 2 memory
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARC: CONFIG_NODES_SHIFT fix default values
2016-09-21 10:51 ` Noam Camus
@ 2016-09-26 21:23 ` Vineet Gupta
-1 siblings, 0 replies; 4+ messages in thread
From: Vineet Gupta @ 2016-09-26 21:23 UTC (permalink / raw)
To: Noam Camus; +Cc: linux-snps-arc, linux-kernel
On 09/21/2016 03:51 AM, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
>
> Seem like values assigned as absolute number and not and
> shift value, i.e. should be 0 for one node (2^0) and 1 for
> couple of nodes (2^1)
>
> Signed-off-by: Noam Camus <noamca@mellanox.com>
Good catch ! Added to for-next.
Thx,
-Vineet
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARC: CONFIG_NODES_SHIFT fix default values
@ 2016-09-26 21:23 ` Vineet Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Vineet Gupta @ 2016-09-26 21:23 UTC (permalink / raw)
To: linux-snps-arc
On 09/21/2016 03:51 AM, Noam Camus wrote:
> From: Noam Camus <noamca at mellanox.com>
>
> Seem like values assigned as absolute number and not and
> shift value, i.e. should be 0 for one node (2^0) and 1 for
> couple of nodes (2^1)
>
> Signed-off-by: Noam Camus <noamca at mellanox.com>
Good catch ! Added to for-next.
Thx,
-Vineet
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-26 21:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 10:51 [PATCH] ARC: CONFIG_NODES_SHIFT fix default values Noam Camus
2016-09-21 10:51 ` Noam Camus
2016-09-26 21:23 ` Vineet Gupta
2016-09-26 21:23 ` Vineet Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.