All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: fix amdgpu_vm_bo_update param error
@ 2016-09-22  3:41 Flora Cui
       [not found] ` <1474515666-24562-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Flora Cui @ 2016-09-22  3:41 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Flora Cui

Change-Id: I86dc7d3fc4d6197bd13563a420718a8412ce9dbc
Signed-off-by: Flora Cui <Flora.Cui@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 941416a..a7ea9a3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -528,7 +528,7 @@ static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
 		goto error_unreserve;
 
 	if (operation == AMDGPU_VA_OP_MAP)
-		r = amdgpu_vm_bo_update(adev, bo_va, &bo_va->bo->tbo.mem);
+		r = amdgpu_vm_bo_update(adev, bo_va, false);
 
 error_unreserve:
 	ttm_eu_backoff_reservation(&ticket, &list);
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amdgpu: fix amdgpu_vm_bo_update param error
       [not found] ` <1474515666-24562-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
@ 2016-09-22 13:24   ` Christian König
  0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2016-09-22 13:24 UTC (permalink / raw)
  To: Flora Cui, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 22.09.2016 um 05:41 schrieb Flora Cui:
> Change-Id: I86dc7d3fc4d6197bd13563a420718a8412ce9dbc
> Signed-off-by: Flora Cui <Flora.Cui@amd.com>

Good catch. That clearly results in some additional overhead if not 
worse otherwise.

Patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index 941416a..a7ea9a3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -528,7 +528,7 @@ static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
>   		goto error_unreserve;
>   
>   	if (operation == AMDGPU_VA_OP_MAP)
> -		r = amdgpu_vm_bo_update(adev, bo_va, &bo_va->bo->tbo.mem);
> +		r = amdgpu_vm_bo_update(adev, bo_va, false);
>   
>   error_unreserve:
>   	ttm_eu_backoff_reservation(&ticket, &list);


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-22 13:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-22  3:41 [PATCH] drm/amdgpu: fix amdgpu_vm_bo_update param error Flora Cui
     [not found] ` <1474515666-24562-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2016-09-22 13:24   ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.