* [PATCH] staging: ion: Align cases with switch
@ 2016-09-22 20:38 Christopher Pezley
2016-09-23 12:16 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Christopher Pezley @ 2016-09-22 20:38 UTC (permalink / raw)
To: labbott; +Cc: driverdev-devel, Christopher Pezley
The preferred indentation for cases and switches has the cases at the same level as the switch.
Signed-off-by: Christopher H. Pezley <chris@pezley.net>
---
drivers/staging/android/ion/ion_of.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index de0899a..3c050b0 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
switch (heap->type) {
- case ION_HEAP_TYPE_CARVEOUT:
- case ION_HEAP_TYPE_CHUNK:
- if (heap->base && heap->size)
- return 0;
-
- ret = of_reserved_mem_device_init(heap->priv);
- break;
- default:
- break;
+ case ION_HEAP_TYPE_CARVEOUT:
+ case ION_HEAP_TYPE_CHUNK:
+ if (heap->base && heap->size)
+ return 0;
+
+ ret = of_reserved_mem_device_init(heap->priv);
+ break;
+ default:
+ break;
}
return ret;
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: ion: Align cases with switch
2016-09-22 20:38 [PATCH] staging: ion: Align cases with switch Christopher Pezley
@ 2016-09-23 12:16 ` Greg KH
2016-09-23 20:40 ` Christopher Pezley
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2016-09-23 12:16 UTC (permalink / raw)
To: Christopher Pezley; +Cc: labbott, driverdev-devel
On Thu, Sep 22, 2016 at 10:38:13PM +0200, Christopher Pezley wrote:
> The preferred indentation for cases and switches has the cases at the same level as the switch.
Please wrap your changelog text at 72 columns like git tried to get you
to do :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: ion: Align cases with switch
2016-09-23 12:16 ` Greg KH
@ 2016-09-23 20:40 ` Christopher Pezley
2016-09-23 22:11 ` Laura Abbott
0 siblings, 1 reply; 5+ messages in thread
From: Christopher Pezley @ 2016-09-23 20:40 UTC (permalink / raw)
To: gregkh; +Cc: driverdev-devel, Christopher Pezley
The preferred indentation for cases and switches has the cases at
the same level as the switch.
Signed-off-by: Christopher H. Pezley <chris@pezley.net>
---
drivers/staging/android/ion/ion_of.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index de0899a..3c050b0 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
switch (heap->type) {
- case ION_HEAP_TYPE_CARVEOUT:
- case ION_HEAP_TYPE_CHUNK:
- if (heap->base && heap->size)
- return 0;
-
- ret = of_reserved_mem_device_init(heap->priv);
- break;
- default:
- break;
+ case ION_HEAP_TYPE_CARVEOUT:
+ case ION_HEAP_TYPE_CHUNK:
+ if (heap->base && heap->size)
+ return 0;
+
+ ret = of_reserved_mem_device_init(heap->priv);
+ break;
+ default:
+ break;
}
return ret;
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: ion: Align cases with switch
2016-09-23 20:40 ` Christopher Pezley
@ 2016-09-23 22:11 ` Laura Abbott
2016-09-24 16:51 ` [PATCHv2] " Christopher Pezley
0 siblings, 1 reply; 5+ messages in thread
From: Laura Abbott @ 2016-09-23 22:11 UTC (permalink / raw)
To: Christopher Pezley, gregkh; +Cc: driverdev-devel
On 09/23/2016 01:40 PM, Christopher Pezley wrote:
> The preferred indentation for cases and switches has the cases at
> the same level as the switch.
>
Please remember to tag your patches with v2 when sending the
next version to tell them apart (e.g. [PATCHv2])
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Christopher H. Pezley <chris@pezley.net>
> ---
> drivers/staging/android/ion/ion_of.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
> index de0899a..3c050b0 100644
> --- a/drivers/staging/android/ion/ion_of.c
> +++ b/drivers/staging/android/ion/ion_of.c
> @@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
> int ret = 0;
>
> switch (heap->type) {
> - case ION_HEAP_TYPE_CARVEOUT:
> - case ION_HEAP_TYPE_CHUNK:
> - if (heap->base && heap->size)
> - return 0;
> -
> - ret = of_reserved_mem_device_init(heap->priv);
> - break;
> - default:
> - break;
> + case ION_HEAP_TYPE_CARVEOUT:
> + case ION_HEAP_TYPE_CHUNK:
> + if (heap->base && heap->size)
> + return 0;
> +
> + ret = of_reserved_mem_device_init(heap->priv);
> + break;
> + default:
> + break;
> }
>
> return ret;
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv2] staging: ion: Align cases with switch
2016-09-23 22:11 ` Laura Abbott
@ 2016-09-24 16:51 ` Christopher Pezley
0 siblings, 0 replies; 5+ messages in thread
From: Christopher Pezley @ 2016-09-24 16:51 UTC (permalink / raw)
To: labbott; +Cc: gregkh, driverdev-devel, Christopher Pezley
The preferred indentation for cases and switches has the cases at
the same level as the switch.
Signed-off-by: Christopher H. Pezley <chris@pezley.net>
Acked-by: Laura Abbott <labbott@redhat.com>
---
drivers/staging/android/ion/ion_of.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index de0899a..3c050b0 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
switch (heap->type) {
- case ION_HEAP_TYPE_CARVEOUT:
- case ION_HEAP_TYPE_CHUNK:
- if (heap->base && heap->size)
- return 0;
-
- ret = of_reserved_mem_device_init(heap->priv);
- break;
- default:
- break;
+ case ION_HEAP_TYPE_CARVEOUT:
+ case ION_HEAP_TYPE_CHUNK:
+ if (heap->base && heap->size)
+ return 0;
+
+ ret = of_reserved_mem_device_init(heap->priv);
+ break;
+ default:
+ break;
}
return ret;
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-24 16:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-22 20:38 [PATCH] staging: ion: Align cases with switch Christopher Pezley
2016-09-23 12:16 ` Greg KH
2016-09-23 20:40 ` Christopher Pezley
2016-09-23 22:11 ` Laura Abbott
2016-09-24 16:51 ` [PATCHv2] " Christopher Pezley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.