* [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
@ 2016-09-22 22:37 Jay Freyensee
2016-09-23 3:33 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Jay Freyensee @ 2016-09-22 22:37 UTC (permalink / raw)
I am not sure if it matters too much except in possibly
human usage understanding, but '-r' is used in the 'discover'
command for --raw. Change the --reconnect-delay flag
single letter to something not being used in any fabrics
command.
Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
---
fabrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fabrics.c b/fabrics.c
index dff5d6a..5e892fb 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -759,7 +759,7 @@ int connect(const char *desc, int argc, char **argv)
"number of io queues to use (default is core count)" },
{"keep-alive-tmo", 'k', "LIST", CFG_STRING, &cfg.keep_alive_tmo, required_argument,
"keep alive timeout period in seconds" },
- {"reconnect-delay", 'r', "LIST", CFG_STRING, &cfg.reconnect_delay, required_argument,
+ {"reconnect-delay", 'c', "LIST", CFG_STRING, &cfg.reconnect_delay, required_argument,
"reconnect timeout period in seconds" },
{0},
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
2016-09-22 22:37 [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag Jay Freyensee
@ 2016-09-23 3:33 ` Christoph Hellwig
2016-09-23 14:49 ` Steve Wise
2016-09-23 15:00 ` Keith Busch
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-09-23 3:33 UTC (permalink / raw)
On Thu, Sep 22, 2016@03:37:20PM -0700, Jay Freyensee wrote:
> I am not sure if it matters too much except in possibly
> human usage understanding, but '-r' is used in the 'discover'
> command for --raw. Change the --reconnect-delay flag
> single letter to something not being used in any fabrics
> command.
Sounds ok to me. But I have to say dealing with these short options
start to be a little annoying. For a lot of these commands I'd prefer
to simply support long options only if we could (I'll need to look
at argconfig.c in a bit more detail how easily that could be done).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
2016-09-23 3:33 ` Christoph Hellwig
@ 2016-09-23 14:49 ` Steve Wise
2016-09-23 15:00 ` Keith Busch
1 sibling, 0 replies; 6+ messages in thread
From: Steve Wise @ 2016-09-23 14:49 UTC (permalink / raw)
> -----Original Message-----
> From: Linux-nvme [mailto:linux-nvme-bounces at lists.infradead.org] On Behalf Of
> Christoph Hellwig
> Sent: Thursday, September 22, 2016 10:33 PM
> To: Jay Freyensee
> Cc: swise at opengridcomputing.com; linux-nvme at lists.infradead.org
> Subject: Re: [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
>
> On Thu, Sep 22, 2016@03:37:20PM -0700, Jay Freyensee wrote:
> > I am not sure if it matters too much except in possibly
> > human usage understanding, but '-r' is used in the 'discover'
> > command for --raw. Change the --reconnect-delay flag
> > single letter to something not being used in any fabrics
> > command.
>
> Sounds ok to me. But I have to say dealing with these short options
> start to be a little annoying. For a lot of these commands I'd prefer
> to simply support long options only if we could (I'll need to look
> at argconfig.c in a bit more detail how easily that could be done).
You could just not document the short options...
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
2016-09-23 3:33 ` Christoph Hellwig
2016-09-23 14:49 ` Steve Wise
@ 2016-09-23 15:00 ` Keith Busch
2016-09-23 16:43 ` J Freyensee
1 sibling, 1 reply; 6+ messages in thread
From: Keith Busch @ 2016-09-23 15:00 UTC (permalink / raw)
On Thu, Sep 22, 2016@08:33:01PM -0700, Christoph Hellwig wrote:
> On Thu, Sep 22, 2016@03:37:20PM -0700, Jay Freyensee wrote:
> > I am not sure if it matters too much except in possibly
> > human usage understanding, but '-r' is used in the 'discover'
> > command for --raw. Change the --reconnect-delay flag
> > single letter to something not being used in any fabrics
> > command.
>
> Sounds ok to me. But I have to say dealing with these short options
> start to be a little annoying. For a lot of these commands I'd prefer
> to simply support long options only if we could (I'll need to look
> at argconfig.c in a bit more detail how easily that could be done).
Aw, I like having short opts. Yeah, some were arbitrarily picked to avoid
clashes (though I clearly missed some clashes), and difficult to remember,
but every sub-command shows consistent helpful usage info with a "--help".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
2016-09-23 15:00 ` Keith Busch
@ 2016-09-23 16:43 ` J Freyensee
2016-09-23 20:59 ` Sagi Grimberg
0 siblings, 1 reply; 6+ messages in thread
From: J Freyensee @ 2016-09-23 16:43 UTC (permalink / raw)
On Fri, 2016-09-23@11:00 -0400, Keith Busch wrote:
> On Thu, Sep 22, 2016@08:33:01PM -0700, Christoph Hellwig wrote:
> >
> > On Thu, Sep 22, 2016@03:37:20PM -0700, Jay Freyensee wrote:
> > >
> > > I am not sure if it matters too much except in possibly
> > > human usage understanding, but '-r' is used in the 'discover'
> > > command for --raw.??Change the --reconnect-delay flag
> > > single letter to something not being used in any fabrics
> > > command.
> >
> > Sounds ok to me.??But I have to say dealing with these short
> > options
> > start to be a little annoying.??For a lot of these commands I'd
> > prefer
> > to simply support long options only if we could (I'll need to look
> > at argconfig.c in a bit more detail how easily that could be done).
>
> Aw, I like having short opts. Yeah, some were arbitrarily picked to
> avoid
> clashes (though I clearly missed some clashes), and difficult to
> remember,
> but every sub-command shows consistent helpful usage info with a "
> --help".
OK, I'll respin this, add the review tags, and remove the RFC and send
it back out.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
2016-09-23 16:43 ` J Freyensee
@ 2016-09-23 20:59 ` Sagi Grimberg
0 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2016-09-23 20:59 UTC (permalink / raw)
> OK, I'll respin this, add the review tags, and remove the RFC and send
> it back out.
I'm fine with '-c' too.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-23 20:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-22 22:37 [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag Jay Freyensee
2016-09-23 3:33 ` Christoph Hellwig
2016-09-23 14:49 ` Steve Wise
2016-09-23 15:00 ` Keith Busch
2016-09-23 16:43 ` J Freyensee
2016-09-23 20:59 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.