[PATCH 0/2] Detect huawei E3372

[PATCH 0/2] Detect huawei E3372

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

I have these two patches after spending some time with E3372 (reflashed with
a so called 21 firmware). I have mixed feeling about those, but just send them
here in case.

Frédéric Dalleau (2):
  udevng: Detect huawei E3372 pcui
  udevng: Detect huawei E3372 modem and pcui

 plugins/udevng.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.7.4

[PATCH 1/2] udevng: Detect huawei E3372 pcui

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

The huawei E3372 exposes two USB tty at /dev/ttyUSB0 and /dev/ttyUSB1
/dev/ttyUSB1 is properly detected as modem.
/dev/ttyUSB0 is the pcui.

lsusb shows 12d1:1506 Huawei Technologies Co., Ltd. Modem/Networkcard

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
---
 plugins/udevng.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 607e381..1a85246 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -330,6 +330,7 @@ static gboolean setup_huawei(struct modem_info *modem)
 		} else if (g_strcmp0(info->label, "pcui") == 0 ||
 				g_strcmp0(info->interface, "255/1/2") == 0 ||
 				g_strcmp0(info->interface, "255/2/2") == 0 ||
+				g_strcmp0(info->interface, "255/2/18") == 0 ||
 				g_strcmp0(info->interface, "255/1/50") == 0) {
 			pcui = info->devnode;
 		} else if (g_strcmp0(info->label, "diag") == 0 ||
-- 
2.7.4

[PATCH 2/2] udevng: Detect huawei E3372 modem and pcui

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

When the modes are modified with AT^SETPORT="FF;12,1,16", this modem
and pcui will appear using different ids. Update the interfaces
identifier accordingly.

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
---
 plugins/udevng.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 1a85246..933bf4f 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -325,12 +325,14 @@ static gboolean setup_huawei(struct modem_info *modem)
 		if (g_strcmp0(info->label, "modem") == 0 ||
 				g_strcmp0(info->interface, "255/1/1") == 0 ||
 				g_strcmp0(info->interface, "255/2/1") == 0 ||
+				g_strcmp0(info->interface, "255/3/1") == 0 ||
 				g_strcmp0(info->interface, "255/1/49") == 0) {
 			mdm = info->devnode;
 		} else if (g_strcmp0(info->label, "pcui") == 0 ||
 				g_strcmp0(info->interface, "255/1/2") == 0 ||
 				g_strcmp0(info->interface, "255/2/2") == 0 ||
 				g_strcmp0(info->interface, "255/2/18") == 0 ||
+				g_strcmp0(info->interface, "255/3/18") == 0 ||
 				g_strcmp0(info->interface, "255/1/50") == 0) {
 			pcui = info->devnode;
 		} else if (g_strcmp0(info->label, "diag") == 0 ||
-- 
2.7.4

Re: [PATCH 2/2] udevng: Detect huawei E3372 modem and pcui

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi Frédéric,

On 09/29/2016 02:52 AM, Frédéric Dalleau wrote:
> When the modes are modified with AT^SETPORT="FF;12,1,16", this modem
> and pcui will appear using different ids. Update the interfaces
> identifier accordingly.
>
> Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>

oFono doesn't use Signed-off-by.  I took Signed-off-by out manually and 
applied both patches.

Thanks!

Regards,
-Denis