* [PATCH] dmaengine: pxa_dma: remove unused function
@ 2016-09-29 13:09 ` Baoyou Xie
0 siblings, 0 replies; 4+ messages in thread
From: Baoyou Xie @ 2016-09-29 13:09 UTC (permalink / raw)
To: daniel, haojian.zhuang, robert.jarzmik, vinod.koul, dan.j.williams
Cc: linux-arm-kernel, dmaengine, linux-kernel, arnd, baoyou.xie,
xie.baoyou, han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
In fact, this function is called by no one, so this patch removes it.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/dma/pxa_dma.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index 3f56f9c..7d9b1cc 100644
--- a/drivers/dma/pxa_dma.c
+++ b/drivers/dma/pxa_dma.c
@@ -1522,15 +1522,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param)
}
EXPORT_SYMBOL_GPL(pxad_filter_fn);
-int pxad_toggle_reserved_channel(int legacy_channel)
-{
- if (legacy_unavailable & (BIT(legacy_channel)))
- return -EBUSY;
- legacy_reserved ^= BIT(legacy_channel);
- return 0;
-}
-EXPORT_SYMBOL_GPL(pxad_toggle_reserved_channel);
-
module_platform_driver(pxad_driver);
MODULE_DESCRIPTION("Marvell PXA Peripheral DMA Driver");
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] dmaengine: pxa_dma: remove unused function
@ 2016-09-29 13:09 ` Baoyou Xie
0 siblings, 0 replies; 4+ messages in thread
From: Baoyou Xie @ 2016-09-29 13:09 UTC (permalink / raw)
To: linux-arm-kernel
We get 1 warning when building kernel with W=1:
drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
In fact, this function is called by no one, so this patch removes it.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/dma/pxa_dma.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index 3f56f9c..7d9b1cc 100644
--- a/drivers/dma/pxa_dma.c
+++ b/drivers/dma/pxa_dma.c
@@ -1522,15 +1522,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param)
}
EXPORT_SYMBOL_GPL(pxad_filter_fn);
-int pxad_toggle_reserved_channel(int legacy_channel)
-{
- if (legacy_unavailable & (BIT(legacy_channel)))
- return -EBUSY;
- legacy_reserved ^= BIT(legacy_channel);
- return 0;
-}
-EXPORT_SYMBOL_GPL(pxad_toggle_reserved_channel);
-
module_platform_driver(pxad_driver);
MODULE_DESCRIPTION("Marvell PXA Peripheral DMA Driver");
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine: pxa_dma: remove unused function
2016-09-29 13:09 ` Baoyou Xie
@ 2016-09-29 15:45 ` Robert Jarzmik
-1 siblings, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2016-09-29 15:45 UTC (permalink / raw)
To: Baoyou Xie
Cc: daniel, haojian.zhuang, vinod.koul, dan.j.williams,
linux-arm-kernel, dmaengine, linux-kernel, arnd, xie.baoyou,
han.fei, tang.qiang007
Baoyou Xie <baoyou.xie@linaro.org> writes:
> We get 1 warning when building kernel with W=1:
> drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
>
> In fact, this function is called by no one, so this patch removes it.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Okay, yet I'd rather have a revert of commit c91134d91944 ("dmaengine: pxa_dma:
add support for legacy transition") , with the commit message saying:
The conversion of the pxa architecture is now finished for all drivers, so this
functions has fullfilled its purpose and can now be removed.
I have a similar patch in my internal tree, but yours can very well go in, as
long as it is a revert with a statement explaining why it is necessary now and
not before.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] dmaengine: pxa_dma: remove unused function
@ 2016-09-29 15:45 ` Robert Jarzmik
0 siblings, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2016-09-29 15:45 UTC (permalink / raw)
To: linux-arm-kernel
Baoyou Xie <baoyou.xie@linaro.org> writes:
> We get 1 warning when building kernel with W=1:
> drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
>
> In fact, this function is called by no one, so this patch removes it.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Okay, yet I'd rather have a revert of commit c91134d91944 ("dmaengine: pxa_dma:
add support for legacy transition") , with the commit message saying:
The conversion of the pxa architecture is now finished for all drivers, so this
functions has fullfilled its purpose and can now be removed.
I have a similar patch in my internal tree, but yours can very well go in, as
long as it is a revert with a statement explaining why it is necessary now and
not before.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-29 15:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-29 13:09 [PATCH] dmaengine: pxa_dma: remove unused function Baoyou Xie
2016-09-29 13:09 ` Baoyou Xie
2016-09-29 15:45 ` Robert Jarzmik
2016-09-29 15:45 ` Robert Jarzmik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.