* [PATCH 1/2] mmc: block: add missing header dependencies
@ 2016-09-30 1:37 ` Baoyou Xie
0 siblings, 0 replies; 10+ messages in thread
From: Baoyou Xie @ 2016-09-30 1:37 UTC (permalink / raw)
To: michal.simek, soren.brinkmann, adrian.hunter, ulf.hansson,
linux-arm-kernel
Cc: linux-mmc, linux-kernel, arnd, baoyou.xie, xie.baoyou, han.fei,
tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/mmc/card/block.c:2147:5: warning: no previous prototype for 'mmc_blk_issue_rq' [-Wmissing-prototypes]
In fact, this function is declared in drivers/mmc/card/block.h,
so this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/mmc/card/block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index c333511..0f2cc9f2 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -46,6 +46,7 @@
#include <asm/uaccess.h>
#include "queue.h"
+#include "block.h"
MODULE_ALIAS("mmc:block");
#ifdef MODULE_PARAM_PREFIX
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/2] mmc: block: add missing header dependencies
@ 2016-09-30 1:37 ` Baoyou Xie
0 siblings, 0 replies; 10+ messages in thread
From: Baoyou Xie @ 2016-09-30 1:37 UTC (permalink / raw)
To: linux-arm-kernel
We get 1 warning when building kernel with W=1:
drivers/mmc/card/block.c:2147:5: warning: no previous prototype for 'mmc_blk_issue_rq' [-Wmissing-prototypes]
In fact, this function is declared in drivers/mmc/card/block.h,
so this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/mmc/card/block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index c333511..0f2cc9f2 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -46,6 +46,7 @@
#include <asm/uaccess.h>
#include "queue.h"
+#include "block.h"
MODULE_ALIAS("mmc:block");
#ifdef MODULE_PARAM_PREFIX
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static
2016-09-30 1:37 ` Baoyou Xie
@ 2016-09-30 1:37 ` Baoyou Xie
-1 siblings, 0 replies; 10+ messages in thread
From: Baoyou Xie @ 2016-09-30 1:37 UTC (permalink / raw)
To: michal.simek, soren.brinkmann, adrian.hunter, ulf.hansson,
linux-arm-kernel
Cc: linux-mmc, linux-kernel, arnd, baoyou.xie, xie.baoyou, han.fei,
tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for 'sdhci_arasan_reset' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/mmc/host/sdhci-of-arasan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index da8e40a..e263671 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -250,7 +250,7 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
}
-void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
+static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
{
u8 ctrl;
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static
@ 2016-09-30 1:37 ` Baoyou Xie
0 siblings, 0 replies; 10+ messages in thread
From: Baoyou Xie @ 2016-09-30 1:37 UTC (permalink / raw)
To: linux-arm-kernel
We get 1 warning when building kernel with W=1:
drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for 'sdhci_arasan_reset' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/mmc/host/sdhci-of-arasan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index da8e40a..e263671 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -250,7 +250,7 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
}
-void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
+static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
{
u8 ctrl;
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static
2016-09-30 1:37 ` Baoyou Xie
(?)
@ 2016-09-30 6:30 ` Sören Brinkmann
-1 siblings, 0 replies; 10+ messages in thread
From: Sören Brinkmann @ 2016-09-30 6:30 UTC (permalink / raw)
To: Baoyou Xie
Cc: michal.simek, adrian.hunter, ulf.hansson, linux-arm-kernel,
linux-mmc, linux-kernel, arnd, xie.baoyou, han.fei,
tang.qiang007
On Fri, 2016-09-30 at 09:37:39 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for 'sdhci_arasan_reset' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
There is already a patch for this:
https://patchwork.kernel.org/patch/9349805/
Sören
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static
@ 2016-09-30 6:30 ` Sören Brinkmann
0 siblings, 0 replies; 10+ messages in thread
From: Sören Brinkmann @ 2016-09-30 6:30 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2016-09-30 at 09:37:39 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for 'sdhci_arasan_reset' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
There is already a patch for this:
https://patchwork.kernel.org/patch/9349805/
S?ren
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static
@ 2016-09-30 6:30 ` Sören Brinkmann
0 siblings, 0 replies; 10+ messages in thread
From: Sören Brinkmann @ 2016-09-30 6:30 UTC (permalink / raw)
To: Baoyou Xie
Cc: michal.simek, adrian.hunter, ulf.hansson, linux-arm-kernel,
linux-mmc, linux-kernel, arnd, xie.baoyou, han.fei,
tang.qiang007
On Fri, 2016-09-30 at 09:37:39 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for 'sdhci_arasan_reset' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
There is already a patch for this:
https://patchwork.kernel.org/patch/9349805/
Sören
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mmc: block: add missing header dependencies
2016-09-30 1:37 ` Baoyou Xie
(?)
@ 2016-10-10 12:37 ` Ulf Hansson
-1 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-10 12:37 UTC (permalink / raw)
To: Baoyou Xie
Cc: Michal Simek, Sören Brinkmann, Adrian Hunter,
linux-arm-kernel, linux-mmc, linux-kernel, Arnd Bergmann,
xie.baoyou, han.fei, tang.qiang007
On 30 September 2016 at 03:37, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/mmc/card/block.c:2147:5: warning: no previous prototype for 'mmc_blk_issue_rq' [-Wmissing-prototypes]
>
> In fact, this function is declared in drivers/mmc/card/block.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> drivers/mmc/card/block.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c333511..0f2cc9f2 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -46,6 +46,7 @@
> #include <asm/uaccess.h>
>
> #include "queue.h"
> +#include "block.h"
>
> MODULE_ALIAS("mmc:block");
> #ifdef MODULE_PARAM_PREFIX
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] mmc: block: add missing header dependencies
@ 2016-10-10 12:37 ` Ulf Hansson
0 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-10 12:37 UTC (permalink / raw)
To: linux-arm-kernel
On 30 September 2016 at 03:37, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/mmc/card/block.c:2147:5: warning: no previous prototype for 'mmc_blk_issue_rq' [-Wmissing-prototypes]
>
> In fact, this function is declared in drivers/mmc/card/block.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> drivers/mmc/card/block.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c333511..0f2cc9f2 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -46,6 +46,7 @@
> #include <asm/uaccess.h>
>
> #include "queue.h"
> +#include "block.h"
>
> MODULE_ALIAS("mmc:block");
> #ifdef MODULE_PARAM_PREFIX
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] mmc: block: add missing header dependencies
@ 2016-10-10 12:37 ` Ulf Hansson
0 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-10 12:37 UTC (permalink / raw)
To: Baoyou Xie
Cc: Arnd Bergmann, tang.qiang007, xie.baoyou, linux-mmc,
linux-kernel, Michal Simek, han.fei, Sören Brinkmann,
Adrian Hunter, linux-arm-kernel
On 30 September 2016 at 03:37, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/mmc/card/block.c:2147:5: warning: no previous prototype for 'mmc_blk_issue_rq' [-Wmissing-prototypes]
>
> In fact, this function is declared in drivers/mmc/card/block.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> drivers/mmc/card/block.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c333511..0f2cc9f2 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -46,6 +46,7 @@
> #include <asm/uaccess.h>
>
> #include "queue.h"
> +#include "block.h"
>
> MODULE_ALIAS("mmc:block");
> #ifdef MODULE_PARAM_PREFIX
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-10-10 12:45 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-30 1:37 [PATCH 1/2] mmc: block: add missing header dependencies Baoyou Xie
2016-09-30 1:37 ` Baoyou Xie
2016-09-30 1:37 ` [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static Baoyou Xie
2016-09-30 1:37 ` Baoyou Xie
2016-09-30 6:30 ` Sören Brinkmann
2016-09-30 6:30 ` Sören Brinkmann
2016-09-30 6:30 ` Sören Brinkmann
2016-10-10 12:37 ` [PATCH 1/2] mmc: block: add missing header dependencies Ulf Hansson
2016-10-10 12:37 ` Ulf Hansson
2016-10-10 12:37 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.