* [PATCH] Input: synaptics-rmi4 - Fix error handling in SPI transport driver
@ 2016-10-01 3:12 Guenter Roeck
0 siblings, 0 replies; only message in thread
From: Guenter Roeck @ 2016-10-01 3:12 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Guenter Roeck, Andrew Duggan
Instantiating the rmi4 SPI transport driver without an interrupt assigned
caused the driver to fail to load, but it does not clean up its transport
device registration. Result may be a crash at a later time, for example
when rebooting the system.
Fixes: 8d99758dee31 ("Input: synaptics-rmi4 - add SPI transport driver")
Cc: Andrew Duggan <aduggan@synaptics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/input/rmi4/rmi_spi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
index 55bd1b34970c..f8484b7cdead 100644
--- a/drivers/input/rmi4/rmi_spi.c
+++ b/drivers/input/rmi4/rmi_spi.c
@@ -466,8 +466,10 @@ static int rmi_spi_probe(struct spi_device *spi)
}
retval = rmi_spi_init_irq(spi);
- if (retval < 0)
+ if (retval < 0) {
+ rmi_unregister_transport_device(&rmi_spi->xport);
return retval;
+ }
dev_info(&spi->dev, "registered RMI SPI driver\n");
return 0;
--
2.5.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-01 3:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-01 3:12 [PATCH] Input: synaptics-rmi4 - Fix error handling in SPI transport driver Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.