All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org,
	cov@codeaurora.org, alex.williamson@redhat.com,
	vikrams@codeaurora.org
Cc: Lorenzo.Pieralisi@arm.com, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/2] PCI: handle CRS returned by device after FLR
Date: Mon,  3 Oct 2016 01:37:00 -0400	[thread overview]
Message-ID: <1475473021-14251-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1475473021-14251-1-git-send-email-okaya@codeaurora.org>

An endpoint is allowed to issue CRS following an FLR request to indicate
that it is not ready to accept new requests. Changing the polling mechanism
in FLR wait function to go read the vendor ID instead of the command/status
register. A CRS indication will only be given if the address to be read is
vendor ID.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index c8749b9..7580b00 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3725,7 +3725,8 @@ static void pci_flr_wait(struct pci_dev *dev)
 
 	do {
 		msleep(100);
-		pci_read_config_dword(dev, PCI_COMMAND, &id);
+		pci_bus_read_dev_vendor_id(dev->bus, dev->devfn, &id,
+					   60 * 1000);
 	} while (i++ < 10 && id == ~0);
 
 	if (id == ~0)
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/2] PCI: handle CRS returned by device after FLR
Date: Mon,  3 Oct 2016 01:37:00 -0400	[thread overview]
Message-ID: <1475473021-14251-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1475473021-14251-1-git-send-email-okaya@codeaurora.org>

An endpoint is allowed to issue CRS following an FLR request to indicate
that it is not ready to accept new requests. Changing the polling mechanism
in FLR wait function to go read the vendor ID instead of the command/status
register. A CRS indication will only be given if the address to be read is
vendor ID.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index c8749b9..7580b00 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3725,7 +3725,8 @@ static void pci_flr_wait(struct pci_dev *dev)
 
 	do {
 		msleep(100);
-		pci_read_config_dword(dev, PCI_COMMAND, &id);
+		pci_bus_read_dev_vendor_id(dev->bus, dev->devfn, &id,
+					   60 * 1000);
 	} while (i++ < 10 && id == ~0);
 
 	if (id == ~0)
-- 
1.9.1

  parent reply	other threads:[~2016-10-03  5:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03  5:36 [PATCH V3 0/2] PCI: add CRS support after hot reset and FLR Sinan Kaya
2016-10-03  5:36 ` Sinan Kaya
2016-10-03  5:36 ` [PATCH V3 1/2] PCI: add CRS support to error handling path Sinan Kaya
2016-10-03  5:36   ` Sinan Kaya
2016-11-10 18:39   ` Sinan Kaya
2016-11-10 18:39     ` Sinan Kaya
2016-10-03  5:37 ` Sinan Kaya [this message]
2016-10-03  5:37   ` [PATCH V3 2/2] PCI: handle CRS returned by device after FLR Sinan Kaya
2017-02-21 17:04   ` Sinan Kaya
2017-02-21 17:04     ` Sinan Kaya
2017-02-21 17:04     ` Sinan Kaya
2017-02-21 20:51     ` Alex Williamson
2017-02-21 20:51       ` Alex Williamson
2017-02-21 20:51       ` Alex Williamson
2017-02-22  2:37       ` Sinan Kaya
2017-02-22  2:37         ` Sinan Kaya
2017-03-01 17:31         ` Sinan Kaya
2017-03-01 17:31           ` Sinan Kaya
2017-03-01 17:31           ` Sinan Kaya
2017-03-01 17:31           ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475473021-14251-3-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=alex.williamson@redhat.com \
    --cc=cov@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=timur@codeaurora.org \
    --cc=vikrams@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.