[Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier

[Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier

[Paolo Bonzini]

Register the notifier using the specific API for block devices.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/write-threshold.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/write-threshold.c b/block/write-threshold.c
index cc2ca71..0bd1a01 100644
--- a/block/write-threshold.c
+++ b/block/write-threshold.c
@@ -76,8 +76,7 @@ static int coroutine_fn before_write_notify(NotifierWithReturn *notifier,
 static void write_threshold_register_notifier(BlockDriverState *bs)
 {
     bs->write_threshold_notifier.notify = before_write_notify;
-    notifier_with_return_list_add(&bs->before_write_notifiers,
-                                  &bs->write_threshold_notifier);
+    bdrv_add_before_write_notifier(bs, &bs->write_threshold_notifier);
 }
 
 static void write_threshold_update(BlockDriverState *bs,
-- 
2.7.4

Re: [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On 10/04/2016 03:49 AM, Paolo Bonzini wrote:
> Register the notifier using the specific API for block devices.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/write-threshold.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/write-threshold.c b/block/write-threshold.c
> index cc2ca71..0bd1a01 100644
> --- a/block/write-threshold.c
> +++ b/block/write-threshold.c
> @@ -76,8 +76,7 @@ static int coroutine_fn before_write_notify(NotifierWithReturn *notifier,
>  static void write_threshold_register_notifier(BlockDriverState *bs)
>  {
>      bs->write_threshold_notifier.notify = before_write_notify;
> -    notifier_with_return_list_add(&bs->before_write_notifiers,
> -                                  &bs->write_threshold_notifier);
> +    bdrv_add_before_write_notifier(bs, &bs->write_threshold_notifier);
>  }
>  
>  static void write_threshold_update(BlockDriverState *bs,
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use bdrv_add_before_write_notifier

[Kevin Wolf]

Am 04.10.2016 um 10:49 hat Paolo Bonzini geschrieben:
> Register the notifier using the specific API for block devices.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, applied to the block branch.

Kevin

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use bdrv_add_before_write_notifier

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

On Tue, Oct 04, 2016 at 10:49:43AM +0200, Paolo Bonzini wrote:
> Register the notifier using the specific API for block devices.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/write-threshold.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]