From: Reza Arbab <arbab@linux.vnet.ibm.com> To: Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Bharata B Rao <bharata@linux.vnet.ibm.com>, Nathan Fontenot <nfont@linux.vnet.ibm.com>, Stewart Smith <stewart@linux.vnet.ibm.com>, Alistair Popple <apopple@au1.ibm.com>, Balbir Singh <bsingharora@gmail.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Tang Chen <tangchen@cn.fujitsu.com>, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes Date: Thu, 6 Oct 2016 13:36:32 -0500 [thread overview] Message-ID: <1475778995-1420-3-git-send-email-arbab@linux.vnet.ibm.com> (raw) In-Reply-To: <1475778995-1420-1-git-send-email-arbab@linux.vnet.ibm.com> Respect the standard dt "status" property when scanning memory nodes in early_init_dt_scan_memory(), so that if the node is unavailable, no memory will be added. The use case at hand is accelerator or device memory, which may be unusable until post-boot initialization of the memory link. Such a node can be described in the dt as any other, given its status is "disabled". Per the device tree specification, "disabled" Indicates that the device is not presently operational, but it might become operational in the future (for example, something is not plugged in, or switched off). Once such memory is made operational, it can then be hotplugged. Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> --- drivers/of/fdt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index b138efb..08e5d94 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -1056,6 +1056,9 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname, } else if (strcmp(type, "memory") != 0) return 0; + if (!of_flat_dt_device_is_available(node)) + return 0; + reg = of_get_flat_dt_prop(node, "linux,usable-memory", &l); if (reg == NULL) reg = of_get_flat_dt_prop(node, "reg", &l); -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Reza Arbab <arbab@linux.vnet.ibm.com> To: Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Bharata B Rao <bharata@linux.vnet.ibm.com>, Nathan Fontenot <nfont@linux.vnet.ibm.com>, Stewart Smith <stewart@linux.vnet.ibm.com>, Alistair Popple <apopple@au1.ibm.com>, Balbir Singh <bsingharora@gmail.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Tang Chen <tangchen@cn.fujitsu.com>, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes Date: Thu, 6 Oct 2016 13:36:32 -0500 [thread overview] Message-ID: <1475778995-1420-3-git-send-email-arbab@linux.vnet.ibm.com> (raw) In-Reply-To: <1475778995-1420-1-git-send-email-arbab@linux.vnet.ibm.com> Respect the standard dt "status" property when scanning memory nodes in early_init_dt_scan_memory(), so that if the node is unavailable, no memory will be added. The use case at hand is accelerator or device memory, which may be unusable until post-boot initialization of the memory link. Such a node can be described in the dt as any other, given its status is "disabled". Per the device tree specification, "disabled" Indicates that the device is not presently operational, but it might become operational in the future (for example, something is not plugged in, or switched off). Once such memory is made operational, it can then be hotplugged. Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> --- drivers/of/fdt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index b138efb..08e5d94 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -1056,6 +1056,9 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname, } else if (strcmp(type, "memory") != 0) return 0; + if (!of_flat_dt_device_is_available(node)) + return 0; + reg = of_get_flat_dt_prop(node, "linux,usable-memory", &l); if (reg == NULL) reg = of_get_flat_dt_prop(node, "reg", &l); -- 1.8.3.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-06 18:38 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-06 18:36 [PATCH v4 0/5] powerpc/mm: movable hotplug memory nodes Reza Arbab 2016-10-06 18:36 ` Reza Arbab 2016-10-06 18:36 ` [PATCH v4 1/5] drivers/of: introduce of_fdt_device_is_available() Reza Arbab 2016-10-06 18:36 ` Reza Arbab 2016-10-06 18:36 ` Reza Arbab [this message] 2016-10-06 18:36 ` [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes Reza Arbab 2016-10-11 13:58 ` Rob Herring 2016-10-11 13:58 ` Rob Herring 2016-10-21 6:22 ` Alistair Popple 2016-10-21 6:22 ` Alistair Popple 2016-10-23 1:51 ` Reza Arbab 2016-10-23 1:51 ` Reza Arbab 2016-10-24 10:24 ` Michael Ellerman 2016-10-24 10:24 ` Michael Ellerman 2016-10-24 18:20 ` Reza Arbab 2016-10-24 18:20 ` Reza Arbab 2016-10-24 18:20 ` Reza Arbab 2016-10-06 18:36 ` [PATCH v4 3/5] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab 2016-10-06 18:36 ` Reza Arbab 2016-10-20 3:30 ` Balbir Singh 2016-10-20 3:30 ` Balbir Singh 2016-10-20 3:30 ` Balbir Singh 2016-10-20 14:38 ` Reza Arbab 2016-10-20 14:38 ` Reza Arbab 2016-10-20 14:38 ` Reza Arbab 2016-10-25 9:39 ` Michael Ellerman 2016-10-25 9:39 ` Michael Ellerman 2016-10-06 18:36 ` [PATCH v4 4/5] mm: make processing of movable_node arch-specific Reza Arbab 2016-10-06 18:36 ` Reza Arbab 2016-10-06 18:36 ` Reza Arbab 2016-10-07 6:37 ` Aneesh Kumar K.V 2016-10-07 6:37 ` Aneesh Kumar K.V 2016-10-07 6:37 ` Aneesh Kumar K.V 2016-10-11 12:26 ` Balbir Singh 2016-10-11 12:26 ` Balbir Singh 2016-10-25 12:15 ` Balbir Singh 2016-10-25 12:15 ` Balbir Singh 2016-10-25 15:55 ` Reza Arbab 2016-10-25 15:55 ` Reza Arbab 2016-10-25 22:34 ` Balbir Singh 2016-10-25 22:34 ` Balbir Singh 2016-10-26 0:49 ` Reza Arbab 2016-10-26 0:49 ` Reza Arbab 2016-10-26 10:52 ` Michael Ellerman 2016-10-26 10:52 ` Michael Ellerman 2016-10-26 17:03 ` Reza Arbab 2016-10-26 17:03 ` Reza Arbab 2016-10-25 22:59 ` Balbir Singh 2016-10-25 22:59 ` Balbir Singh 2016-10-06 18:36 ` [PATCH v4 5/5] mm: enable CONFIG_MOVABLE_NODE on non-x86 arches Reza Arbab 2016-10-06 18:36 ` Reza Arbab 2016-10-07 6:40 ` Aneesh Kumar K.V 2016-10-07 6:40 ` Aneesh Kumar K.V 2016-10-11 13:17 ` Balbir Singh 2016-10-11 13:17 ` Balbir Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1475778995-1420-3-git-send-email-arbab@linux.vnet.ibm.com \ --to=arbab@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=aneesh.kumar@linux.vnet.ibm.com \ --cc=apopple@au1.ibm.com \ --cc=benh@kernel.crashing.org \ --cc=bharata@linux.vnet.ibm.com \ --cc=bsingharora@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=nfont@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=robh+dt@kernel.org \ --cc=stewart@linux.vnet.ibm.com \ --cc=tangchen@cn.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.