[PATCH] drivers mtd: spi-nor: add new variants

[PATCH] drivers mtd: spi-nor: add new variants

[Alexander Kurz]

Add spi-nor variants found in ebook readers.

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 drivers/mtd/spi-nor/spi-nor.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..649f54e 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -868,6 +868,8 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
+	{ "mx25u4035",   INFO(0xc22533, 0, 64 * 1024,   8, SECT_4K) },
+	{ "mx25u8035",   INFO(0xc22534, 0, 64 * 1024,  16, SECT_4K) },
 	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
 	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
 	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
@@ -980,6 +982,9 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "w25x80", INFO(0xef3014, 0, 64 * 1024,  16, SECT_4K) },
 	{ "w25x16", INFO(0xef3015, 0, 64 * 1024,  32, SECT_4K) },
 	{ "w25x32", INFO(0xef3016, 0, 64 * 1024,  64, SECT_4K) },
+	{ "w25q20cl", INFO(0xef4012, 0, 64 * 1024,  4, SECT_4K) },
+	{ "w25q20bw", INFO(0xef5012, 0, 64 * 1024,  4, SECT_4K) },
+	{ "w25q20ew", INFO(0xef6012, 0, 64 * 1024,  4, SECT_4K) },
 	{ "w25q32", INFO(0xef4016, 0, 64 * 1024,  64, SECT_4K) },
 	{
 		"w25q32dw", INFO(0xef6016, 0, 64 * 1024,  64,
-- 
2.1.4

Re: [PATCH] drivers mtd: spi-nor: add new variants

[Moritz Fischer]

Hi Alex,

On Sun, Oct 9, 2016 at 3:45 PM, Alexander Kurz <akurz@blala.de> wrote:
> Add spi-nor variants found in ebook readers.

Would be interesting which ones (i.e. can you edit the commit message?

Thanks,

Moritz

Re: [PATCH] drivers mtd: spi-nor: add new variants

[Alexander Kurz]

>From 27d3d578dacd2b9cb80338517f73decb169e46ec Mon Sep 17 00:00:00 2001
From: Alexander Kurz <akurz@blala.de>
Date: Fri, 7 Oct 2016 17:06:10 +0200
Subject: [PATCH] drivers mtd: spi-nor: add new variants

Macronix MX25U4035 and Winbond 25Q20BW devices are used in 4/5th
generation Kindle ebook readers. Add those spi-nor variants.
Also add similar devices found in the same datasheets.

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 drivers/mtd/spi-nor/spi-nor.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..649f54e 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -868,6 +868,8 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
+	{ "mx25u4035",   INFO(0xc22533, 0, 64 * 1024,   8, SECT_4K) },
+	{ "mx25u8035",   INFO(0xc22534, 0, 64 * 1024,  16, SECT_4K) },
 	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
 	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
 	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
@@ -980,6 +982,9 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "w25x80", INFO(0xef3014, 0, 64 * 1024,  16, SECT_4K) },
 	{ "w25x16", INFO(0xef3015, 0, 64 * 1024,  32, SECT_4K) },
 	{ "w25x32", INFO(0xef3016, 0, 64 * 1024,  64, SECT_4K) },
+	{ "w25q20cl", INFO(0xef4012, 0, 64 * 1024,  4, SECT_4K) },
+	{ "w25q20bw", INFO(0xef5012, 0, 64 * 1024,  4, SECT_4K) },
+	{ "w25q20ew", INFO(0xef6012, 0, 64 * 1024,  4, SECT_4K) },
 	{ "w25q32", INFO(0xef4016, 0, 64 * 1024,  64, SECT_4K) },
 	{
 		"w25q32dw", INFO(0xef6016, 0, 64 * 1024,  64,
-- 
2.1.4

Re: [PATCH] drivers mtd: spi-nor: add new variants

[Moritz Fischer]

Hi Alexander,

On Thu, Oct 13, 2016 at 11:00 AM, Alexander Kurz <akurz@blala.de> wrote:
> From 27d3d578dacd2b9cb80338517f73decb169e46ec Mon Sep 17 00:00:00 2001
> From: Alexander Kurz <akurz@blala.de>
> Date: Fri, 7 Oct 2016 17:06:10 +0200
> Subject: [PATCH] drivers mtd: spi-nor: add new variants

if you change the patch you should prefix it with PATCH vX (e.g. 2 in
this case),
since it's your second revision.

If you use git-format to generate your patch you can just append a -v2
to your command
to automatically do this.

This allows for easier tracking which revision of the patch the people
reviewing your
patch are looking at.

Also it's (for more complicated patches mostly) nice to wait a bit
between sending revisions,
to give people time to comment on it.

Thanks,

Moritz