All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] usb/gadget: use kasprintf() instead of open coding it
@ 2016-10-10 10:48 Juergen Gross
  0 siblings, 0 replies; only message in thread
From: Juergen Gross @ 2016-10-10 10:48 UTC (permalink / raw)
  To: linux-kernel, linux-usb; +Cc: gregkh, balbi, Juergen Gross

Use kasprintf() instead of open coding it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/usb/gadget/composite.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 32176f7..455efec 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -2382,18 +2382,8 @@ EXPORT_SYMBOL_GPL(usb_composite_setup_continue);
 
 static char *composite_default_mfr(struct usb_gadget *gadget)
 {
-	char *mfr;
-	int len;
-
-	len = snprintf(NULL, 0, "%s %s with %s", init_utsname()->sysname,
-			init_utsname()->release, gadget->name);
-	len++;
-	mfr = kmalloc(len, GFP_KERNEL);
-	if (!mfr)
-		return NULL;
-	snprintf(mfr, len, "%s %s with %s", init_utsname()->sysname,
-			init_utsname()->release, gadget->name);
-	return mfr;
+	return kasprintf(GFP_KERNEL, "%s %s with %s", init_utsname()->sysname,
+			 init_utsname()->release, gadget->name);
 }
 
 void usb_composite_overwrite_options(struct usb_composite_dev *cdev,
-- 
2.6.6

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-10 10:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-10 10:48 [PATCH v2] usb/gadget: use kasprintf() instead of open coding it Juergen Gross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.