* [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue
@ 2016-10-11 23:22 Chase Metzger
2016-10-12 5:59 ` Vaibhav Agarwal
0 siblings, 1 reply; 2+ messages in thread
From: Chase Metzger @ 2016-10-11 23:22 UTC (permalink / raw)
To: vaibhav.sr
Cc: Chase Metzger, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, devel, linux-kernel
Added braces to else and else if statements where checkpatch complained.
Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
---
drivers/staging/greybus/audio_manager_sysfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
index d8bf859..376e17c 100644
--- a/drivers/staging/greybus/audio_manager_sysfs.c
+++ b/drivers/staging/greybus/audio_manager_sysfs.c
@@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store(
num = gb_audio_manager_dump_module(id);
if (num)
return num;
- } else if (!strncmp("all", buf, 3))
+ } else if (!strncmp("all", buf, 3)) {
gb_audio_manager_dump_all();
- else
+ } else {
return -EINVAL;
+ }
return count;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue
2016-10-11 23:22 [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue Chase Metzger
@ 2016-10-12 5:59 ` Vaibhav Agarwal
0 siblings, 0 replies; 2+ messages in thread
From: Vaibhav Agarwal @ 2016-10-12 5:59 UTC (permalink / raw)
To: Chase Metzger
Cc: Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel,
linux-kernel
On Wed, Oct 12, 2016 at 4:52 AM, Chase Metzger <chasemetzger15@gmail.com> wrote:
> Added braces to else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/staging/greybus/audio_manager_sysfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index d8bf859..376e17c 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store(
> num = gb_audio_manager_dump_module(id);
> if (num)
> return num;
> - } else if (!strncmp("all", buf, 3))
> + } else if (!strncmp("all", buf, 3)) {
> gb_audio_manager_dump_all();
> - else
> + } else {
> return -EINVAL;
> + }
>
> return count;
> }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-12 6:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-11 23:22 [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue Chase Metzger
2016-10-12 5:59 ` Vaibhav Agarwal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.