[PATCH -next] crypto: gcm - Fix error return code in crypto_gcm_create_common()

* [PATCH -next] crypto: gcm - Fix error return code in crypto_gcm_create_common()
@ 2016-10-17 15:10 Wei Yongjun
  2016-10-25  3:39 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-10-17 15:10 UTC (permalink / raw)
  To: Herbert Xu; +Cc: Wei Yongjun, linux-crypto

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return error code -EINVAL from the invalid alg ivsize error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 crypto/gcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/gcm.c b/crypto/gcm.c
index f624ac9..39c261d 100644
--- a/crypto/gcm.c
+++ b/crypto/gcm.c
@@ -672,11 +672,11 @@ static int crypto_gcm_create_common(struct crypto_template *tmpl,
 	ctr = crypto_spawn_skcipher_alg(&ctx->ctr);
 
 	/* We only support 16-byte blocks. */
+	err = -EINVAL;
 	if (crypto_skcipher_alg_ivsize(ctr) != 16)
 		goto out_put_ctr;
 
 	/* Not a stream cipher? */
-	err = -EINVAL;
 	if (ctr->base.cra_blocksize != 1)
 		goto out_put_ctr;

^ permalink raw reply related	[flat|nested] 2+ messages in thread