All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] mmc: mediatek: Fix module autoload
@ 2016-10-17 16:13 ` Javier Martinez Canillas
  0 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 16:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Javier Martinez Canillas, linux-mmc, Geert Uytterhoeven,
	Douglas Anderson, linux-mediatek, linux-arm-kernel,
	Chaotian Jing, Nicolas Boichat, Matthias Brugger, Ulf Hansson

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
$

After this patch:

$ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
alias:          of:N*T*Cmediatek,mt8135-mmcC*
alias:          of:N*T*Cmediatek,mt8135-mmc

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 84e9afcb5c09..86af0b199a54 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1713,6 +1713,7 @@ static const struct of_device_id msdc_of_ids[] = {
 	{   .compatible = "mediatek,mt8135-mmc", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, msdc_of_ids);
 
 static struct platform_driver mt_msdc_driver = {
 	.probe = msdc_drv_probe,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/2] mmc: mediatek: Fix module autoload
@ 2016-10-17 16:13 ` Javier Martinez Canillas
  0 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 16:13 UTC (permalink / raw)
  To: linux-arm-kernel

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
$

After this patch:

$ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
alias:          of:N*T*Cmediatek,mt8135-mmcC*
alias:          of:N*T*Cmediatek,mt8135-mmc

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 84e9afcb5c09..86af0b199a54 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1713,6 +1713,7 @@ static const struct of_device_id msdc_of_ids[] = {
 	{   .compatible = "mediatek,mt8135-mmc", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, msdc_of_ids);
 
 static struct platform_driver mt_msdc_driver = {
 	.probe = msdc_drv_probe,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
  2016-10-17 16:13 ` Javier Martinez Canillas
  (?)
@ 2016-10-17 16:13 ` Javier Martinez Canillas
  2016-10-21  6:48     ` Ludovic Desroches
  2016-10-21  8:21   ` Ulf Hansson
  -1 siblings, 2 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 16:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Javier Martinez Canillas, Ludovic Desroches, linux-mmc,
	Adrian Hunter, Ulf Hansson

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
$

After this patch:

$ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
alias:          of:N*T*Catmel,sama5d2-sdhciC*
alias:          of:N*T*Catmel,sama5d2-sdhci

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/mmc/host/sdhci-of-at91.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index a9b7fc06c434..2f9ad213377a 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
 	{ .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
 	{}
 };
+MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
 
 #ifdef CONFIG_PM
 static int sdhci_at91_runtime_suspend(struct device *dev)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
  2016-10-17 16:13 ` [PATCH 2/2] mmc: sdhci-of-at91: " Javier Martinez Canillas
@ 2016-10-21  6:48     ` Ludovic Desroches
  2016-10-21  8:21   ` Ulf Hansson
  1 sibling, 0 replies; 10+ messages in thread
From: Ludovic Desroches @ 2016-10-21  6:48 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Ludovic Desroches, linux-mmc, Adrian Hunter, Ulf Hansson

On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> alias:          of:N*T*Catmel,sama5d2-sdhciC*
> alias:          of:N*T*Catmel,sama5d2-sdhci
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Thanks
> ---
> 
>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index a9b7fc06c434..2f9ad213377a 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>  	{ .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>  
>  #ifdef CONFIG_PM
>  static int sdhci_at91_runtime_suspend(struct device *dev)
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
@ 2016-10-21  6:48     ` Ludovic Desroches
  0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Desroches @ 2016-10-21  6:48 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Ludovic Desroches, linux-mmc, Adrian Hunter, Ulf Hansson

On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> alias:          of:N*T*Catmel,sama5d2-sdhciC*
> alias:          of:N*T*Catmel,sama5d2-sdhci
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Thanks
> ---
> 
>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index a9b7fc06c434..2f9ad213377a 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>  	{ .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>  
>  #ifdef CONFIG_PM
>  static int sdhci_at91_runtime_suspend(struct device *dev)
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
  2016-10-21  6:48     ` Ludovic Desroches
  (?)
@ 2016-10-21  7:23     ` Adrian Hunter
  -1 siblings, 0 replies; 10+ messages in thread
From: Adrian Hunter @ 2016-10-21  7:23 UTC (permalink / raw)
  To: Javier Martinez Canillas, linux-kernel, linux-mmc, Ulf Hansson

On 21/10/16 09:48, Ludovic Desroches wrote:
> On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
>> alias:          of:N*T*Catmel,sama5d2-sdhciC*
>> alias:          of:N*T*Catmel,sama5d2-sdhci
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> 
> Thanks
>> ---
>>
>>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
>> index a9b7fc06c434..2f9ad213377a 100644
>> --- a/drivers/mmc/host/sdhci-of-at91.c
>> +++ b/drivers/mmc/host/sdhci-of-at91.c
>> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>>  	{ .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>>  	{}
>>  };
>> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>>  
>>  #ifdef CONFIG_PM
>>  static int sdhci_at91_runtime_suspend(struct device *dev)
>> -- 
>> 2.7.4
>>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
  2016-10-17 16:13 ` [PATCH 2/2] mmc: sdhci-of-at91: " Javier Martinez Canillas
  2016-10-21  6:48     ` Ludovic Desroches
@ 2016-10-21  8:21   ` Ulf Hansson
  1 sibling, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-21  8:21 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Ludovic Desroches, linux-mmc, Adrian Hunter

On 17 October 2016 at 18:13, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> alias:          of:N*T*Catmel,sama5d2-sdhciC*
> alias:          of:N*T*Catmel,sama5d2-sdhci
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index a9b7fc06c434..2f9ad213377a 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>         { .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>         {}
>  };
> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>
>  #ifdef CONFIG_PM
>  static int sdhci_at91_runtime_suspend(struct device *dev)
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mmc: mediatek: Fix module autoload
  2016-10-17 16:13 ` Javier Martinez Canillas
  (?)
@ 2016-10-21  8:22   ` Ulf Hansson
  -1 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-21  8:22 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, linux-mmc, Geert Uytterhoeven, Douglas Anderson,
	linux-mediatek, linux-arm-kernel, Chaotian Jing, Nicolas Boichat,
	Matthias Brugger

On 17 October 2016 at 18:13, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> alias:          of:N*T*Cmediatek,mt8135-mmcC*
> alias:          of:N*T*Cmediatek,mt8135-mmc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 84e9afcb5c09..86af0b199a54 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1713,6 +1713,7 @@ static const struct of_device_id msdc_of_ids[] = {
>         {   .compatible = "mediatek,mt8135-mmc", },
>         {}
>  };
> +MODULE_DEVICE_TABLE(of, msdc_of_ids);
>
>  static struct platform_driver mt_msdc_driver = {
>         .probe = msdc_drv_probe,
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mmc: mediatek: Fix module autoload
@ 2016-10-21  8:22   ` Ulf Hansson
  0 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-21  8:22 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, linux-mmc, Geert Uytterhoeven, Douglas Anderson,
	linux-mediatek, linux-arm-kernel, Chaotian Jing, Nicolas Boichat,
	Matthias Brugger

On 17 October 2016 at 18:13, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> alias:          of:N*T*Cmediatek,mt8135-mmcC*
> alias:          of:N*T*Cmediatek,mt8135-mmc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 84e9afcb5c09..86af0b199a54 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1713,6 +1713,7 @@ static const struct of_device_id msdc_of_ids[] = {
>         {   .compatible = "mediatek,mt8135-mmc", },
>         {}
>  };
> +MODULE_DEVICE_TABLE(of, msdc_of_ids);
>
>  static struct platform_driver mt_msdc_driver = {
>         .probe = msdc_drv_probe,
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] mmc: mediatek: Fix module autoload
@ 2016-10-21  8:22   ` Ulf Hansson
  0 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2016-10-21  8:22 UTC (permalink / raw)
  To: linux-arm-kernel

On 17 October 2016 at 18:13, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mmc/host/mtk-sd.ko | grep alias
> alias:          of:N*T*Cmediatek,mt8135-mmcC*
> alias:          of:N*T*Cmediatek,mt8135-mmc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 84e9afcb5c09..86af0b199a54 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1713,6 +1713,7 @@ static const struct of_device_id msdc_of_ids[] = {
>         {   .compatible = "mediatek,mt8135-mmc", },
>         {}
>  };
> +MODULE_DEVICE_TABLE(of, msdc_of_ids);
>
>  static struct platform_driver mt_msdc_driver = {
>         .probe = msdc_drv_probe,
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-10-21  8:22 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 16:13 [PATCH 1/2] mmc: mediatek: Fix module autoload Javier Martinez Canillas
2016-10-17 16:13 ` Javier Martinez Canillas
2016-10-17 16:13 ` [PATCH 2/2] mmc: sdhci-of-at91: " Javier Martinez Canillas
2016-10-21  6:48   ` Ludovic Desroches
2016-10-21  6:48     ` Ludovic Desroches
2016-10-21  7:23     ` Adrian Hunter
2016-10-21  8:21   ` Ulf Hansson
2016-10-21  8:22 ` [PATCH 1/2] mmc: mediatek: " Ulf Hansson
2016-10-21  8:22   ` Ulf Hansson
2016-10-21  8:22   ` Ulf Hansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.