All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings
@ 2016-10-17 20:29 Laurent Pinchart
  2016-10-17 20:29 ` [PATCH 1/2] dt-bindings: media: renesas-fcp: " Laurent Pinchart
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Laurent Pinchart @ 2016-10-17 20:29 UTC (permalink / raw)
  To: linux-renesas-soc

Hello,

Now that the Gen3 documentation mentions the FCP version register, it's clear
that the SoC instance in which the FCP is integrated can be identified at
runtime without requiring SoC-specific compatible strings.

I've tested R-Car H3 ES1.x and R-Car M3 and the results match the
documentation, so it should be safe to use the generic compatible strings
only.

Laurent Pinchart (2):
  dt-bindings: media: renesas-fcp: Remove SoC-specific compatible
    strings
  arm64: dts: r8a7795: Remove FCP SoC-specific compatible strings

 .../devicetree/bindings/media/renesas,fcp.txt      |  8 +-------
 arch/arm64/boot/dts/renesas/r8a7795.dtsi           | 24 +++++++++++-----------
 2 files changed, 13 insertions(+), 19 deletions(-)

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: media: renesas-fcp: Remove SoC-specific compatible strings
  2016-10-17 20:29 [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings Laurent Pinchart
@ 2016-10-17 20:29 ` Laurent Pinchart
  2016-10-18  8:06   ` Geert Uytterhoeven
  2016-10-17 20:29 ` [PATCH 2/2] arm64: dts: r8a7795: Remove FCP " Laurent Pinchart
  2016-10-20  8:55 ` [PATCH 0/2] R-Car FDP: Remove " Simon Horman
  2 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2016-10-17 20:29 UTC (permalink / raw)
  To: linux-renesas-soc

The FCP IP cores include a version register that identifies which SoC
model the IP is integrated in. SoC-specific compatible strings are not
needed.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 27f9b8e459ac..3ec91803ba58 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -11,15 +11,9 @@ are paired with. These DT bindings currently support the FCPV and FCPF.
 
  - compatible: Must be one or more of the following
 
-   - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
-   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for FDP'
    - "renesas,fcpv" for generic compatible 'FCP for VSP'
    - "renesas,fcpf" for generic compatible 'FCP for FDP'
 
-   When compatible with the generic version, nodes must list the
-   SoC-specific version corresponding to the platform first, followed by the
-   family-specific and/or generic versions.
-
  - reg: the register base and size for the device registers
  - clocks: Reference to the functional clock
 
@@ -32,7 +26,7 @@ Device node example
 -------------------
 
 	fcpvd1: fcp@fea2f000 {
-		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+		compatible = "renesas,fcpv";
 		reg = <0 0xfea2f000 0 0x200>;
 		clocks = <&cpg CPG_MOD 602>;
 		power-domains = <&sysc R8A7795_PD_A3VP>;
-- 
Regards,

Laurent Pinchart

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] arm64: dts: r8a7795: Remove FCP SoC-specific compatible strings
  2016-10-17 20:29 [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings Laurent Pinchart
  2016-10-17 20:29 ` [PATCH 1/2] dt-bindings: media: renesas-fcp: " Laurent Pinchart
@ 2016-10-17 20:29 ` Laurent Pinchart
  2016-10-18  8:06   ` Geert Uytterhoeven
  2016-10-20  8:55 ` [PATCH 0/2] R-Car FDP: Remove " Simon Horman
  2 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2016-10-17 20:29 UTC (permalink / raw)
  To: linux-renesas-soc

The SoC-specific compatible strings have been removed from the FCP DT
bindings, removed them from the device tree.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 8c15040f2540..681f54422375 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1306,28 +1306,28 @@
 		};
 
 		fcpvb1: fcp@fe92f000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfe92f000 0 0x200>;
 			clocks = <&cpg CPG_MOD 606>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
 		};
 
 		fcpf0: fcp@fe950000 {
-			compatible = "renesas,r8a7795-fcpf", "renesas,fcpf";
+			compatible = "renesas,fcpf";
 			reg = <0 0xfe950000 0 0x200>;
 			clocks = <&cpg CPG_MOD 615>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
 		};
 
 		fcpf1: fcp@fe951000 {
-			compatible = "renesas,r8a7795-fcpf", "renesas,fcpf";
+			compatible = "renesas,fcpf";
 			reg = <0 0xfe951000 0 0x200>;
 			clocks = <&cpg CPG_MOD 614>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
 		};
 
 		fcpf2: fcp@fe952000 {
-			compatible = "renesas,r8a7795-fcpf", "renesas,fcpf";
+			compatible = "renesas,fcpf";
 			reg = <0 0xfe952000 0 0x200>;
 			clocks = <&cpg CPG_MOD 613>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
@@ -1344,7 +1344,7 @@
 		};
 
 		fcpvb0: fcp@fe96f000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfe96f000 0 0x200>;
 			clocks = <&cpg CPG_MOD 607>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
@@ -1361,7 +1361,7 @@
 		};
 
 		fcpvi0: fcp@fe9af000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfe9af000 0 0x200>;
 			clocks = <&cpg CPG_MOD 611>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
@@ -1378,7 +1378,7 @@
 		};
 
 		fcpvi1: fcp@fe9bf000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfe9bf000 0 0x200>;
 			clocks = <&cpg CPG_MOD 610>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
@@ -1395,7 +1395,7 @@
 		};
 
 		fcpvi2: fcp@fe9cf000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfe9cf000 0 0x200>;
 			clocks = <&cpg CPG_MOD 609>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
@@ -1412,7 +1412,7 @@
 		};
 
 		fcpvd0: fcp@fea27000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfea27000 0 0x200>;
 			clocks = <&cpg CPG_MOD 603>;
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
@@ -1429,7 +1429,7 @@
 		};
 
 		fcpvd1: fcp@fea2f000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfea2f000 0 0x200>;
 			clocks = <&cpg CPG_MOD 602>;
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
@@ -1446,7 +1446,7 @@
 		};
 
 		fcpvd2: fcp@fea37000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfea37000 0 0x200>;
 			clocks = <&cpg CPG_MOD 601>;
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
@@ -1463,7 +1463,7 @@
 		};
 
 		fcpvd3: fcp@fea3f000 {
-			compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
+			compatible = "renesas,fcpv";
 			reg = <0 0xfea3f000 0 0x200>;
 			clocks = <&cpg CPG_MOD 600>;
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
-- 
Regards,

Laurent Pinchart

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: media: renesas-fcp: Remove SoC-specific compatible strings
  2016-10-17 20:29 ` [PATCH 1/2] dt-bindings: media: renesas-fcp: " Laurent Pinchart
@ 2016-10-18  8:06   ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-10-18  8:06 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Linux-Renesas

On Mon, Oct 17, 2016 at 10:29 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The FCP IP cores include a version register that identifies which SoC
> model the IP is integrated in. SoC-specific compatible strings are not
> needed.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: dts: r8a7795: Remove FCP SoC-specific compatible strings
  2016-10-17 20:29 ` [PATCH 2/2] arm64: dts: r8a7795: Remove FCP " Laurent Pinchart
@ 2016-10-18  8:06   ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-10-18  8:06 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Linux-Renesas

On Mon, Oct 17, 2016 at 10:29 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The SoC-specific compatible strings have been removed from the FCP DT
> bindings, removed them from the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings
  2016-10-17 20:29 [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings Laurent Pinchart
  2016-10-17 20:29 ` [PATCH 1/2] dt-bindings: media: renesas-fcp: " Laurent Pinchart
  2016-10-17 20:29 ` [PATCH 2/2] arm64: dts: r8a7795: Remove FCP " Laurent Pinchart
@ 2016-10-20  8:55 ` Simon Horman
  2 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2016-10-20  8:55 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linux-renesas-soc

On Mon, Oct 17, 2016 at 11:29:01PM +0300, Laurent Pinchart wrote:
> Hello,
> 
> Now that the Gen3 documentation mentions the FCP version register, it's clear
> that the SoC instance in which the FCP is integrated can be identified at
> runtime without requiring SoC-specific compatible strings.
> 
> I've tested R-Car H3 ES1.x and R-Car M3 and the results match the
> documentation, so it should be safe to use the generic compatible strings
> only.

I have queued series this up with with Geert's tags.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-10-20  9:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 20:29 [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings Laurent Pinchart
2016-10-17 20:29 ` [PATCH 1/2] dt-bindings: media: renesas-fcp: " Laurent Pinchart
2016-10-18  8:06   ` Geert Uytterhoeven
2016-10-17 20:29 ` [PATCH 2/2] arm64: dts: r8a7795: Remove FCP " Laurent Pinchart
2016-10-18  8:06   ` Geert Uytterhoeven
2016-10-20  8:55 ` [PATCH 0/2] R-Car FDP: Remove " Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.