* [PATCH 0/3] R-Car M3-W: Add FCP, VSP and DU clocks
@ 2016-10-17 21:12 Laurent Pinchart
2016-10-17 21:12 ` [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks Laurent Pinchart
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Laurent Pinchart @ 2016-10-17 21:12 UTC (permalink / raw)
To: linux-renesas-soc
Hello,
This patch series adds all the r8a7796 FCP, VSP and DU clocks. This includes
not only all the clocks required for display, but also the FCPC, FCPF, VSPB
and VSPI0 clocks to cover all the FCP and VSP instances.
The FCPC and DU parent clocks haven't been confirmed yet. I'm however quite
confident that at least the DU clocks are correct, as they both match the
corresponding VSPD clocks (the VSPD supplying frames to the DU, it makes sense
to have both IP cores clocked from the same source) and result in the right
display ouput timings (while setting the DU parent clocks to S0D1 results in
half the expected frame rate).
Laurent Pinchart (3):
clk: renesas: r8a7796: Add FCP clocks
clk: renesas: r8a7796: Add VSP clocks
clk: renesas: r8a7796: Add DU and LVDS clocks
drivers/clk/renesas/r8a7796-cpg-mssr.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks
2016-10-17 21:12 [PATCH 0/3] R-Car M3-W: Add FCP, VSP and DU clocks Laurent Pinchart
@ 2016-10-17 21:12 ` Laurent Pinchart
2016-10-18 8:28 ` Geert Uytterhoeven
2016-10-17 21:12 ` [PATCH 2/3] clk: renesas: r8a7796: Add VSP clocks Laurent Pinchart
2016-10-17 21:12 ` [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks Laurent Pinchart
2 siblings, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2016-10-17 21:12 UTC (permalink / raw)
To: linux-renesas-soc
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/clk/renesas/r8a7796-cpg-mssr.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index eb347ed265f2..41a3677a4b3a 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -121,6 +121,14 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
DEF_MOD("rwdt0", 402, R8A7796_CLK_R),
DEF_MOD("intc-ap", 408, R8A7796_CLK_S3D1),
DEF_MOD("thermal", 522, R8A7796_CLK_CP),
+ DEF_MOD("fcpvd2", 601, R8A7796_CLK_S0D2),
+ DEF_MOD("fcpvd1", 602, R8A7796_CLK_S0D2),
+ DEF_MOD("fcpvd0", 603, R8A7796_CLK_S0D2),
+ DEF_MOD("fcpvb0", 607, R8A7796_CLK_S0D1),
+ DEF_MOD("fcpvi0", 611, R8A7796_CLK_S0D1),
+ DEF_MOD("fcpf0", 615, R8A7796_CLK_S0D1),
+ DEF_MOD("fcpci0", 617, R8A7796_CLK_S0D1),
+ DEF_MOD("fcpcs", 619, R8A7796_CLK_S0D1),
DEF_MOD("etheravb", 812, R8A7796_CLK_S0D6),
DEF_MOD("gpio7", 905, R8A7796_CLK_S3D4),
DEF_MOD("gpio6", 906, R8A7796_CLK_S3D4),
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] clk: renesas: r8a7796: Add VSP clocks
2016-10-17 21:12 [PATCH 0/3] R-Car M3-W: Add FCP, VSP and DU clocks Laurent Pinchart
2016-10-17 21:12 ` [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks Laurent Pinchart
@ 2016-10-17 21:12 ` Laurent Pinchart
2016-10-18 8:29 ` Geert Uytterhoeven
2016-10-17 21:12 ` [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks Laurent Pinchart
2 siblings, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2016-10-17 21:12 UTC (permalink / raw)
To: linux-renesas-soc
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/clk/renesas/r8a7796-cpg-mssr.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 41a3677a4b3a..679054658f99 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -129,6 +129,11 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
DEF_MOD("fcpf0", 615, R8A7796_CLK_S0D1),
DEF_MOD("fcpci0", 617, R8A7796_CLK_S0D1),
DEF_MOD("fcpcs", 619, R8A7796_CLK_S0D1),
+ DEF_MOD("vspd2", 621, R8A7796_CLK_S0D2),
+ DEF_MOD("vspd1", 622, R8A7796_CLK_S0D2),
+ DEF_MOD("vspd0", 623, R8A7796_CLK_S0D2),
+ DEF_MOD("vspb", 626, R8A7796_CLK_S0D1),
+ DEF_MOD("vspi0", 631, R8A7796_CLK_S0D1),
DEF_MOD("etheravb", 812, R8A7796_CLK_S0D6),
DEF_MOD("gpio7", 905, R8A7796_CLK_S3D4),
DEF_MOD("gpio6", 906, R8A7796_CLK_S3D4),
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks
2016-10-17 21:12 [PATCH 0/3] R-Car M3-W: Add FCP, VSP and DU clocks Laurent Pinchart
2016-10-17 21:12 ` [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks Laurent Pinchart
2016-10-17 21:12 ` [PATCH 2/3] clk: renesas: r8a7796: Add VSP clocks Laurent Pinchart
@ 2016-10-17 21:12 ` Laurent Pinchart
2016-10-18 8:31 ` Geert Uytterhoeven
2 siblings, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2016-10-17 21:12 UTC (permalink / raw)
To: linux-renesas-soc
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/clk/renesas/r8a7796-cpg-mssr.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 679054658f99..20bd0643b238 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -134,6 +134,10 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
DEF_MOD("vspd0", 623, R8A7796_CLK_S0D2),
DEF_MOD("vspb", 626, R8A7796_CLK_S0D1),
DEF_MOD("vspi0", 631, R8A7796_CLK_S0D1),
+ DEF_MOD("du2", 722, R8A7796_CLK_S0D2),
+ DEF_MOD("du1", 723, R8A7796_CLK_S0D2),
+ DEF_MOD("du0", 724, R8A7796_CLK_S0D2),
+ DEF_MOD("lvds", 727, R8A7796_CLK_S0D4),
DEF_MOD("etheravb", 812, R8A7796_CLK_S0D6),
DEF_MOD("gpio7", 905, R8A7796_CLK_S3D4),
DEF_MOD("gpio6", 906, R8A7796_CLK_S3D4),
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks
2016-10-17 21:12 ` [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks Laurent Pinchart
@ 2016-10-18 8:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-10-18 8:28 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux-Renesas
On Mon, Oct 17, 2016 at 11:12 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] clk: renesas: r8a7796: Add VSP clocks
2016-10-17 21:12 ` [PATCH 2/3] clk: renesas: r8a7796: Add VSP clocks Laurent Pinchart
@ 2016-10-18 8:29 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-10-18 8:29 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux-Renesas
On Mon, Oct 17, 2016 at 11:12 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks
2016-10-17 21:12 ` [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks Laurent Pinchart
@ 2016-10-18 8:31 ` Geert Uytterhoeven
2016-10-18 8:33 ` Laurent Pinchart
0 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-10-18 8:31 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux-Renesas
On Mon, Oct 17, 2016 at 11:12 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/clk/renesas/r8a7796-cpg-mssr.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> index 679054658f99..20bd0643b238 100644
> --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> @@ -134,6 +134,10 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
> DEF_MOD("vspd0", 623, R8A7796_CLK_S0D2),
> DEF_MOD("vspb", 626, R8A7796_CLK_S0D1),
> DEF_MOD("vspi0", 631, R8A7796_CLK_S0D1),
> + DEF_MOD("du2", 722, R8A7796_CLK_S0D2),
> + DEF_MOD("du1", 723, R8A7796_CLK_S0D2),
> + DEF_MOD("du0", 724, R8A7796_CLK_S0D2),
I'll fix up the DU parent clock to S2D1 now we got confirmation.
> + DEF_MOD("lvds", 727, R8A7796_CLK_S0D4),
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks
2016-10-18 8:31 ` Geert Uytterhoeven
@ 2016-10-18 8:33 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2016-10-18 8:33 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Laurent Pinchart, Linux-Renesas
Hi Geert,
On Tuesday 18 Oct 2016 10:31:10 Geert Uytterhoeven wrote:
> On Mon, Oct 17, 2016 at 11:12 PM, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > ---
> >
> > drivers/clk/renesas/r8a7796-cpg-mssr.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> > b/drivers/clk/renesas/r8a7796-cpg-mssr.c index 679054658f99..20bd0643b238
> > 100644
> > --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> > +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> > @@ -134,6 +134,10 @@ static const struct mssr_mod_clk r8a7796_mod_clks[]
> > __initconst = {
> > DEF_MOD("vspd0", 623, R8A7796_CLK_S0D2),
> > DEF_MOD("vspb", 626, R8A7796_CLK_S0D1),
> > DEF_MOD("vspi0", 631, R8A7796_CLK_S0D1),
> > + DEF_MOD("du2", 722, R8A7796_CLK_S0D2),
> > + DEF_MOD("du1", 723, R8A7796_CLK_S0D2),
> > + DEF_MOD("du0", 724, R8A7796_CLK_S0D2),
>
> I'll fix up the DU parent clock to S2D1 now we got confirmation.
Fixed in v2, sent out to the list, and pushed to
git://linuxtv.org/pinchartl/media.git drm/r8a7796/clk with your acks picked up
:-)
Can I assume you'll take the patches in your tree for v4.10 ?
> > + DEF_MOD("lvds", 727, R8A7796_CLK_S0D4),
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-18 8:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 21:12 [PATCH 0/3] R-Car M3-W: Add FCP, VSP and DU clocks Laurent Pinchart
2016-10-17 21:12 ` [PATCH 1/3] clk: renesas: r8a7796: Add FCP clocks Laurent Pinchart
2016-10-18 8:28 ` Geert Uytterhoeven
2016-10-17 21:12 ` [PATCH 2/3] clk: renesas: r8a7796: Add VSP clocks Laurent Pinchart
2016-10-18 8:29 ` Geert Uytterhoeven
2016-10-17 21:12 ` [PATCH 3/3] clk: renesas: r8a7796: Add DU and LVDS clocks Laurent Pinchart
2016-10-18 8:31 ` Geert Uytterhoeven
2016-10-18 8:33 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.