* [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o
@ 2016-10-18 12:43 Wei Liu
2016-10-18 15:58 ` Ian Jackson
2016-10-18 16:57 ` Stefano Stabellini
0 siblings, 2 replies; 4+ messages in thread
From: Wei Liu @ 2016-10-18 12:43 UTC (permalink / raw)
To: Xen-devel; +Cc: Ian Jackson, Stefano Stabellini, Wei Liu, Steve Capper
After 9c635883 ("ARM64: fix libxl build, do not include
../../xen/include") there is nothing special needed to build
libxl_arm_acpi.o. Remove the explicit rule, use predefined one.
Build tested on ARM64.
Suggested-by: Steve Capper <steve.capper@linaro.org>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Steve Capper <steve.capper@linaro.org>
---
tools/libxl/Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index dac19ac..79e4019 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -94,9 +94,6 @@ ifeq ($(CONFIG_ARM_64),y)
LIBXL_OBJS-y += libxl_arm_acpi.o dsdt_anycpu_arm.o
dsdt_anycpu_arm.c:
$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR)
-
-libxl_arm_acpi.o: libxl_arm_acpi.c
- $(CC) -c $(CFLAGS) -o $@ libxl_arm_acpi.c
else
LIBXL_OBJS-$(CONFIG_ARM) += libxl_arm_no_acpi.o
endif
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o
2016-10-18 12:43 [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o Wei Liu
@ 2016-10-18 15:58 ` Ian Jackson
2016-10-18 16:57 ` Stefano Stabellini
1 sibling, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2016-10-18 15:58 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Stefano Stabellini, Steve Capper
Wei Liu writes ("[PATCH] libxl: remove explicit rule for libxl_arm_acpi.o"):
> After 9c635883 ("ARM64: fix libxl build, do not include
> ../../xen/include") there is nothing special needed to build
> libxl_arm_acpi.o. Remove the explicit rule, use predefined one.
>
> Build tested on ARM64.
>
> Suggested-by: Steve Capper <steve.capper@linaro.org>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Based on your build test.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o
2016-10-18 12:43 [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o Wei Liu
2016-10-18 15:58 ` Ian Jackson
@ 2016-10-18 16:57 ` Stefano Stabellini
2016-10-18 17:01 ` Wei Liu
1 sibling, 1 reply; 4+ messages in thread
From: Stefano Stabellini @ 2016-10-18 16:57 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Stefano Stabellini, Ian Jackson, Steve Capper
On Tue, 18 Oct 2016, Wei Liu wrote:
> After 9c635883 ("ARM64: fix libxl build, do not include
> ../../xen/include") there is nothing special needed to build
> libxl_arm_acpi.o. Remove the explicit rule, use predefined one.
>
> Build tested on ARM64.
>
> Suggested-by: Steve Capper <steve.capper@linaro.org>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Steve Capper <steve.capper@linaro.org>
> ---
> tools/libxl/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dac19ac..79e4019 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -94,9 +94,6 @@ ifeq ($(CONFIG_ARM_64),y)
> LIBXL_OBJS-y += libxl_arm_acpi.o dsdt_anycpu_arm.o
> dsdt_anycpu_arm.c:
> $(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR)
> -
> -libxl_arm_acpi.o: libxl_arm_acpi.c
> - $(CC) -c $(CFLAGS) -o $@ libxl_arm_acpi.c
> else
> LIBXL_OBJS-$(CONFIG_ARM) += libxl_arm_no_acpi.o
> endif
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o
2016-10-18 16:57 ` Stefano Stabellini
@ 2016-10-18 17:01 ` Wei Liu
0 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2016-10-18 17:01 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Xen-devel, Wei Liu, Ian Jackson, Steve Capper
On Tue, Oct 18, 2016 at 09:57:53AM -0700, Stefano Stabellini wrote:
> On Tue, 18 Oct 2016, Wei Liu wrote:
> > After 9c635883 ("ARM64: fix libxl build, do not include
> > ../../xen/include") there is nothing special needed to build
> > libxl_arm_acpi.o. Remove the explicit rule, use predefined one.
> >
> > Build tested on ARM64.
> >
> > Suggested-by: Steve Capper <steve.capper@linaro.org>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
Applied. Thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-18 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18 12:43 [PATCH] libxl: remove explicit rule for libxl_arm_acpi.o Wei Liu
2016-10-18 15:58 ` Ian Jackson
2016-10-18 16:57 ` Stefano Stabellini
2016-10-18 17:01 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.