[PATCH] ARM: sti: stih410-clocks: Add PROC_STFE as a critical clock

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Peter Griffin <peter.griffin@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	patrice.chotard@st.com
Cc: peter.griffin@linaro.org, lee.jones@linaro.org,
	devicetree@vger.kernel.org
Subject: [PATCH] ARM: sti: stih410-clocks: Add PROC_STFE as a critical clock
Date: Tue, 18 Oct 2016 16:35:57 +0100	[thread overview]
Message-ID: <1476804957-24000-1-git-send-email-peter.griffin@linaro.org> (raw)

Once the ST frontend demux HW IP has been enabled, the clock can't
be disabled otherwise the system will hang and the board will
be unserviceable.

To allow balanced clock enable/disable calls in the driver we use
the critical clock infrastructure to take an extra reference on the
clock so the clock will never actually be disabled.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 arch/arm/boot/dts/stih410-clock.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index 8598eff..07c8ef9 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -208,7 +208,8 @@
 						     "clk-clust-hades",
 						     "clk-hwpe-hades",
 						     "clk-fc-hades";
-				clock-critical = <CLK_ICN_CPU>,
+				clock-critical = <CLK_PROC_STFE>,
+						 <CLK_ICN_CPU>,
 						 <CLK_TX_ICN_DMU>,
 						 <CLK_EXT2F_A9>,
 						 <CLK_ICN_LMI>,
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)

From: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
	patrice.chotard-qxv4g6HH51o@public.gmane.org
Cc: peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] ARM: sti: stih410-clocks: Add PROC_STFE as a critical clock
Date: Tue, 18 Oct 2016 16:35:57 +0100	[thread overview]
Message-ID: <1476804957-24000-1-git-send-email-peter.griffin@linaro.org> (raw)

Once the ST frontend demux HW IP has been enabled, the clock can't
be disabled otherwise the system will hang and the board will
be unserviceable.

To allow balanced clock enable/disable calls in the driver we use
the critical clock infrastructure to take an extra reference on the
clock so the clock will never actually be disabled.

Signed-off-by: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 arch/arm/boot/dts/stih410-clock.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index 8598eff..07c8ef9 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -208,7 +208,8 @@
 						     "clk-clust-hades",
 						     "clk-hwpe-hades",
 						     "clk-fc-hades";
-				clock-critical = <CLK_ICN_CPU>,
+				clock-critical = <CLK_PROC_STFE>,
+						 <CLK_ICN_CPU>,
 						 <CLK_TX_ICN_DMU>,
 						 <CLK_EXT2F_A9>,
 						 <CLK_ICN_LMI>,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sti: stih410-clocks: Add PROC_STFE as a critical clock
Date: Tue, 18 Oct 2016 16:35:57 +0100	[thread overview]
Message-ID: <1476804957-24000-1-git-send-email-peter.griffin@linaro.org> (raw)

Once the ST frontend demux HW IP has been enabled, the clock can't
be disabled otherwise the system will hang and the board will
be unserviceable.

To allow balanced clock enable/disable calls in the driver we use
the critical clock infrastructure to take an extra reference on the
clock so the clock will never actually be disabled.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 arch/arm/boot/dts/stih410-clock.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index 8598eff..07c8ef9 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -208,7 +208,8 @@
 						     "clk-clust-hades",
 						     "clk-hwpe-hades",
 						     "clk-fc-hades";
-				clock-critical = <CLK_ICN_CPU>,
+				clock-critical = <CLK_PROC_STFE>,
+						 <CLK_ICN_CPU>,
 						 <CLK_TX_ICN_DMU>,
 						 <CLK_EXT2F_A9>,
 						 <CLK_ICN_LMI>,
-- 
1.9.1

next             reply	other threads:[~2016-10-18 15:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 15:35 Peter Griffin [this message]
2016-10-18 15:35 ` [PATCH] ARM: sti: stih410-clocks: Add PROC_STFE as a critical clock Peter Griffin
2016-10-18 15:35 ` Peter Griffin
2016-10-20 13:50 ` Patrice Chotard
2016-10-20 13:50   ` Patrice Chotard
2016-10-20 13:50   ` Patrice Chotard
2016-10-24  8:53 ` Lee Jones
2016-10-24  8:53   ` Lee Jones
2016-10-24  8:53   ` Lee Jones
2016-10-24 13:44   ` Peter Griffin
2016-10-24 13:44     ` Peter Griffin
2016-10-24 13:44     ` Peter Griffin
2016-10-25  7:42     ` Lee Jones
2016-10-25  7:42       ` Lee Jones
2016-10-25  7:42       ` Lee Jones
2016-10-25  9:39       ` Peter Griffin
2016-10-25  9:39         ` Peter Griffin
2016-10-25 10:01         ` Lee Jones
2016-10-25 10:01           ` Lee Jones
2016-10-25 10:01           ` Lee Jones
2016-10-25 13:49           ` Peter Griffin
2016-10-25 13:49             ` Peter Griffin
2016-10-26  8:51             ` Lee Jones
2016-10-26  8:51               ` Lee Jones
2016-10-26  8:51               ` Lee Jones
2016-10-26  8:56               ` Peter Griffin
2016-10-26  8:56                 ` Peter Griffin
2016-10-26 13:00                 ` Lee Jones
2016-10-26 13:00                   ` Lee Jones

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:8598eff dfblob:8598eff dfblob:8598eff dfblob:07c8ef9
dfblob:07c8ef9 dfblob:07c8ef9
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476804957-24000-1-git-send-email-peter.griffin@linaro.org \
    --to=peter.griffin@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrice.chotard@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.