All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: r8a7779: Fix DU reg property
@ 2016-10-18 22:23 Laurent Pinchart
  2016-10-19  7:09 ` Geert Uytterhoeven
  2016-10-20  8:42 ` Simon Horman
  0 siblings, 2 replies; 5+ messages in thread
From: Laurent Pinchart @ 2016-10-18 22:23 UTC (permalink / raw)
  To: linux-renesas-soc

The system uses one address cell and one size cell, not two. Fix the DU
DT node.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7779.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
index b9bbcce69dfb..9d5b8fa3da8b 100644
--- a/arch/arm/boot/dts/r8a7779.dtsi
+++ b/arch/arm/boot/dts/r8a7779.dtsi
@@ -420,7 +420,7 @@
 
 	du: display@fff80000 {
 		compatible = "renesas,du-r8a7779";
-		reg = <0 0xfff80000 0 0x40000>;
+		reg = <0xfff80000 0x40000>;
 		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&mstp1_clks R8A7779_CLK_DU>;
 		power-domains = <&sysc R8A7779_PD_ALWAYS_ON>;
-- 
Regards,

Laurent Pinchart

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property
  2016-10-18 22:23 [PATCH] ARM: dts: r8a7779: Fix DU reg property Laurent Pinchart
@ 2016-10-19  7:09 ` Geert Uytterhoeven
  2016-10-20  8:42 ` Simon Horman
  1 sibling, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-10-19  7:09 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Linux-Renesas

On Wed, Oct 19, 2016 at 12:23 AM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The system uses one address cell and one size cell, not two. Fix the DU
> DT node.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property
  2016-10-18 22:23 [PATCH] ARM: dts: r8a7779: Fix DU reg property Laurent Pinchart
  2016-10-19  7:09 ` Geert Uytterhoeven
@ 2016-10-20  8:42 ` Simon Horman
  2016-10-20 10:00   ` Laurent Pinchart
  1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2016-10-20  8:42 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linux-renesas-soc

Hi Laurent,

On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote:
> The system uses one address cell and one size cell, not two. Fix the DU
> DT node.

Do you want to handle this as a fix for v4.9? If so shall we add the
following?

Fixes: 1f08bbe8ac73 ("ARM: shmobile: r8a7779: Add DU node to device tree")

Else I'll just queue it up for v4.10.

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm/boot/dts/r8a7779.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
> index b9bbcce69dfb..9d5b8fa3da8b 100644
> --- a/arch/arm/boot/dts/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/r8a7779.dtsi
> @@ -420,7 +420,7 @@
>  
>  	du: display@fff80000 {
>  		compatible = "renesas,du-r8a7779";
> -		reg = <0 0xfff80000 0 0x40000>;
> +		reg = <0xfff80000 0x40000>;
>  		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
>  		clocks = <&mstp1_clks R8A7779_CLK_DU>;
>  		power-domains = <&sysc R8A7779_PD_ALWAYS_ON>;
> -- 
> Regards,
> 
> Laurent Pinchart
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property
  2016-10-20  8:42 ` Simon Horman
@ 2016-10-20 10:00   ` Laurent Pinchart
  2016-10-21  7:16     ` Simon Horman
  0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2016-10-20 10:00 UTC (permalink / raw)
  To: Simon Horman; +Cc: Laurent Pinchart, linux-renesas-soc

Hi Simon,

On Thursday 20 Oct 2016 10:42:30 Simon Horman wrote:
> Hi Laurent,
> 
> On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote:
> > The system uses one address cell and one size cell, not two. Fix the DU
> > DT node.
> 
> Do you want to handle this as a fix for v4.9? If so shall we add the
> following?
> 
> Fixes: 1f08bbe8ac73 ("ARM: shmobile: r8a7779: Add DU node to device tree")
> 
> Else I'll just queue it up for v4.10.

v4.10 is fine, 1f08bbe8ac73 was merged in v3.19, so there's no urgency :-)

It looks like nobody has tried to get display working on Marzen for a very 
long time.

> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7779.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7779.dtsi
> > b/arch/arm/boot/dts/r8a7779.dtsi index b9bbcce69dfb..9d5b8fa3da8b 100644
> > --- a/arch/arm/boot/dts/r8a7779.dtsi
> > +++ b/arch/arm/boot/dts/r8a7779.dtsi
> > @@ -420,7 +420,7 @@
> > 
> >  	du: display@fff80000 {
> >  		compatible = "renesas,du-r8a7779";
> > -		reg = <0 0xfff80000 0 0x40000>;
> > +		reg = <0xfff80000 0x40000>;
> >  		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> >  		clocks = <&mstp1_clks R8A7779_CLK_DU>;
> >  		power-domains = <&sysc R8A7779_PD_ALWAYS_ON>;

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property
  2016-10-20 10:00   ` Laurent Pinchart
@ 2016-10-21  7:16     ` Simon Horman
  0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2016-10-21  7:16 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Laurent Pinchart, linux-renesas-soc

On Thu, Oct 20, 2016 at 01:00:58PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Thursday 20 Oct 2016 10:42:30 Simon Horman wrote:
> > Hi Laurent,
> > 
> > On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote:
> > > The system uses one address cell and one size cell, not two. Fix the DU
> > > DT node.
> > 
> > Do you want to handle this as a fix for v4.9? If so shall we add the
> > following?
> > 
> > Fixes: 1f08bbe8ac73 ("ARM: shmobile: r8a7779: Add DU node to device tree")
> > 
> > Else I'll just queue it up for v4.10.
> 
> v4.10 is fine, 1f08bbe8ac73 was merged in v3.19, so there's no urgency :-)
> 
> It looks like nobody has tried to get display working on Marzen for a very 
> long time.

Thanks, I will queue it up for v4.10.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-21  7:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18 22:23 [PATCH] ARM: dts: r8a7779: Fix DU reg property Laurent Pinchart
2016-10-19  7:09 ` Geert Uytterhoeven
2016-10-20  8:42 ` Simon Horman
2016-10-20 10:00   ` Laurent Pinchart
2016-10-21  7:16     ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.