All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/fm10k: fix SGLORT of VF Tx queues
@ 2016-10-19  1:30 Xiao Wang
  2016-10-19 10:10 ` Bruce Richardson
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Wang @ 2016-10-19  1:30 UTC (permalink / raw)
  To: jing.d.chen; +Cc: dev, Xiao Wang

The SGLORT (Source Global Resource Tag) of the VF queues should be
assigned by PF driver, VF driver should not set these registers.

Fixes: 3b845bf6bcd9 ("fm10k: fix switch manager high CPU usage")

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Reported-by: Sarathx Somasekharan <sarathx.somasekharan@intel.com>
---
 drivers/net/fm10k/fm10k_ethdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index c804436..923690c 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -695,8 +695,9 @@ fm10k_dev_tx_init(struct rte_eth_dev *dev)
 				base_addr >> (CHAR_BIT * sizeof(uint32_t)));
 		FM10K_WRITE_REG(hw, FM10K_TDLEN(i), size);
 
-		/* assign default SGLORT for each TX queue */
-		FM10K_WRITE_REG(hw, FM10K_TX_SGLORT(i), hw->mac.dglort_map);
+		/* assign default SGLORT for each TX queue by PF */
+		if (hw->mac.type == fm10k_mac_pf)
+			FM10K_WRITE_REG(hw, FM10K_TX_SGLORT(i), hw->mac.dglort_map);
 	}
 
 	/* set up vector or scalar TX function as appropriate */
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/fm10k: fix SGLORT of VF Tx queues
  2016-10-19  1:30 [PATCH] net/fm10k: fix SGLORT of VF Tx queues Xiao Wang
@ 2016-10-19 10:10 ` Bruce Richardson
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-10-19 10:10 UTC (permalink / raw)
  To: Xiao Wang; +Cc: jing.d.chen, dev

On Wed, Oct 19, 2016 at 09:30:14AM +0800, Xiao Wang wrote:
> The SGLORT (Source Global Resource Tag) of the VF queues should be
> assigned by PF driver, VF driver should not set these registers.
> 
> Fixes: 3b845bf6bcd9 ("fm10k: fix switch manager high CPU usage")
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> Reported-by: Sarathx Somasekharan <sarathx.somasekharan@intel.com>

Applied to dpdk-next-net/rel_16_11

/Bruce

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-19 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-19  1:30 [PATCH] net/fm10k: fix SGLORT of VF Tx queues Xiao Wang
2016-10-19 10:10 ` Bruce Richardson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.