All of lore.kernel.org
 help / color / mirror / Atom feed
From: christopher.lee.bostic@gmail.com
To: openbmc@lists.ozlabs.org
Cc: joel@jms.id.au, zahrens@us.ibm.com, xxpetri@de.ibm.com,
	Chris Bostic <cbostic@us.ibm.com>
Subject: [PATCH linux v5 16/18] drivers/fsi: Add client driver register utilities
Date: Wed, 19 Oct 2016 18:09:44 -0500	[thread overview]
Message-ID: <1476918586-13475-17-git-send-email-christopher.lee.bostic@gmail.com> (raw)
In-Reply-To: <1476918586-13475-1-git-send-email-christopher.lee.bostic@gmail.com>

From: Chris Bostic <cbostic@us.ibm.com>

Add driver_register and driver_unregister wrappers for FSI.

V4 - Separate out SCOM client driver registration for a follow
     on patch.

V5 - Rename fsidrv_register, fsidrv_unregster to fsi_drv_register,
     fsi_drv_unregister.

   - Add module_fsi_driver() macro for clients that just need
     to do boilerplate registration

Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
---
 drivers/fsi/fsi-core.c | 17 +++++++++++++++++
 include/linux/fsi.h    | 12 ++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index ed0d20f..704c473 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -456,6 +456,23 @@ static int fsi_bus_match(struct device *dev, struct device_driver *drv)
 	return 0;
 }
 
+int fsi_drv_register(struct fsi_driver *fsi_drv)
+{
+	if (!fsi_drv)
+		return -EINVAL;
+	if (!fsi_drv->id_table)
+		return -EINVAL;
+
+	return driver_register(&fsi_drv->drv);
+}
+EXPORT_SYMBOL_GPL(fsi_drv_register);
+
+void fsi_drv_unregister(struct fsi_driver *fsi_drv)
+{
+	driver_unregister(&fsi_drv->drv);
+}
+EXPORT_SYMBOL_GPL(fsi_drv_unregister);
+
 struct bus_type fsi_bus_type = {
 	.name		= "fsi",
 	.match		= fsi_bus_match,
diff --git a/include/linux/fsi.h b/include/linux/fsi.h
index 47af0af..3235dcc 100644
--- a/include/linux/fsi.h
+++ b/include/linux/fsi.h
@@ -55,6 +55,18 @@ struct fsi_driver {
 #define to_fsi_dev(devp) container_of(devp, struct fsi_device, dev)
 #define to_fsi_drv(drvp) container_of(drvp, struct fsi_driver, drv)
 
+extern int fsi_drv_register(struct fsi_driver *);
+extern void fsi_drv_unregister(struct fsi_driver *);
+
+/* module_fsi_driver() - Helper macro for drivers that don't do
+ * anything special in module init/exit.  This eliminates a lot of
+ * boilerplate.   Each module may only use this macro once, and
+ * calling it replaces module_init() and module_exit()
+ */
+#define module_fsi_driver(__fsi_driver) \
+	module_driver(__fsi_driver, fsi_drv_register, \
+			fsi_drv_unregister)
+
 extern struct bus_type fsi_bus_type;
 
 #endif /* LINUX_FSI_H */
-- 
1.8.2.2

  parent reply	other threads:[~2016-10-19 23:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 23:09 [PATCH linux v5 00/18] FSI device driver introduction christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 01/18] fsi: Add empty fsi bus definitions christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 02/18] fsi: Add device & driver definitions christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 03/18] fsi: add driver to device matches christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 04/18] fsi: Add fsi master definition christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 05/18] fsi: Add fake master driver christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 06/18] fsi: enable debug christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 07/18] fsi: Add slave definition christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 08/18] fsi: Add empty master scan christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 09/18] fsi: Add crc4 helpers christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 10/18] fsi: Implement slave initialisation christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 11/18] fsi: scan slaves & register devices christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 12/18] fsi: Add device read/write/peek functions christopher.lee.bostic
2016-10-19 23:09 ` [PATCH linux v5 13/18] drivers/fsi: Set up links for slave communication christopher.lee.bostic
2016-10-19 23:39   ` Jeremy Kerr
2016-10-20  0:10     ` Joel Stanley
2016-10-20 14:16       ` Christopher Bostic
2016-10-21  5:28   ` Jeremy Kerr
2016-10-28 21:07     ` Christopher Bostic
2016-10-19 23:09 ` [PATCH linux v5 14/18] drivers/fsi: Set slave SMODE to init communications christopher.lee.bostic
2016-10-20  0:24   ` Jeremy Kerr
2016-10-19 23:09 ` [PATCH linux v5 15/18] drivers/fsi: Add GPIO FSI master christopher.lee.bostic
2016-10-20  1:26   ` Jeremy Kerr
2016-10-20 15:02     ` Christopher Bostic
2016-10-21  1:26       ` Jeremy Kerr
2016-10-30 21:29         ` Christopher Bostic
2016-10-31  0:59           ` Jeremy Kerr
2016-10-19 23:09 ` christopher.lee.bostic [this message]
2016-10-20  1:29   ` [PATCH linux v5 16/18] drivers/fsi: Add client driver register utilities Jeremy Kerr
2016-10-20 15:07     ` Christopher Bostic
2016-10-19 23:09 ` [PATCH linux v5 17/18] drivers/fsi: Add SCOM FSI client device driver christopher.lee.bostic
2016-10-20  3:27   ` Jeremy Kerr
2016-10-20 15:21     ` Christopher Bostic
2016-10-21  5:24       ` Jeremy Kerr
2016-10-28 19:25         ` Christopher Bostic
2016-10-20 20:11     ` Christopher Bostic
2016-10-19 23:09 ` [PATCH linux v5 18/18] Documenation: Add basic FSI text file christopher.lee.bostic
2016-10-20  2:17   ` Jeremy Kerr
2016-10-20 15:11     ` Christopher Bostic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476918586-13475-17-git-send-email-christopher.lee.bostic@gmail.com \
    --to=christopher.lee.bostic@gmail.com \
    --cc=cbostic@us.ibm.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=xxpetri@de.ibm.com \
    --cc=zahrens@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.