All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Debug log MST active links explicitly
@ 2016-10-19  0:18 Dhinakaran Pandiyan
  2016-10-19  7:08 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev2) Patchwork
  2016-10-19  7:47 ` [PATCH] drm/i915/dp: Debug log MST active links explicitly Chris Wilson
  0 siblings, 2 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2016-10-19  0:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: Pandiyan, Dhinakaran

From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>

No functional change. Just printing the number of active links without
stating what the number means is not very useful. So, add relevant text.

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
---
No changes, sending with Jim's R-B

 drivers/gpu/drm/i915/intel_dp_mst.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 3ffbd69..62a69b5 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -86,7 +86,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
 		to_intel_connector(old_conn_state->connector);
 	int ret;
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
 
@@ -106,7 +106,7 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
 	struct intel_connector *connector =
 		to_intel_connector(old_conn_state->connector);
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	/* this can fail */
 	drm_dp_check_act_status(&intel_dp->mst_mgr);
@@ -147,7 +147,7 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
 	connector->encoder = encoder;
 	intel_mst->connector = connector;
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	if (intel_dp->active_mst_links == 0) {
 		intel_ddi_clk_select(&intel_dig_port->base,
@@ -194,7 +194,7 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
 	enum port port = intel_dig_port->port;
 	int ret;
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	if (intel_wait_for_register(dev_priv,
 				    DP_TP_STATUS(port),
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev2)
  2016-10-19  0:18 [PATCH] drm/i915/dp: Debug log MST active links explicitly Dhinakaran Pandiyan
@ 2016-10-19  7:08 ` Patchwork
  2016-10-19  7:47 ` [PATCH] drm/i915/dp: Debug log MST active links explicitly Chris Wilson
  1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-10-19  7:08 UTC (permalink / raw)
  To: Pandiyan, Dhinakaran; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/dp: Debug log MST active links explicitly (rev2)
URL   : https://patchwork.freedesktop.org/series/13627/
State : failure

== Summary ==

Series 13627v2 drm/i915/dp: Debug log MST active links explicitly
https://patchwork.freedesktop.org/api/1.0/series/13627/revisions/2/mbox/

Test drv_module_reload_basic:
                dmesg-warn -> PASS       (fi-skl-6700hq)
Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> DMESG-WARN (fi-skl-6700hq)
Test kms_force_connector_basic:
        Subgroup force-load-detect:
                pass       -> INCOMPLETE (fi-snb-2520m)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-skl-6700hq)
Test vgem_basic:
        Subgroup unload:
                pass       -> SKIP       (fi-bdw-5557u)

fi-bdw-5557u     total:246  pass:230  dwarn:0   dfail:0   fail:0   skip:16 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:76   pass:62   dwarn:0   dfail:0   fail:1   skip:12 
fi-byt-n2820     total:246  pass:209  dwarn:1   dfail:0   fail:1   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:223  dwarn:1   dfail:0   fail:0   skip:22 
fi-ilk-650       total:246  pass:181  dwarn:0   dfail:0   fail:5   skip:60 
fi-ivb-3520m     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-ivb-3770      total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6700hq    total:246  pass:219  dwarn:4   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:221  dwarn:1   dfail:0   fail:0   skip:24 
fi-snb-2520m     total:186  pass:158  dwarn:0   dfail:0   fail:0   skip:27 
fi-snb-2600      total:208  pass:175  dwarn:0   dfail:0   fail:0   skip:32 

Results at /archive/results/CI_IGT_test/Patchwork_2749/

5b633f423e27af3a7f30d303e243f5a2e82917ae drm-intel-nightly: 2016y-10m-18d-13h-24m-11s UTC integration manifest
ffdbefe drm/i915/dp: Debug log MST active links explicitly

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/dp: Debug log MST active links explicitly
  2016-10-19  0:18 [PATCH] drm/i915/dp: Debug log MST active links explicitly Dhinakaran Pandiyan
  2016-10-19  7:08 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev2) Patchwork
@ 2016-10-19  7:47 ` Chris Wilson
  2016-10-20  0:33   ` Pandiyan, Dhinakaran
  1 sibling, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2016-10-19  7:47 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: intel-gfx

On Tue, Oct 18, 2016 at 05:18:48PM -0700, Dhinakaran Pandiyan wrote:
> From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
> 
> No functional change. Just printing the number of active links without
> stating what the number means is not very useful. So, add relevant text.

If you are going to add information, consider also noting which
connector/encoder you are talking about. Even before we get concurrent
handling of multiple channels, this is useful!
-Chris
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
> ---
> No changes, sending with Jim's R-B
> 
>  drivers/gpu/drm/i915/intel_dp_mst.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> index 3ffbd69..62a69b5 100644
> --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> @@ -86,7 +86,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
>  		to_intel_connector(old_conn_state->connector);
>  	int ret;
>  
> -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
>  
>  	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
>  
> @@ -106,7 +106,7 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
>  	struct intel_connector *connector =
>  		to_intel_connector(old_conn_state->connector);
>  
> -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
>  
>  	/* this can fail */
>  	drm_dp_check_act_status(&intel_dp->mst_mgr);
> @@ -147,7 +147,7 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
>  	connector->encoder = encoder;
>  	intel_mst->connector = connector;
>  
> -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
>  
>  	if (intel_dp->active_mst_links == 0) {
>  		intel_ddi_clk_select(&intel_dig_port->base,
> @@ -194,7 +194,7 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
>  	enum port port = intel_dig_port->port;
>  	int ret;
>  
> -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
>  
>  	if (intel_wait_for_register(dev_priv,
>  				    DP_TP_STATUS(port),
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/dp: Debug log MST active links explicitly
  2016-10-19  7:47 ` [PATCH] drm/i915/dp: Debug log MST active links explicitly Chris Wilson
@ 2016-10-20  0:33   ` Pandiyan, Dhinakaran
  0 siblings, 0 replies; 5+ messages in thread
From: Pandiyan, Dhinakaran @ 2016-10-20  0:33 UTC (permalink / raw)
  To: chris; +Cc: intel-gfx

On Wed, 2016-10-19 at 08:47 +0100, Chris Wilson wrote:
> On Tue, Oct 18, 2016 at 05:18:48PM -0700, Dhinakaran Pandiyan wrote:
> > From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
> > 
> > No functional change. Just printing the number of active links without
> > stating what the number means is not very useful. So, add relevant text.
> 
> If you are going to add information, consider also noting which
> connector/encoder you are talking about. Even before we get concurrent
> handling of multiple channels, this is useful!
> -Chris

Yeah, connector and encoder info must be included. But, now I think of
it, printing active links twice while enabling and twice while disabling
is excessive. The value we print in post_disable() is not intuitive too.

-DK 

> > 
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
> > ---
> > No changes, sending with Jim's R-B
> > 
> >  drivers/gpu/drm/i915/intel_dp_mst.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> > index 3ffbd69..62a69b5 100644
> > --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> > @@ -86,7 +86,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
> >  		to_intel_connector(old_conn_state->connector);
> >  	int ret;
> >  
> > -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> > +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
> >  
> >  	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
> >  
> > @@ -106,7 +106,7 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
> >  	struct intel_connector *connector =
> >  		to_intel_connector(old_conn_state->connector);
> >  
> > -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> > +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
> >  
> >  	/* this can fail */
> >  	drm_dp_check_act_status(&intel_dp->mst_mgr);
> > @@ -147,7 +147,7 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
> >  	connector->encoder = encoder;
> >  	intel_mst->connector = connector;
> >  
> > -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> > +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
> >  
> >  	if (intel_dp->active_mst_links == 0) {
> >  		intel_ddi_clk_select(&intel_dig_port->base,
> > @@ -194,7 +194,7 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> >  	enum port port = intel_dig_port->port;
> >  	int ret;
> >  
> > -	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> > +	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
> >  
> >  	if (intel_wait_for_register(dev_priv,
> >  				    DP_TP_STATUS(port),
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm/i915/dp: Debug log MST active links explicitly
@ 2016-10-12  8:06 Dhinakaran Pandiyan
  0 siblings, 0 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2016-10-12  8:06 UTC (permalink / raw)
  To: intel-gfx; +Cc: Dhinakaran Pandiyan

No functional change. Just printing the number of active links without
stating what the number means is not very useful. So, add relevant text.

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 drivers/gpu/drm/i915/intel_dp_mst.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 3ffbd69..62a69b5 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -86,7 +86,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
 		to_intel_connector(old_conn_state->connector);
 	int ret;
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
 
@@ -106,7 +106,7 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
 	struct intel_connector *connector =
 		to_intel_connector(old_conn_state->connector);
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	/* this can fail */
 	drm_dp_check_act_status(&intel_dp->mst_mgr);
@@ -147,7 +147,7 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
 	connector->encoder = encoder;
 	intel_mst->connector = connector;
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	if (intel_dp->active_mst_links == 0) {
 		intel_ddi_clk_select(&intel_dig_port->base,
@@ -194,7 +194,7 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
 	enum port port = intel_dig_port->port;
 	int ret;
 
-	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
+	DRM_DEBUG_KMS("active MST links: %d\n", intel_dp->active_mst_links);
 
 	if (intel_wait_for_register(dev_priv,
 				    DP_TP_STATUS(port),
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-20  0:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-19  0:18 [PATCH] drm/i915/dp: Debug log MST active links explicitly Dhinakaran Pandiyan
2016-10-19  7:08 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev2) Patchwork
2016-10-19  7:47 ` [PATCH] drm/i915/dp: Debug log MST active links explicitly Chris Wilson
2016-10-20  0:33   ` Pandiyan, Dhinakaran
  -- strict thread matches above, loose matches on Subject: below --
2016-10-12  8:06 Dhinakaran Pandiyan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.