All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus()
@ 2016-10-20  6:53 Masahiro Yamada
  0 siblings, 0 replies; only message in thread
From: Masahiro Yamada @ 2016-10-20  6:53 UTC (permalink / raw)
  To: linux-pm
  Cc: Masahiro Yamada, Stephen Boyd, linux-kernel, Nishanth Menon,
	Len Brown, Greg Kroah-Hartman, Rafael J. Wysocki, Pavel Machek,
	Viresh Kumar

These comments are wrong because _of_get_opp_desc_node() returns
an operating-points-v2 node.

Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed
static checker warnings, and reworded the messages at the same time
(but the latter was not mentioned in the git-log).

Restore the correct messages, dropping __func__.  We can grep the
message string, so the function name would not carry much value.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/base/power/opp/of.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c
index 6480137..92e6d53 100644
--- a/drivers/base/power/opp/of.c
+++ b/drivers/base/power/opp/of.c
@@ -562,7 +562,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
 	/* Get OPP descriptor node */
 	np = _of_get_opp_desc_node(cpu_dev);
 	if (!np) {
-		dev_dbg(cpu_dev, "%s: Couldn't find cpu_dev node.\n", __func__);
+		dev_dbg(cpu_dev, "Couldn't find opp node.\n");
 		return -ENOENT;
 	}
 
@@ -587,8 +587,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
 		/* Get OPP descriptor node */
 		tmp_np = _of_get_opp_desc_node(tcpu_dev);
 		if (!tmp_np) {
-			dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n",
-				__func__);
+			dev_err(tcpu_dev, "Couldn't find opp node.\n");
 			ret = -ENOENT;
 			goto put_cpu_node;
 		}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-20  6:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-20  6:53 [PATCH] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus() Masahiro Yamada

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.