All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] glmark2: Enabling c++ 11 features
@ 2016-10-21 11:43 Amarnath Valluri
  0 siblings, 0 replies; 6+ messages in thread
From: Amarnath Valluri @ 2016-10-21 11:43 UTC (permalink / raw)
  To: openembedded-devel

When build with gcc5,  Failed with below errors:
| ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
string&)':
| ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
not name a template type

This change explicitly enables c++11 features, as code using them.

Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
---
 meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
index 396ae70..a2558a7 100644
--- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
+++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
@@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
                   ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
                   drm-gl drm-gles2"
 
+# Enable C++11 features
+CXXFLAGS += "-std=c++11"
+
 PACKAGECONFIG[x11-gl] = ",,virtual/libgl virtual/libx11"
 PACKAGECONFIG[x11-gles2] = ",,virtual/libgles2 virtual/libx11"
 PACKAGECONFIG[drm-gl] = ",,virtual/libgl libdrm"
-- 
2.7.4

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] glmark2: Enabling c++ 11 features
  2016-10-18  6:49   ` Amarnath Valluri
@ 2016-10-19 18:52     ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-10-19 18:52 UTC (permalink / raw)
  To: Amarnath Valluri; +Cc: Patches and discussions about the oe-core layer


[-- Attachment #1.1: Type: text/plain, Size: 2443 bytes --]


> On Oct 17, 2016, at 11:49 PM, Amarnath Valluri <amarnath.valluri@intel.com> wrote:
> 
> 
> 
> On Friday 14 October 2016 05:13 PM, Khem Raj wrote:
>> On Fri, Oct 14, 2016 at 3:21 PM, Amarnath Valluri
>> <amarnath.valluri@intel.com> <mailto:amarnath.valluri@intel.com> wrote:
>>> > The failure was:
>>> > | ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
>>> > string&)':
>>> > | ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
>>> > not name a template type
>>> >
>>> > This change enables c++11 features, as code useing them.
>>> >
>>> > Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com> <mailto:amarnath.valluri@intel.com>
>>> > ---
>>> >  meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
>>> >  1 file changed, 3 insertions(+)
>>> >
>>> > diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>>> > index 396ae70..4cb233b 100644
>>> > --- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>>> > +++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>>> > @@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
>>> >                    ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
>>> >                    drm-gl drm-gles2"
>>> >
>>> > +# Enable C++11 features
>>> > +CXXFLAGS += "--std=c++11"
>> gcc6 now defaults to  -std=gnu++14,so I have couple of  questions here
>> 
>>  Are you pinning it to c++11 because it doesnt compile with c++14 ? or
>> is it because package is explicitly overrding the std option. In latter case
>> perhaps its better to patch the package and also submit it upstream
>> 
> This failure was visible with gcc version 5.4(GCCVERSION=5.%).  With gcc6 It built successfully.
> 

I see, you should mention such things in commit message.

> - Amarnath
> 
> 
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 


[-- Attachment #1.2: Type: text/html, Size: 4762 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] glmark2: Enabling c++ 11 features
  2016-10-14 14:13 ` Khem Raj
@ 2016-10-18  6:49   ` Amarnath Valluri
  2016-10-19 18:52     ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Amarnath Valluri @ 2016-10-18  6:49 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]



On Friday 14 October 2016 05:13 PM, Khem Raj wrote:
> On Fri, Oct 14, 2016 at 3:21 PM, Amarnath Valluri
> <amarnath.valluri@intel.com>  wrote:
>> >The failure was:
>> >| ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
>> >string&)':
>> >| ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
>> >not name a template type
>> >
>> >This change enables c++11 features, as code useing them.
>> >
>> >Signed-off-by: Amarnath Valluri<amarnath.valluri@intel.com>
>> >---
>> >  meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> >diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>> >index 396ae70..4cb233b 100644
>> >--- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>> >+++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>> >@@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
>> >                    ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
>> >                    drm-gl drm-gles2"
>> >
>> >+# Enable C++11 features
>> >+CXXFLAGS += "--std=c++11"
> gcc6 now defaults to  -std=gnu++14,so I have couple of  questions here
>
>   Are you pinning it to c++11 because it doesnt compile with c++14 ? or
> is it because package is explicitly overrding the std option. In latter case
> perhaps its better to patch the package and also submit it upstream
>
This failure was visible with gcc version 5.4(GCCVERSION=5.%).  With 
gcc6 It built successfully.

- Amarnath


---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[-- Attachment #2: Type: text/html, Size: 3786 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] glmark2: Enabling c++ 11 features
  2016-10-14 13:21 Amarnath Valluri
  2016-10-14 14:13 ` Khem Raj
@ 2016-10-14 14:51 ` Burton, Ross
  1 sibling, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2016-10-14 14:51 UTC (permalink / raw)
  To: Amarnath Valluri; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

On 14 October 2016 at 14:21, Amarnath Valluri <amarnath.valluri@intel.com>
wrote:

>  meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
>

This should go to openembedded-devel, not -core.

Ross

[-- Attachment #2: Type: text/html, Size: 696 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] glmark2: Enabling c++ 11 features
  2016-10-14 13:21 Amarnath Valluri
@ 2016-10-14 14:13 ` Khem Raj
  2016-10-18  6:49   ` Amarnath Valluri
  2016-10-14 14:51 ` Burton, Ross
  1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-10-14 14:13 UTC (permalink / raw)
  To: Amarnath Valluri; +Cc: Patches and discussions about the oe-core layer

On Fri, Oct 14, 2016 at 3:21 PM, Amarnath Valluri
<amarnath.valluri@intel.com> wrote:
> The failure was:
> | ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
> string&)':
> | ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
> not name a template type
>
> This change enables c++11 features, as code useing them.
>
> Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
> ---
>  meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
> index 396ae70..4cb233b 100644
> --- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
> +++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
> @@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
>                    ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
>                    drm-gl drm-gles2"
>
> +# Enable C++11 features
> +CXXFLAGS += "--std=c++11"

gcc6 now defaults to  -std=gnu++14,so I have couple of  questions here

 Are you pinning it to c++11 because it doesnt compile with c++14 ? or
is it because package is explicitly overrding the std option. In latter case
perhaps its better to patch the package and also submit it upstream


> +
>  PACKAGECONFIG[x11-gl] = ",,virtual/libgl virtual/libx11"
>  PACKAGECONFIG[x11-gles2] = ",,virtual/libgles2 virtual/libx11"
>  PACKAGECONFIG[drm-gl] = ",,virtual/libgl libdrm"
> --
> 2.7.4
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [meta-oe][PATCH] glmark2: Enabling c++ 11 features
@ 2016-10-14 13:21 Amarnath Valluri
  2016-10-14 14:13 ` Khem Raj
  2016-10-14 14:51 ` Burton, Ross
  0 siblings, 2 replies; 6+ messages in thread
From: Amarnath Valluri @ 2016-10-14 13:21 UTC (permalink / raw)
  To: openembedded-core

The failure was:
| ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
string&)':
| ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
not name a template type

This change enables c++11 features, as code useing them.

Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
---
 meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
index 396ae70..4cb233b 100644
--- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
+++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
@@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
                   ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
                   drm-gl drm-gles2"
 
+# Enable C++11 features
+CXXFLAGS += "--std=c++11"
+
 PACKAGECONFIG[x11-gl] = ",,virtual/libgl virtual/libx11"
 PACKAGECONFIG[x11-gles2] = ",,virtual/libgles2 virtual/libx11"
 PACKAGECONFIG[drm-gl] = ",,virtual/libgl libdrm"
-- 
2.7.4

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-21 11:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-21 11:43 [meta-oe][PATCH] glmark2: Enabling c++ 11 features Amarnath Valluri
  -- strict thread matches above, loose matches on Subject: below --
2016-10-14 13:21 Amarnath Valluri
2016-10-14 14:13 ` Khem Raj
2016-10-18  6:49   ` Amarnath Valluri
2016-10-19 18:52     ` Khem Raj
2016-10-14 14:51 ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.