From: Tvrtko Ursulin <tursulin@ursulin.net> To: Intel-gfx@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: [PATCH 0/5] Avoid pessimistic scatter-gather allocation Date: Fri, 21 Oct 2016 15:11:18 +0100 [thread overview] Message-ID: <1477059083-3500-1-git-send-email-tvrtko.ursulin@linux.intel.com> (raw) From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> We can decrease the i915 kernel memory usage by doing more sg list coallescing and avoiding the pessimistic list allocation. At the moment we got two places in our code, the main shmemfs backed object allocator, and the userptr object allocator, which both can allocate sg list size pessimistically, and in the latter case also do not exploit entry coallescing when it is possible. This results in between one to six megabytes of memory wasted on unused sg list entries under some common workloads: * Logging into KDE there is 1-2 MiB of unused sg entries. * Running the T-Rex benchamrk aroun 3 Mib. * Similarly for Manhattan 5-6 MiB. To remove this wastage this series starts with some cleanups in the sg_alloc_table_from_pages implementation and then adds and exports a new __sg_alloc_table_from_pages function. This then gets used by the i915 driver to achieve the described savings. Tvrtko Ursulin (5): lib/scatterlist: Fix offset type in sg_alloc_table_from_pages lib/scatterlist: Avoid potential scatterlist entry overflow lib/scatterlist: Introduce and export __sg_alloc_table_from_pages drm/i915: Use __sg_alloc_table_from_pages for allocating object backing store drm/i915: Use __sg_alloc_table_from_pages for userptr allocations drivers/gpu/drm/i915/i915_drv.h | 9 +++ drivers/gpu/drm/i915/i915_gem.c | 77 +++++++++++-------------- drivers/gpu/drm/i915/i915_gem_userptr.c | 29 +++------- drivers/media/v4l2-core/videobuf2-dma-contig.c | 4 +- drivers/rapidio/devices/rio_mport_cdev.c | 4 +- include/linux/scatterlist.h | 11 ++-- lib/scatterlist.c | 78 ++++++++++++++++++++------ 7 files changed, 120 insertions(+), 92 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tursulin@ursulin.net> To: Intel-gfx@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 0/5] Avoid pessimistic scatter-gather allocation Date: Fri, 21 Oct 2016 15:11:18 +0100 [thread overview] Message-ID: <1477059083-3500-1-git-send-email-tvrtko.ursulin@linux.intel.com> (raw) From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> We can decrease the i915 kernel memory usage by doing more sg list coallescing and avoiding the pessimistic list allocation. At the moment we got two places in our code, the main shmemfs backed object allocator, and the userptr object allocator, which both can allocate sg list size pessimistically, and in the latter case also do not exploit entry coallescing when it is possible. This results in between one to six megabytes of memory wasted on unused sg list entries under some common workloads: * Logging into KDE there is 1-2 MiB of unused sg entries. * Running the T-Rex benchamrk aroun 3 Mib. * Similarly for Manhattan 5-6 MiB. To remove this wastage this series starts with some cleanups in the sg_alloc_table_from_pages implementation and then adds and exports a new __sg_alloc_table_from_pages function. This then gets used by the i915 driver to achieve the described savings. Tvrtko Ursulin (5): lib/scatterlist: Fix offset type in sg_alloc_table_from_pages lib/scatterlist: Avoid potential scatterlist entry overflow lib/scatterlist: Introduce and export __sg_alloc_table_from_pages drm/i915: Use __sg_alloc_table_from_pages for allocating object backing store drm/i915: Use __sg_alloc_table_from_pages for userptr allocations drivers/gpu/drm/i915/i915_drv.h | 9 +++ drivers/gpu/drm/i915/i915_gem.c | 77 +++++++++++-------------- drivers/gpu/drm/i915/i915_gem_userptr.c | 29 +++------- drivers/media/v4l2-core/videobuf2-dma-contig.c | 4 +- drivers/rapidio/devices/rio_mport_cdev.c | 4 +- include/linux/scatterlist.h | 11 ++-- lib/scatterlist.c | 78 ++++++++++++++++++++------ 7 files changed, 120 insertions(+), 92 deletions(-) -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2016-10-21 14:13 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-21 14:11 Tvrtko Ursulin [this message] 2016-10-21 14:11 ` [PATCH 0/5] Avoid pessimistic scatter-gather allocation Tvrtko Ursulin 2016-10-21 14:11 ` [PATCH 1/5] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages Tvrtko Ursulin 2016-10-21 14:11 ` Tvrtko Ursulin 2016-10-24 7:21 ` Marek Szyprowski 2016-10-21 14:11 ` [PATCH 2/5] lib/scatterlist: Avoid potential scatterlist entry overflow Tvrtko Ursulin 2016-10-21 14:11 ` [PATCH 3/5] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages Tvrtko Ursulin 2016-10-21 14:11 ` [PATCH 4/5] drm/i915: Use __sg_alloc_table_from_pages for allocating object backing store Tvrtko Ursulin 2016-10-21 14:11 ` Tvrtko Ursulin 2016-10-21 14:27 ` Chris Wilson 2016-10-21 14:55 ` [Intel-gfx] " Tvrtko Ursulin 2016-10-21 14:55 ` Tvrtko Ursulin 2016-10-21 14:11 ` [PATCH 5/5] drm/i915: Use __sg_alloc_table_from_pages for userptr allocations Tvrtko Ursulin 2016-10-21 14:11 ` Tvrtko Ursulin 2016-10-21 15:53 ` ✗ Fi.CI.BAT: failure for Avoid pessimistic scatter-gather allocation Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1477059083-3500-1-git-send-email-tvrtko.ursulin@linux.intel.com \ --to=tursulin@ursulin.net \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=chris@chris-wilson.co.uk \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=tvrtko.ursulin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.