[patch net-next] devlink: Prevent port_type_set() callback when it's not needed

[patch net-next] devlink: Prevent port_type_set() callback when it's not needed

[Jiri Pirko]

From: Elad Raz <eladr@mellanox.com>

When a port_type_set() is been called and the new port type set is the same
as the old one, just return success.

Signed-off-by: Elad Raz <eladr@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 net/core/devlink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index 1b50630..d2fd736 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -608,6 +608,8 @@ static int devlink_port_type_set(struct devlink *devlink,
 	if (devlink->ops && devlink->ops->port_type_set) {
 		if (port_type == DEVLINK_PORT_TYPE_NOTSET)
 			return -EINVAL;
+		if (port_type == devlink_port->type)
+			return 0;
 		err = devlink->ops->port_type_set(devlink_port, port_type);
 		if (err)
 			return err;
-- 
2.5.5

Re: [patch net-next] devlink: Prevent port_type_set() callback when it's not needed

[David Miller]

From: Jiri Pirko <jiri@resnulli.us>
Date: Sun, 23 Oct 2016 17:43:05 +0200

> From: Elad Raz <eladr@mellanox.com>
> 
> When a port_type_set() is been called and the new port type set is the same
> as the old one, just return success.
> 
> Signed-off-by: Elad Raz <eladr@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied, thanks.