* [PATCH rdma-core] qede: fix general protection fault may occur on probe
@ 2016-10-25 12:53 Ram Amrani
[not found] ` <1477400039-16925-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Ram Amrani @ 2016-10-25 12:53 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA
Cc: Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA,
Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA,
Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ram Amrani
The recent introduction of qedr driver support in qede causes a
GPF when probing the driver in a server without a RoCE enabled
QLogic NIC. This fix avoids using an uninitialized pointer in such
a case. Caught by the kernel test robot.
Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
---
drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c
index 9867f96..4927271 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
@@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
}
mutex_unlock(&qedr_dev_list_lock);
- DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
- qedr_counter);
+ pr_notice("qedr: discovered and registered %d RoCE funcs\n",
+ qedr_counter);
return 0;
}
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <1477400039-16925-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
@ 2016-10-27 14:05 ` Leon Romanovsky
[not found] ` <20161027140509.GH3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-13 16:42 ` Amrani, Ram
1 sibling, 1 reply; 8+ messages in thread
From: Leon Romanovsky @ 2016-10-27 14:05 UTC (permalink / raw)
To: Ram Amrani
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA,
Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA,
Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
On Tue, Oct 25, 2016 at 03:53:59PM +0300, Ram Amrani wrote:
> The recent introduction of qedr driver support in qede causes a
> GPF when probing the driver in a server without a RoCE enabled
> QLogic NIC. This fix avoids using an uninitialized pointer in such
> a case. Caught by the kernel test robot.
>
> Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Ram,
The rdma-core word in the subject is misleading.
Thanks
>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> index 9867f96..4927271 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
> }
> mutex_unlock(&qedr_dev_list_lock);
>
> - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
> - qedr_counter);
> + pr_notice("qedr: discovered and registered %d RoCE funcs\n",
> + qedr_counter);
>
> return 0;
> }
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <20161027140509.GH3617-2ukJVAZIZ/Y@public.gmane.org>
@ 2016-10-30 9:25 ` Amrani, Ram
[not found] ` <SN1PR07MB22076D8F67AB8C78A9565CB6F8AF0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Amrani, Ram @ 2016-10-30 9:25 UTC (permalink / raw)
To: Leon Romanovsky
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA, Elior, Ariel, Kalderon, Michal,
Mintz, Yuval, linux-rdma-u79uwXL29TY76Z2rM5mHXA
> The rdma-core word in the subject is misleading.
Yeah it is. The location of the code (qede) is somewhat different from the content (qedr).
I don't know how you would have done it, but at least you'll see in a future patch that we've
changed this to be fully qedr.
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <SN1PR07MB22076D8F67AB8C78A9565CB6F8AF0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-10-30 20:50 ` Leon Romanovsky
[not found] ` <20161030205026.GR3617-2ukJVAZIZ/Y@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Leon Romanovsky @ 2016-10-30 20:50 UTC (permalink / raw)
To: Amrani, Ram
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA, Elior, Ariel, Kalderon, Michal,
Mintz, Yuval, linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Sun, Oct 30, 2016 at 09:25:09AM +0000, Amrani, Ram wrote:
> > The rdma-core word in the subject is misleading.
>
> Yeah it is. The location of the code (qede) is somewhat different from the content (qedr).
> I don't know how you would have done it, but at least you'll see in a future patch that we've
> changed this to be fully qedr.
We use "rdma-core" notations for patches intended to consolidated
library, while your patch is for the kernel.
>
> Ram
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <20161030205026.GR3617-2ukJVAZIZ/Y@public.gmane.org>
@ 2016-11-01 13:34 ` Amrani, Ram
[not found] ` <SN1PR07MB2207881FAE3C35859A8EDED5F8A10-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Amrani, Ram @ 2016-11-01 13:34 UTC (permalink / raw)
To: Leon Romanovsky
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA, Elior, Ariel, Kalderon, Michal,
Mintz, Yuval, linux-rdma-u79uwXL29TY76Z2rM5mHXA
> We use "rdma-core" notations for patches intended to consolidated library,
> while your patch is for the kernel.
ACK. My bad. Shall I re-send it?
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <SN1PR07MB2207881FAE3C35859A8EDED5F8A10-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-11-01 14:01 ` Leon Romanovsky
0 siblings, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2016-11-01 14:01 UTC (permalink / raw)
To: Amrani, Ram
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA, Elior, Ariel, Kalderon, Michal,
Mintz, Yuval, linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Tue, Nov 01, 2016 at 01:34:23PM +0000, Amrani, Ram wrote:
> > We use "rdma-core" notations for patches intended to consolidated library,
> > while your patch is for the kernel.
>
> ACK. My bad. Shall I re-send it?
No, there is no need.
The information from [..] is stripped from the actual applied patch.
Thanks
>
> Ram
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <1477400039-16925-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-10-27 14:05 ` Leon Romanovsky
@ 2016-11-13 16:42 ` Amrani, Ram
[not found] ` <SN1PR07MB2207D200A1EF95EBFAAEBCFFF8BD0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
1 sibling, 1 reply; 8+ messages in thread
From: Amrani, Ram @ 2016-11-13 16:42 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA
Cc: Elior, Ariel, Kalderon, Michal, Mintz, Yuval,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
> The recent introduction of qedr driver support in qede causes a GPF when
> probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids
> using an uninitialized pointer in such a case. Caught by the kernel test robot.
>
> Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c
> b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> index 9867f96..4927271 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
> }
> mutex_unlock(&qedr_dev_list_lock);
>
> - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
> - qedr_counter);
> + pr_notice("qedr: discovered and registered %d RoCE funcs\n",
> + qedr_counter);
>
> return 0;
> }
> --
> 1.8.3.1
Hi Doug,
Can you update if this patch taken and if not, when do you expect it will be?
Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH rdma-core] qede: fix general protection fault may occur on probe
[not found] ` <SN1PR07MB2207D200A1EF95EBFAAEBCFFF8BD0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-12-14 16:26 ` Doug Ledford
0 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2016-12-14 16:26 UTC (permalink / raw)
To: Amrani, Ram
Cc: Elior, Ariel, Kalderon, Michal, Mintz, Yuval,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1.1: Type: text/plain, Size: 1472 bytes --]
On 11/13/2016 11:42 AM, Amrani, Ram wrote:
>> The recent introduction of qedr driver support in qede causes a GPF when
>> probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids
>> using an uninitialized pointer in such a case. Caught by the kernel test robot.
>>
>> Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>> ---
>> drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c
>> b/drivers/net/ethernet/qlogic/qede/qede_roce.c
>> index 9867f96..4927271 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
>> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
>> }
>> mutex_unlock(&qedr_dev_list_lock);
>>
>> - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
>> - qedr_counter);
>> + pr_notice("qedr: discovered and registered %d RoCE funcs\n",
>> + qedr_counter);
>>
>> return 0;
>> }
>> --
>> 1.8.3.1
>
>
> Hi Doug,
> Can you update if this patch taken and if not, when do you expect it will be?
This patch no longer applies. But, more importantly, it's a patch to
the ethernet side of the driver and should go through Dave Miller anyway.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-12-14 16:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 12:53 [PATCH rdma-core] qede: fix general protection fault may occur on probe Ram Amrani
[not found] ` <1477400039-16925-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-10-27 14:05 ` Leon Romanovsky
[not found] ` <20161027140509.GH3617-2ukJVAZIZ/Y@public.gmane.org>
2016-10-30 9:25 ` Amrani, Ram
[not found] ` <SN1PR07MB22076D8F67AB8C78A9565CB6F8AF0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-10-30 20:50 ` Leon Romanovsky
[not found] ` <20161030205026.GR3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-01 13:34 ` Amrani, Ram
[not found] ` <SN1PR07MB2207881FAE3C35859A8EDED5F8A10-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-11-01 14:01 ` Leon Romanovsky
2016-11-13 16:42 ` Amrani, Ram
[not found] ` <SN1PR07MB2207D200A1EF95EBFAAEBCFFF8BD0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-12-14 16:26 ` Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.