* [PATCH net-next] switchdev: Remove redundant variable
@ 2016-10-26 9:03 idosch
2016-10-29 18:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: idosch @ 2016-10-26 9:03 UTC (permalink / raw)
To: davem, jiri; +Cc: netdev, mlxsw, Ido Schimmel
From: Ido Schimmel <idosch@mellanox.com>
Instead of storing return value in 'err' and returning, just return
directly.
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
---
net/switchdev/switchdev.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 02beb35..6f145b5 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -624,13 +624,10 @@ EXPORT_SYMBOL_GPL(unregister_switchdev_notifier);
int call_switchdev_notifiers(unsigned long val, struct net_device *dev,
struct switchdev_notifier_info *info)
{
- int err;
-
ASSERT_RTNL();
info->dev = dev;
- err = raw_notifier_call_chain(&switchdev_notif_chain, val, info);
- return err;
+ return raw_notifier_call_chain(&switchdev_notif_chain, val, info);
}
EXPORT_SYMBOL_GPL(call_switchdev_notifiers);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] switchdev: Remove redundant variable
2016-10-26 9:03 [PATCH net-next] switchdev: Remove redundant variable idosch
@ 2016-10-29 18:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-10-29 18:59 UTC (permalink / raw)
To: idosch; +Cc: jiri, netdev, mlxsw, idosch
From: idosch@idosch.org
Date: Wed, 26 Oct 2016 12:03:03 +0300
> From: Ido Schimmel <idosch@mellanox.com>
>
> Instead of storing return value in 'err' and returning, just return
> directly.
>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-29 18:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-26 9:03 [PATCH net-next] switchdev: Remove redundant variable idosch
2016-10-29 18:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.