* [PATCH 0/4] hpsa updates
@ 2016-10-26 22:21 Don Brace
2016-10-26 22:21 ` [PATCH 1/4] hpsa: correct lockup detector pci_disable_device Don Brace
` (3 more replies)
0 siblings, 4 replies; 19+ messages in thread
From: Don Brace @ 2016-10-26 22:21 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
These patches are based on Linus's tree
The changes are:
- do not call pci_disable_device on an already
disabled device.
- add a new lockup condition to lockup handler.
- remove coalescing settings for ioaccel2
- update driver version.
---
Don Brace (4):
hpsa: correct lockup detector pci_disable_device
hpsa: add generate controller NMI on lockup
hpsa: remove coalescing settings for ioaccel2
hpsa: bump driver version
drivers/scsi/hpsa.c | 19 +++++++++++--------
drivers/scsi/hpsa_cmd.h | 1 +
2 files changed, 12 insertions(+), 8 deletions(-)
--
Signature
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/4] hpsa: correct lockup detector pci_disable_device
2016-10-26 22:21 [PATCH 0/4] hpsa updates Don Brace
@ 2016-10-26 22:21 ` Don Brace
2016-10-27 9:01 ` Hannes Reinecke
2016-10-27 15:19 ` Christoph Hellwig
2016-10-26 22:21 ` [PATCH 2/4] hpsa: add generate controller NMI on lockup Don Brace
` (2 subsequent siblings)
3 siblings, 2 replies; 19+ messages in thread
From: Don Brace @ 2016-10-26 22:21 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
need to check if the device is already disabled first
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index d007ec1..798fb20 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -8456,7 +8456,8 @@ static void controller_lockup_detected(struct ctlr_info *h)
spin_unlock_irqrestore(&h->lock, flags);
dev_warn(&h->pdev->dev, "Controller lockup detected: 0x%08x after %d\n",
lockup_detected, h->heartbeat_sample_interval / HZ);
- pci_disable_device(h->pdev);
+ if (pci_is_enabled(h->pdev))
+ pci_disable_device(h->pdev);
fail_all_outstanding_cmds(h);
}
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/4] hpsa: add generate controller NMI on lockup
2016-10-26 22:21 [PATCH 0/4] hpsa updates Don Brace
2016-10-26 22:21 ` [PATCH 1/4] hpsa: correct lockup detector pci_disable_device Don Brace
@ 2016-10-26 22:21 ` Don Brace
2016-10-27 9:02 ` Hannes Reinecke
2016-10-26 22:21 ` [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2 Don Brace
2016-10-26 22:22 ` [PATCH 4/4] hpsa: bump driver version Don Brace
3 siblings, 1 reply; 19+ messages in thread
From: Don Brace @ 2016-10-26 22:21 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
Tell the controller to NMI when the controller deadlocks.
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 6 ++++++
drivers/scsi/hpsa_cmd.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 798fb20..9fb739c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -8451,6 +8451,12 @@ static void controller_lockup_detected(struct ctlr_info *h)
"lockup detected after %d but scratchpad register is zero\n",
h->heartbeat_sample_interval / HZ);
lockup_detected = 0xffffffff;
+ } else if (lockup_detected == 0xffff0000) {
+ /*
+ * Ring controller NMI doorbell
+ */
+ dev_warn(&h->pdev->dev, "Telling controller to do an NMI\n");
+ writel(DOORBELL_GENERATE_NMI, h->vaddr + SA5_DOORBELL);
}
set_lockup_detected_for_all_cpus(h, lockup_detected);
spin_unlock_irqrestore(&h->lock, flags);
diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
index a584cdf..d186f80 100644
--- a/drivers/scsi/hpsa_cmd.h
+++ b/drivers/scsi/hpsa_cmd.h
@@ -142,6 +142,7 @@
#define DOORBELL_CTLR_RESET 0x00000004l
#define DOORBELL_CTLR_RESET2 0x00000020l
#define DOORBELL_CLEAR_EVENTS 0x00000040l
+#define DOORBELL_GENERATE_NMI 0x00000080l
#define CFGTBL_Trans_Simple 0x00000002l
#define CFGTBL_Trans_Performant 0x00000004l
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2
2016-10-26 22:21 [PATCH 0/4] hpsa updates Don Brace
2016-10-26 22:21 ` [PATCH 1/4] hpsa: correct lockup detector pci_disable_device Don Brace
2016-10-26 22:21 ` [PATCH 2/4] hpsa: add generate controller NMI on lockup Don Brace
@ 2016-10-26 22:21 ` Don Brace
2016-10-27 9:03 ` Hannes Reinecke
2016-10-26 22:22 ` [PATCH 4/4] hpsa: bump driver version Don Brace
3 siblings, 1 reply; 19+ messages in thread
From: Don Brace @ 2016-10-26 22:21 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
- Setting coalescing has a significant negative
impact on low queue-depth performance.
- Does not help high queue-depth performance.
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9fb739c..810c300 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9277,13 +9277,9 @@ static int hpsa_enter_performant_mode(struct ctlr_info *h, u32 trans_support)
access = SA5_ioaccel_mode1_access;
writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
writel(4, &h->cfgtable->HostWrite.CoalIntCount);
- } else {
- if (trans_support & CFGTBL_Trans_io_accel2) {
+ } else
+ if (trans_support & CFGTBL_Trans_io_accel2)
access = SA5_ioaccel_mode2_access;
- writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
- writel(4, &h->cfgtable->HostWrite.CoalIntCount);
- }
- }
writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
if (hpsa_wait_for_mode_change_ack(h)) {
dev_err(&h->pdev->dev,
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 4/4] hpsa: bump driver version
2016-10-26 22:21 [PATCH 0/4] hpsa updates Don Brace
` (2 preceding siblings ...)
2016-10-26 22:21 ` [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2 Don Brace
@ 2016-10-26 22:22 ` Don Brace
2016-10-27 9:03 ` Hannes Reinecke
3 siblings, 1 reply; 19+ messages in thread
From: Don Brace @ 2016-10-26 22:22 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 810c300..0b6eb5a 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -60,7 +60,7 @@
* HPSA_DRIVER_VERSION must be 3 byte values (0-255) separated by '.'
* with an optional trailing '-' followed by a byte value (0-255).
*/
-#define HPSA_DRIVER_VERSION "3.4.16-0"
+#define HPSA_DRIVER_VERSION "3.4.16-145"
#define DRIVER_NAME "HP HPSA Driver (v " HPSA_DRIVER_VERSION ")"
#define HPSA "hpsa"
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device
2016-10-26 22:21 ` [PATCH 1/4] hpsa: correct lockup detector pci_disable_device Don Brace
@ 2016-10-27 9:01 ` Hannes Reinecke
2016-10-27 9:25 ` Johannes Thumshirn
2016-10-27 15:19 ` Christoph Hellwig
1 sibling, 1 reply; 19+ messages in thread
From: Hannes Reinecke @ 2016-10-27 9:01 UTC (permalink / raw)
To: Don Brace, jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
hch, scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
On 10/27/2016 12:21 AM, Don Brace wrote:
> need to check if the device is already disabled first
>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
> drivers/scsi/hpsa.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index d007ec1..798fb20 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -8456,7 +8456,8 @@ static void controller_lockup_detected(struct ctlr_info *h)
> spin_unlock_irqrestore(&h->lock, flags);
> dev_warn(&h->pdev->dev, "Controller lockup detected: 0x%08x after %d\n",
> lockup_detected, h->heartbeat_sample_interval / HZ);
> - pci_disable_device(h->pdev);
> + if (pci_is_enabled(h->pdev))
> + pci_disable_device(h->pdev);
> fail_all_outstanding_cmds(h);
> }
>
>
Meh.
Why is pci_disable_device() not checking for it?
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/4] hpsa: add generate controller NMI on lockup
2016-10-26 22:21 ` [PATCH 2/4] hpsa: add generate controller NMI on lockup Don Brace
@ 2016-10-27 9:02 ` Hannes Reinecke
2016-10-31 15:26 ` Don Brace
2016-11-11 16:09 ` Don Brace
0 siblings, 2 replies; 19+ messages in thread
From: Hannes Reinecke @ 2016-10-27 9:02 UTC (permalink / raw)
To: Don Brace, jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
hch, scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
On 10/27/2016 12:21 AM, Don Brace wrote:
> Tell the controller to NMI when the controller deadlocks.
>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
> drivers/scsi/hpsa.c | 6 ++++++
> drivers/scsi/hpsa_cmd.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 798fb20..9fb739c 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -8451,6 +8451,12 @@ static void controller_lockup_detected(struct ctlr_info *h)
> "lockup detected after %d but scratchpad register is zero\n",
> h->heartbeat_sample_interval / HZ);
> lockup_detected = 0xffffffff;
> + } else if (lockup_detected == 0xffff0000) {
> + /*
> + * Ring controller NMI doorbell
> + */
> + dev_warn(&h->pdev->dev, "Telling controller to do an NMI\n");
> + writel(DOORBELL_GENERATE_NMI, h->vaddr + SA5_DOORBELL);
> }
> set_lockup_detected_for_all_cpus(h, lockup_detected);
> spin_unlock_irqrestore(&h->lock, flags);
> diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
> index a584cdf..d186f80 100644
> --- a/drivers/scsi/hpsa_cmd.h
> +++ b/drivers/scsi/hpsa_cmd.h
> @@ -142,6 +142,7 @@
> #define DOORBELL_CTLR_RESET 0x00000004l
> #define DOORBELL_CTLR_RESET2 0x00000020l
> #define DOORBELL_CLEAR_EVENTS 0x00000040l
> +#define DOORBELL_GENERATE_NMI 0x00000080l
>
> #define CFGTBL_Trans_Simple 0x00000002l
> #define CFGTBL_Trans_Performant 0x00000004l
>
Care to elaborate a bit more here?
'Generating NMI' tends to ring some alarm bells, so I'd rather know
where the NMI is actually generated, and if is could reflect back to the
system ...
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2
2016-10-26 22:21 ` [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2 Don Brace
@ 2016-10-27 9:03 ` Hannes Reinecke
2017-01-13 14:58 ` Don Brace
0 siblings, 1 reply; 19+ messages in thread
From: Hannes Reinecke @ 2016-10-27 9:03 UTC (permalink / raw)
To: Don Brace, jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
hch, scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
On 10/27/2016 12:21 AM, Don Brace wrote:
> - Setting coalescing has a significant negative
> impact on low queue-depth performance.
> - Does not help high queue-depth performance.
>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
> drivers/scsi/hpsa.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 9fb739c..810c300 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -9277,13 +9277,9 @@ static int hpsa_enter_performant_mode(struct ctlr_info *h, u32 trans_support)
> access = SA5_ioaccel_mode1_access;
> writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
> writel(4, &h->cfgtable->HostWrite.CoalIntCount);
> - } else {
> - if (trans_support & CFGTBL_Trans_io_accel2) {
> + } else
> + if (trans_support & CFGTBL_Trans_io_accel2)
> access = SA5_ioaccel_mode2_access;
> - writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
> - writel(4, &h->cfgtable->HostWrite.CoalIntCount);
> - }
> - }
> writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
> if (hpsa_wait_for_mode_change_ack(h)) {
> dev_err(&h->pdev->dev,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/4] hpsa: bump driver version
2016-10-26 22:22 ` [PATCH 4/4] hpsa: bump driver version Don Brace
@ 2016-10-27 9:03 ` Hannes Reinecke
0 siblings, 0 replies; 19+ messages in thread
From: Hannes Reinecke @ 2016-10-27 9:03 UTC (permalink / raw)
To: Don Brace, jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
hch, scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD
Cc: linux-scsi
On 10/27/2016 12:22 AM, Don Brace wrote:
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
> ---
> drivers/scsi/hpsa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 810c300..0b6eb5a 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -60,7 +60,7 @@
> * HPSA_DRIVER_VERSION must be 3 byte values (0-255) separated by '.'
> * with an optional trailing '-' followed by a byte value (0-255).
> */
> -#define HPSA_DRIVER_VERSION "3.4.16-0"
> +#define HPSA_DRIVER_VERSION "3.4.16-145"
> #define DRIVER_NAME "HP HPSA Driver (v " HPSA_DRIVER_VERSION ")"
> #define HPSA "hpsa"
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device
2016-10-27 9:01 ` Hannes Reinecke
@ 2016-10-27 9:25 ` Johannes Thumshirn
0 siblings, 0 replies; 19+ messages in thread
From: Johannes Thumshirn @ 2016-10-27 9:25 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Don Brace, jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
hch, scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD, linux-scsi
On Thu, Oct 27, 2016 at 11:01:41AM +0200, Hannes Reinecke wrote:
> On 10/27/2016 12:21 AM, Don Brace wrote:
> > need to check if the device is already disabled first
> >
> > Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> > Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> > Signed-off-by: Don Brace <don.brace@microsemi.com>
> > ---
> > drivers/scsi/hpsa.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index d007ec1..798fb20 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -8456,7 +8456,8 @@ static void controller_lockup_detected(struct ctlr_info *h)
> > spin_unlock_irqrestore(&h->lock, flags);
> > dev_warn(&h->pdev->dev, "Controller lockup detected: 0x%08x after %d\n",
> > lockup_detected, h->heartbeat_sample_interval / HZ);
> > - pci_disable_device(h->pdev);
> > + if (pci_is_enabled(h->pdev))
> > + pci_disable_device(h->pdev);
> > fail_all_outstanding_cmds(h);
> > }
> >
> >
> Meh.
> Why is pci_disable_device() not checking for it?
It does:
1607 void pci_disable_device(struct pci_dev *dev)
1608 {
[...]
1615 dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0,
1616 "disabling already-disabled device");
[...]
1624 }
1625 EXPORT_SYMBOL(pci_disable_device);
Which is the motivation behind this patch I think.
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device
2016-10-26 22:21 ` [PATCH 1/4] hpsa: correct lockup detector pci_disable_device Don Brace
2016-10-27 9:01 ` Hannes Reinecke
@ 2016-10-27 15:19 ` Christoph Hellwig
2016-10-31 15:20 ` Don Brace
1 sibling, 1 reply; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-27 15:19 UTC (permalink / raw)
To: Don Brace
Cc: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
POSWALD, linux-scsi
> - pci_disable_device(h->pdev);
> + if (pci_is_enabled(h->pdev))
> + pci_disable_device(h->pdev);
> fail_all_outstanding_cmds(h);
Humm. How can this even happen when the device isn't enabled?
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device
2016-10-27 15:19 ` Christoph Hellwig
@ 2016-10-31 15:20 ` Don Brace
0 siblings, 0 replies; 19+ messages in thread
From: Don Brace @ 2016-10-31 15:20 UTC (permalink / raw)
To: Christoph Hellwig
Cc: jejb, John Hall, Kevin Barnett, Mahesh Rajashekhara, Scott Teel,
Viswas G, Justin Lindley, Scott Benesh, elliott, POSWALD,
linux-scsi
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Thursday, October 27, 2016 10:19 AM
> To: Don Brace
> Cc: jejb@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> Rajashekhara; hch@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott
> Benesh; elliott@hpe.com; POSWALD@suse.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device
>
> EXTERNAL EMAIL
>
>
> > - pci_disable_device(h->pdev);
> > + if (pci_is_enabled(h->pdev))
> > + pci_disable_device(h->pdev);
> > fail_all_outstanding_cmds(h);
>
> Humm. How can this even happen when the device isn't enabled?
controller_lockup_detected can be called multiple times, especially when I am
exercising the reset handler and abort handler, so I wanted to avoid the kernel
warning messages.
fail_all_outstanding_commands is called with status CMD_CTLR_LOCKUP
and complete_scsi_command returns DID_NO_CONNECT.
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup
2016-10-27 9:02 ` Hannes Reinecke
@ 2016-10-31 15:26 ` Don Brace
2016-11-11 16:09 ` Don Brace
1 sibling, 0 replies; 19+ messages in thread
From: Don Brace @ 2016-10-31 15:26 UTC (permalink / raw)
To: Hannes Reinecke, jejb, John Hall, Kevin Barnett,
Mahesh Rajashekhara, hch, Scott Teel, Viswas G, Justin Lindley,
Scott Benesh, elliott, POSWALD
Cc: linux-scsi
> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
> Sent: Thursday, October 27, 2016 4:03 AM
> To: Don Brace; jejb@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> Rajashekhara; hch@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott
> Benesh; elliott@hpe.com; POSWALD@suse.com
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 2/4] hpsa: add generate controller NMI on lockup
>
> EXTERNAL EMAIL
>
>
> On 10/27/2016 12:21 AM, Don Brace wrote:
> > Tell the controller to NMI when the controller deadlocks.
> >
> > Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> > Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> > Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> > Signed-off-by: Don Brace <don.brace@microsemi.com>
> > ---
> > drivers/scsi/hpsa.c | 6 ++++++
> > drivers/scsi/hpsa_cmd.h | 1 +
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index 798fb20..9fb739c 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -8451,6 +8451,12 @@ static void controller_lockup_detected(struct
> ctlr_info *h)
> > "lockup detected after %d but scratchpad register is zero\n",
> > h->heartbeat_sample_interval / HZ);
> > lockup_detected = 0xffffffff;
> > + } else if (lockup_detected == 0xffff0000) {
> > + /*
> > + * Ring controller NMI doorbell
> > + */
> > + dev_warn(&h->pdev->dev, "Telling controller to do an NMI\n");
> > + writel(DOORBELL_GENERATE_NMI, h->vaddr + SA5_DOORBELL);
> > }
> > set_lockup_detected_for_all_cpus(h, lockup_detected);
> > spin_unlock_irqrestore(&h->lock, flags);
> > diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
> > index a584cdf..d186f80 100644
> > --- a/drivers/scsi/hpsa_cmd.h
> > +++ b/drivers/scsi/hpsa_cmd.h
> > @@ -142,6 +142,7 @@
> > #define DOORBELL_CTLR_RESET 0x00000004l
> > #define DOORBELL_CTLR_RESET2 0x00000020l
> > #define DOORBELL_CLEAR_EVENTS 0x00000040l
> > +#define DOORBELL_GENERATE_NMI 0x00000080l
> >
> > #define CFGTBL_Trans_Simple 0x00000002l
> > #define CFGTBL_Trans_Performant 0x00000004l
> >
> Care to elaborate a bit more here?
> 'Generating NMI' tends to ring some alarm bells, so I'd rather know
> where the NMI is actually generated, and if is could reflect back to the
> system ...
There are some rare cases where we get this lockup code and we
need to tell the controller to do its own NMI. This NMI is only done
on the controller and does not tell the OS to perform an NMI.
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke Teamlead Storage & Networking
> hare@suse.de +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup
2016-10-27 9:02 ` Hannes Reinecke
2016-10-31 15:26 ` Don Brace
@ 2016-11-11 16:09 ` Don Brace
2016-12-06 22:31 ` Don Brace
1 sibling, 1 reply; 19+ messages in thread
From: Don Brace @ 2016-11-11 16:09 UTC (permalink / raw)
To: Hannes Reinecke, jejb, John Hall, Kevin Barnett,
Mahesh Rajashekhara, hch, Scott Teel, Viswas G, Justin Lindley,
Scott Benesh, elliott, POSWALD
Cc: linux-scsi
> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
> Sent: Thursday, October 27, 2016 4:03 AM
> To: Don Brace; jejb@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> Rajashekhara; hch@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott
> Benesh; elliott@hpe.com; POSWALD@suse.com
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 2/4] hpsa: add generate controller NMI on lockup
>
> EXTERNAL EMAIL
>
>
> On 10/27/2016 12:21 AM, Don Brace wrote:
> > Tell the controller to NMI when the controller deadlocks.
> >
> > Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> > Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> > Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> > Signed-off-by: Don Brace <don.brace@microsemi.com>
> > ---
> > drivers/scsi/hpsa.c | 6 ++++++
> > drivers/scsi/hpsa_cmd.h | 1 +
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index 798fb20..9fb739c 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -8451,6 +8451,12 @@ static void controller_lockup_detected(struct
> ctlr_info *h)
> > "lockup detected after %d but scratchpad register is zero\n",
> > h->heartbeat_sample_interval / HZ);
> > lockup_detected = 0xffffffff;
> > + } else if (lockup_detected == 0xffff0000) {
> > + /*
> > + * Ring controller NMI doorbell
> > + */
> > + dev_warn(&h->pdev->dev, "Telling controller to do an NMI\n");
> > + writel(DOORBELL_GENERATE_NMI, h->vaddr + SA5_DOORBELL);
> > }
> > set_lockup_detected_for_all_cpus(h, lockup_detected);
> > spin_unlock_irqrestore(&h->lock, flags);
> > diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
> > index a584cdf..d186f80 100644
> > --- a/drivers/scsi/hpsa_cmd.h
> > +++ b/drivers/scsi/hpsa_cmd.h
> > @@ -142,6 +142,7 @@
> > #define DOORBELL_CTLR_RESET 0x00000004l
> > #define DOORBELL_CTLR_RESET2 0x00000020l
> > #define DOORBELL_CLEAR_EVENTS 0x00000040l
> > +#define DOORBELL_GENERATE_NMI 0x00000080l
> >
> > #define CFGTBL_Trans_Simple 0x00000002l
> > #define CFGTBL_Trans_Performant 0x00000004l
> >
> Care to elaborate a bit more here?
> 'Generating NMI' tends to ring some alarm bells, so I'd rather know
> where the NMI is actually generated, and if is could reflect back to the
> system ...
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke Teamlead Storage & Networking
> hare@suse.de +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)
There are some rare cases where we get this lockup code and we
need to tell the controller to do its own NMI. This NMI is only done
on the controller and does not tell the OS to perform an NMI.
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup
2016-11-11 16:09 ` Don Brace
@ 2016-12-06 22:31 ` Don Brace
0 siblings, 0 replies; 19+ messages in thread
From: Don Brace @ 2016-12-06 22:31 UTC (permalink / raw)
To: Don Brace, Hannes Reinecke, jejb, John Hall, Kevin Barnett,
Mahesh Rajashekhara, hch, Scott Teel, Viswas G, Justin Lindley,
Scott Benesh, elliott, POSWALD
Cc: linux-scsi
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of Don Brace
> Sent: Friday, November 11, 2016 10:09 AM
> To: Hannes Reinecke; jejb@linux.vnet.ibm.com; John Hall; Kevin Barnett;
> Mahesh Rajashekhara; hch@infradead.org; Scott Teel; Viswas G; Justin
> Lindley; Scott Benesh; elliott@hpe.com; POSWALD@suse.com
> Cc: linux-scsi@vger.kernel.org
> Subject: RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup
>
> EXTERNAL EMAIL
>
>
> > -----Original Message-----
> > From: Hannes Reinecke [mailto:hare@suse.de]
> > Sent: Thursday, October 27, 2016 4:03 AM
> > To: Don Brace; jejb@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> > Rajashekhara; hch@infradead.org; Scott Teel; Viswas G; Justin Lindley;
> Scott
> > Benesh; elliott@hpe.com; POSWALD@suse.com
> > Cc: linux-scsi@vger.kernel.org
> > Subject: Re: [PATCH 2/4] hpsa: add generate controller NMI on lockup
> >
> > EXTERNAL EMAIL
> >
> >
> > On 10/27/2016 12:21 AM, Don Brace wrote:
> > > Tell the controller to NMI when the controller deadlocks.
> > >
> > > Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> > > Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> > > Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> > > Signed-off-by: Don Brace <don.brace@microsemi.com>
> > > ---
> > > drivers/scsi/hpsa.c | 6 ++++++
> > > drivers/scsi/hpsa_cmd.h | 1 +
> > > 2 files changed, 7 insertions(+)
> > >
> > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > > index 798fb20..9fb739c 100644
> > > --- a/drivers/scsi/hpsa.c
> > > +++ b/drivers/scsi/hpsa.c
> > > @@ -8451,6 +8451,12 @@ static void controller_lockup_detected(struct
> > ctlr_info *h)
> > > "lockup detected after %d but scratchpad register is zero\n",
> > > h->heartbeat_sample_interval / HZ);
> > > lockup_detected = 0xffffffff;
> > > + } else if (lockup_detected == 0xffff0000) {
> > > + /*
> > > + * Ring controller NMI doorbell
> > > + */
> > > + dev_warn(&h->pdev->dev, "Telling controller to do an NMI\n");
> > > + writel(DOORBELL_GENERATE_NMI, h->vaddr + SA5_DOORBELL);
> > > }
> > > set_lockup_detected_for_all_cpus(h, lockup_detected);
> > > spin_unlock_irqrestore(&h->lock, flags);
> > > diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
> > > index a584cdf..d186f80 100644
> > > --- a/drivers/scsi/hpsa_cmd.h
> > > +++ b/drivers/scsi/hpsa_cmd.h
> > > @@ -142,6 +142,7 @@
> > > #define DOORBELL_CTLR_RESET 0x00000004l
> > > #define DOORBELL_CTLR_RESET2 0x00000020l
> > > #define DOORBELL_CLEAR_EVENTS 0x00000040l
> > > +#define DOORBELL_GENERATE_NMI 0x00000080l
> > >
> > > #define CFGTBL_Trans_Simple 0x00000002l
> > > #define CFGTBL_Trans_Performant 0x00000004l
> > >
> > Care to elaborate a bit more here?
> > 'Generating NMI' tends to ring some alarm bells, so I'd rather know
> > where the NMI is actually generated, and if is could reflect back to the
> > system ...
> >
> > Cheers,
> >
> > Hannes
> > --
> > Dr. Hannes Reinecke Teamlead Storage & Networking
> > hare@suse.de +49 911 74053 688
> > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> > HRB 21284 (AG Nürnberg)
>
>
> There are some rare cases where we get this lockup code and we
> need to tell the controller to do its own NMI. This NMI is only done
> on the controller and does not tell the OS to perform an NMI.
>
> Thanks,
> Don Brace
Wondering what has happened to this patch?
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2
2016-10-27 9:03 ` Hannes Reinecke
@ 2017-01-13 14:58 ` Don Brace
2017-01-16 20:50 ` Martin K. Petersen
0 siblings, 1 reply; 19+ messages in thread
From: Don Brace @ 2017-01-13 14:58 UTC (permalink / raw)
To: Hannes Reinecke, jejb, John Hall, Kevin Barnett,
Mahesh Rajashekhara, hch, Scott Teel, Viswas G, Justin Lindley,
Scott Benesh, elliott, POSWALD
Cc: linux-scsi
> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
> Sent: Thursday, October 27, 2016 4:04 AM
> To: Don Brace <don.brace@microsemi.com>; jejb@linux.vnet.ibm.com; John
> Hall <John.Hall@microsemi.com>; Kevin Barnett
> <kevin.barnett@microsemi.com>; Mahesh Rajashekhara
> <mahesh.rajashekhara@microsemi.com>; hch@infradead.org; Scott Teel
> <scott.teel@microsemi.com>; Viswas G <viswas.g@microsemi.com>; Justin
> Lindley <justin.lindley@microsemi.com>; Scott Benesh
> <scott.benesh@microsemi.com>; elliott@hpe.com; POSWALD@suse.com
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2
>
> EXTERNAL EMAIL
>
>
> On 10/27/2016 12:21 AM, Don Brace wrote:
> > - Setting coalescing has a significant negative
> > impact on low queue-depth performance.
> > - Does not help high queue-depth performance.
> >
> > Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> > Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> > Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> > Signed-off-by: Don Brace <don.brace@microsemi.com>
> > ---
> > drivers/scsi/hpsa.c | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index 9fb739c..810c300 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -9277,13 +9277,9 @@ static int hpsa_enter_performant_mode(struct
> ctlr_info *h, u32 trans_support)
> > access = SA5_ioaccel_mode1_access;
> > writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
> > writel(4, &h->cfgtable->HostWrite.CoalIntCount);
> > - } else {
> > - if (trans_support & CFGTBL_Trans_io_accel2) {
> > + } else
> > + if (trans_support & CFGTBL_Trans_io_accel2)
> > access = SA5_ioaccel_mode2_access;
> > - writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
> > - writel(4, &h->cfgtable->HostWrite.CoalIntCount);
> > - }
> > - }
> > writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
> > if (hpsa_wait_for_mode_change_ack(h)) {
> > dev_err(&h->pdev->dev,
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> Reviewed-by: Hannes Reinecke <hare@suse.com>
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke Teamlead Storage & Networking
> hare@suse.de +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)
Wondering what has happened to this patch?
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2
2017-01-13 14:58 ` Don Brace
@ 2017-01-16 20:50 ` Martin K. Petersen
0 siblings, 0 replies; 19+ messages in thread
From: Martin K. Petersen @ 2017-01-16 20:50 UTC (permalink / raw)
To: Don Brace
Cc: Hannes Reinecke, jejb, John Hall, Kevin Barnett,
Mahesh Rajashekhara, hch, Scott Teel, Viswas G, Justin Lindley,
Scott Benesh, elliott, POSWALD, linux-scsi
>>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:
Don,
Don> Wondering what has happened to this patch?
According to my notes, there were some concerns with the series that did
not get addressed. And only patch 3 actually got a reviewed-by tag. I
suggest you repost the series.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] hpsa updates
2020-07-20 21:52 [PATCH 0/4] hpsa updates Don Brace
@ 2020-07-21 3:51 ` Martin K. Petersen
0 siblings, 0 replies; 19+ messages in thread
From: Martin K. Petersen @ 2020-07-21 3:51 UTC (permalink / raw)
To: scott.teel, gerry.morong, POSWALD, Justin.Lindley, scott.benesh,
bader.alisaleh, Kevin.Barnett, jejb, joseph.szczypek, Don Brace,
hch, mahesh.rajashekhara
Cc: Martin K . Petersen, linux-scsi
On Mon, 20 Jul 2020 16:52:46 -0500, Don Brace wrote:
> These patches are based on Linus's tree
>
> The changes are:
> hpsa-correct-rare-oob-condition
> - Rare condition where a spare is first in
> PHYS LUN list.
> hpsa-increase-qd-for-external-luns
> - Improve performance for PTRAID devices
> - Such as MSA devices.
> hpsa-increase-ctlr-eh-timeout
> - Increase timeout for commands issued to
> controller device.
> - Improve multipath failover handling.
> hpsa-bump-version
Applied to 5.9/scsi-queue, thanks!
[1/4] scsi: hpsa: Correct rare oob condition
https://git.kernel.org/mkp/scsi/c/a1cc279c246a
[2/4] scsi: hpsa: Increase queue depth for external LUNs
https://git.kernel.org/mkp/scsi/c/3fcb972bc1d7
[3/4] scsi: hpsa: Increase controller error handling timeout
https://git.kernel.org/mkp/scsi/c/c73deaf3b001
[4/4] scsi: hpsa: Bump version
https://git.kernel.org/mkp/scsi/c/afea24189508
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] hpsa updates
@ 2020-07-20 21:52 Don Brace
2020-07-21 3:51 ` Martin K. Petersen
0 siblings, 1 reply; 19+ messages in thread
From: Don Brace @ 2020-07-20 21:52 UTC (permalink / raw)
To: Kevin.Barnett, scott.teel, Justin.Lindley, scott.benesh,
bader.alisaleh, gerry.morong, mahesh.rajashekhara, hch, jejb,
joseph.szczypek, POSWALD
Cc: linux-scsi
These patches are based on Linus's tree
The changes are:
hpsa-correct-rare-oob-condition
- Rare condition where a spare is first in
PHYS LUN list.
hpsa-increase-qd-for-external-luns
- Improve performance for PTRAID devices
- Such as MSA devices.
hpsa-increase-ctlr-eh-timeout
- Increase timeout for commands issued to
controller device.
- Improve multipath failover handling.
hpsa-bump-version
---
Don Brace (4):
hpsa: correct rare oob condition
hpsa: increase qd for external luns
hpsa: increase ctlr eh timeout
hpsa: bump version
drivers/scsi/hpsa.c | 6 +++++-
drivers/scsi/hpsa.h | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
--
Signature
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-07-21 3:53 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-26 22:21 [PATCH 0/4] hpsa updates Don Brace
2016-10-26 22:21 ` [PATCH 1/4] hpsa: correct lockup detector pci_disable_device Don Brace
2016-10-27 9:01 ` Hannes Reinecke
2016-10-27 9:25 ` Johannes Thumshirn
2016-10-27 15:19 ` Christoph Hellwig
2016-10-31 15:20 ` Don Brace
2016-10-26 22:21 ` [PATCH 2/4] hpsa: add generate controller NMI on lockup Don Brace
2016-10-27 9:02 ` Hannes Reinecke
2016-10-31 15:26 ` Don Brace
2016-11-11 16:09 ` Don Brace
2016-12-06 22:31 ` Don Brace
2016-10-26 22:21 ` [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2 Don Brace
2016-10-27 9:03 ` Hannes Reinecke
2017-01-13 14:58 ` Don Brace
2017-01-16 20:50 ` Martin K. Petersen
2016-10-26 22:22 ` [PATCH 4/4] hpsa: bump driver version Don Brace
2016-10-27 9:03 ` Hannes Reinecke
2020-07-20 21:52 [PATCH 0/4] hpsa updates Don Brace
2020-07-21 3:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.