From: David Lechner <david@lechnology.com> To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org> Cc: Axel Haslam <ahaslam@baylibre.com>, David Lechner <david@lechnology.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 4/4] ARM: davinci: da8xx: register USB PHY clocks in the DT file Date: Wed, 26 Oct 2016 19:18:18 -0500 [thread overview] Message-ID: <1477527498-21930-5-git-send-email-david@lechnology.com> (raw) In-Reply-To: <1477527498-21930-1-git-send-email-david@lechnology.com> From: Axel Haslam <ahaslam@baylibre.com> The usb20_phy clock needs to be registered for the driver to be able to get and enable a clock. Currently the usb phy clocks are registered form board files, which will not be called during a device tree based boot. To be able to probe correctly usb form a device tree boot, register the usb phy clocks form the DT specific init. Unfortunately, davinci does not have proper clock support on device tree yet, so by registering the clock form de DT specific file we are forced to hardcode the parent clock, and cannot select refclkin as parent for any of the phy clocks of the da850 family. As none of the current da850 based boards currently in mainline use refclkin as source. I guess we can live with this limitation until clocks are correctly represented through CCF/device tree. Signed-off-by: Axel Haslam <ahaslam@baylibre.com> [Added error checking] Signed-off-by: David Lechner <david@lechnology.com> --- This patch was recently submitted separately. I added error checking and I am including it in this series since it is closely related. It could be combined with the "ARM: davinci: da8xx: add usb phy clocks" patch, but I think it is good to have a separate commit for the explanation in the commit message. arch/arm/mach-davinci/da8xx-dt.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c index 75e831d..839f8db 100644 --- a/arch/arm/mach-davinci/da8xx-dt.c +++ b/arch/arm/mach-davinci/da8xx-dt.c @@ -49,6 +49,17 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = { static void __init da850_init_machine(void) { + int ret; + + ret = da8xx_register_usb20_phy_clk(false); + if (ret) + pr_warn("%s: registering USB 2.0 PHY clock failed: %d", + __func__, ret); + ret = da8xx_register_usb11_phy_clk(false); + if (ret) + pr_warn("%s: registering USB 1.1 PHY clock failed: %d", + __func__, ret); + of_platform_default_populate(NULL, da850_auxdata_lookup, NULL); } -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: david@lechnology.com (David Lechner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 4/4] ARM: davinci: da8xx: register USB PHY clocks in the DT file Date: Wed, 26 Oct 2016 19:18:18 -0500 [thread overview] Message-ID: <1477527498-21930-5-git-send-email-david@lechnology.com> (raw) In-Reply-To: <1477527498-21930-1-git-send-email-david@lechnology.com> From: Axel Haslam <ahaslam@baylibre.com> The usb20_phy clock needs to be registered for the driver to be able to get and enable a clock. Currently the usb phy clocks are registered form board files, which will not be called during a device tree based boot. To be able to probe correctly usb form a device tree boot, register the usb phy clocks form the DT specific init. Unfortunately, davinci does not have proper clock support on device tree yet, so by registering the clock form de DT specific file we are forced to hardcode the parent clock, and cannot select refclkin as parent for any of the phy clocks of the da850 family. As none of the current da850 based boards currently in mainline use refclkin as source. I guess we can live with this limitation until clocks are correctly represented through CCF/device tree. Signed-off-by: Axel Haslam <ahaslam@baylibre.com> [Added error checking] Signed-off-by: David Lechner <david@lechnology.com> --- This patch was recently submitted separately. I added error checking and I am including it in this series since it is closely related. It could be combined with the "ARM: davinci: da8xx: add usb phy clocks" patch, but I think it is good to have a separate commit for the explanation in the commit message. arch/arm/mach-davinci/da8xx-dt.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c index 75e831d..839f8db 100644 --- a/arch/arm/mach-davinci/da8xx-dt.c +++ b/arch/arm/mach-davinci/da8xx-dt.c @@ -49,6 +49,17 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = { static void __init da850_init_machine(void) { + int ret; + + ret = da8xx_register_usb20_phy_clk(false); + if (ret) + pr_warn("%s: registering USB 2.0 PHY clock failed: %d", + __func__, ret); + ret = da8xx_register_usb11_phy_clk(false); + if (ret) + pr_warn("%s: registering USB 1.1 PHY clock failed: %d", + __func__, ret); + of_platform_default_populate(NULL, da850_auxdata_lookup, NULL); } -- 2.7.4
next prev parent reply other threads:[~2016-10-27 0:20 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-27 0:18 [PATCH v7 0/4] da8xx USB PHY platform devices and clocks David Lechner 2016-10-27 0:18 ` David Lechner 2016-10-27 0:18 ` [PATCH v7 1/4] ARM: davinci: da8xx: Add USB PHY platform declaration David Lechner 2016-10-27 0:18 ` David Lechner 2016-10-31 11:54 ` Sekhar Nori 2016-10-31 11:54 ` Sekhar Nori 2016-10-27 0:18 ` [PATCH v7 2/4] ARM: davinci: da8xx: Add USB device names to clock lookup tables David Lechner 2016-10-27 0:18 ` David Lechner 2016-10-31 11:55 ` Sekhar Nori 2016-10-31 11:55 ` Sekhar Nori 2016-10-27 0:18 ` [PATCH v7 3/4] ARM: davinci: da8xx: add usb phy clocks David Lechner 2016-10-27 0:18 ` David Lechner 2016-10-27 0:18 ` David Lechner [this message] 2016-10-27 0:18 ` [PATCH v7 4/4] ARM: davinci: da8xx: register USB PHY clocks in the DT file David Lechner 2016-10-28 9:59 ` [PATCH v7 0/4] da8xx USB PHY platform devices and clocks Sekhar Nori 2016-10-28 9:59 ` Sekhar Nori
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1477527498-21930-5-git-send-email-david@lechnology.com \ --to=david@lechnology.com \ --cc=ahaslam@baylibre.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=sergei.shtylyov@cogentembedded.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.