From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> To: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-s390@vger.kernel.org, xen-devel-request@lists.xenproject.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, mingo@redhat.com, peterz@infradead.org, paulmck@linux.vnet.ibm.com, will.deacon@arm.com, kernellwp@gmail.com, jgross@suse.com, pbonzini@redhat.com, bsingharora@gmail.com, boqun.feng@gmail.com, borntraeger@de.ibm.com, rkrcmar@redhat.com, David.Laight@ACULAB.COM, Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> Subject: [PATCH v6 00/11] implement vcpu preempted check Date: Fri, 28 Oct 2016 04:11:16 -0400 [thread overview] Message-ID: <1477642287-24104-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> (raw) change from v5: spilt x86/kvm patch into guest/host part. introduce kvm_write_guest_offset_cached. fix some typos. rebase patch onto 4.9.2 change from v4: spilt x86 kvm vcpu preempted check into two patches. add documentation patch. add x86 vcpu preempted check patch under xen add s390 vcpu preempted check patch change from v3: add x86 vcpu preempted check patch change from v2: no code change, fix typos, update some comments change from v1: a simplier definition of default vcpu_is_preempted skip mahcine type check on ppc, and add config. remove dedicated macro. add one patch to drop overload of rwsem_spin_on_owner and mutex_spin_on_owner. add more comments thanks boqun and Peter's suggestion. This patch set aims to fix lock holder preemption issues. test-case: perf record -a perf bench sched messaging -g 400 -p && perf report 18.09% sched-messaging [kernel.vmlinux] [k] osq_lock 12.28% sched-messaging [kernel.vmlinux] [k] rwsem_spin_on_owner 5.27% sched-messaging [kernel.vmlinux] [k] mutex_unlock 3.89% sched-messaging [kernel.vmlinux] [k] wait_consider_task 3.64% sched-messaging [kernel.vmlinux] [k] _raw_write_lock_irq 3.41% sched-messaging [kernel.vmlinux] [k] mutex_spin_on_owner.is 2.49% sched-messaging [kernel.vmlinux] [k] system_call We introduce interface bool vcpu_is_preempted(int cpu) and use it in some spin loops of osq_lock, rwsem_spin_on_owner and mutex_spin_on_owner. These spin_on_onwer variant also cause rcu stall before we apply this patch set We also have observed some performace improvements in uninx benchmark tests. PPC test result: 1 copy - 0.94% 2 copy - 7.17% 4 copy - 11.9% 8 copy - 3.04% 16 copy - 15.11% details below: Without patch: 1 copy - File Write 4096 bufsize 8000 maxblocks 2188223.0 KBps (30.0 s, 1 samples) 2 copy - File Write 4096 bufsize 8000 maxblocks 1804433.0 KBps (30.0 s, 1 samples) 4 copy - File Write 4096 bufsize 8000 maxblocks 1237257.0 KBps (30.0 s, 1 samples) 8 copy - File Write 4096 bufsize 8000 maxblocks 1032658.0 KBps (30.0 s, 1 samples) 16 copy - File Write 4096 bufsize 8000 maxblocks 768000.0 KBps (30.1 s, 1 samples) With patch: 1 copy - File Write 4096 bufsize 8000 maxblocks 2209189.0 KBps (30.0 s, 1 samples) 2 copy - File Write 4096 bufsize 8000 maxblocks 1943816.0 KBps (30.0 s, 1 samples) 4 copy - File Write 4096 bufsize 8000 maxblocks 1405591.0 KBps (30.0 s, 1 samples) 8 copy - File Write 4096 bufsize 8000 maxblocks 1065080.0 KBps (30.0 s, 1 samples) 16 copy - File Write 4096 bufsize 8000 maxblocks 904762.0 KBps (30.0 s, 1 samples) X86 test result: test-case after-patch before-patch Execl Throughput | 18307.9 lps | 11701.6 lps File Copy 1024 bufsize 2000 maxblocks | 1352407.3 KBps | 790418.9 KBps File Copy 256 bufsize 500 maxblocks | 367555.6 KBps | 222867.7 KBps File Copy 4096 bufsize 8000 maxblocks | 3675649.7 KBps | 1780614.4 KBps Pipe Throughput | 11872208.7 lps | 11855628.9 lps Pipe-based Context Switching | 1495126.5 lps | 1490533.9 lps Process Creation | 29881.2 lps | 28572.8 lps Shell Scripts (1 concurrent) | 23224.3 lpm | 22607.4 lpm Shell Scripts (8 concurrent) | 3531.4 lpm | 3211.9 lpm System Call Overhead | 10385653.0 lps | 10419979.0 lps Christian Borntraeger (1): s390/spinlock: Provide vcpu_is_preempted Juergen Gross (1): x86, xen: support vcpu preempted check Pan Xinhui (9): kernel/sched: introduce vcpu preempted check interface locking/osq: Drop the overload of osq_lock() kernel/locking: Drop the overload of {mutex,rwsem}_spin_on_owner powerpc/spinlock: support vcpu preempted check x86, paravirt: Add interface to support kvm/xen vcpu preempted check KVM: Introduce kvm_write_guest_offset_cached x86, kvm/x86.c: support vcpu preempted check x86, kernel/kvm.c: support vcpu preempted check Documentation: virtual: kvm: Support vcpu preempted check Documentation/virtual/kvm/msr.txt | 9 ++++++++- arch/powerpc/include/asm/spinlock.h | 8 ++++++++ arch/s390/include/asm/spinlock.h | 8 ++++++++ arch/s390/kernel/smp.c | 9 +++++++-- arch/s390/lib/spinlock.c | 25 ++++++++----------------- arch/x86/include/asm/paravirt_types.h | 2 ++ arch/x86/include/asm/spinlock.h | 8 ++++++++ arch/x86/include/uapi/asm/kvm_para.h | 4 +++- arch/x86/kernel/kvm.c | 12 ++++++++++++ arch/x86/kernel/paravirt-spinlocks.c | 6 ++++++ arch/x86/kvm/x86.c | 16 ++++++++++++++++ arch/x86/xen/spinlock.c | 3 ++- include/linux/kvm_host.h | 2 ++ include/linux/sched.h | 12 ++++++++++++ kernel/locking/mutex.c | 15 +++++++++++++-- kernel/locking/osq_lock.c | 10 +++++++++- kernel/locking/rwsem-xadd.c | 16 +++++++++++++--- virt/kvm/kvm_main.c | 20 ++++++++++++++------ 18 files changed, 151 insertions(+), 34 deletions(-) -- 2.4.11
WARNING: multiple messages have this Message-ID (diff)
From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> To: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-s390@vger.kernel.org, xen-devel-request@lists.xenproject.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: kernellwp@gmail.com, jgross@suse.com, David.Laight@ACULAB.COM, rkrcmar@redhat.com, peterz@infradead.org, benh@kernel.crashing.org, will.deacon@arm.com, Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>, mingo@redhat.com, paulus@samba.org, mpe@ellerman.id.au, pbonzini@redhat.com, paulmck@linux.vnet.ibm.com, boqun.feng@gmail.com Subject: [PATCH v6 00/11] implement vcpu preempted check Date: Fri, 28 Oct 2016 04:11:16 -0400 [thread overview] Message-ID: <1477642287-24104-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> (raw) change from v5: spilt x86/kvm patch into guest/host part. introduce kvm_write_guest_offset_cached. fix some typos. rebase patch onto 4.9.2 change from v4: spilt x86 kvm vcpu preempted check into two patches. add documentation patch. add x86 vcpu preempted check patch under xen add s390 vcpu preempted check patch change from v3: add x86 vcpu preempted check patch change from v2: no code change, fix typos, update some comments change from v1: a simplier definition of default vcpu_is_preempted skip mahcine type check on ppc, and add config. remove dedicated macro. add one patch to drop overload of rwsem_spin_on_owner and mutex_spin_on_owner. add more comments thanks boqun and Peter's suggestion. This patch set aims to fix lock holder preemption issues. test-case: perf record -a perf bench sched messaging -g 400 -p && perf report 18.09% sched-messaging [kernel.vmlinux] [k] osq_lock 12.28% sched-messaging [kernel.vmlinux] [k] rwsem_spin_on_owner 5.27% sched-messaging [kernel.vmlinux] [k] mutex_unlock 3.89% sched-messaging [kernel.vmlinux] [k] wait_consider_task 3.64% sched-messaging [kernel.vmlinux] [k] _raw_write_lock_irq 3.41% sched-messaging [kernel.vmlinux] [k] mutex_spin_on_owner.is 2.49% sched-messaging [kernel.vmlinux] [k] system_call We introduce interface bool vcpu_is_preempted(int cpu) and use it in some spin loops of osq_lock, rwsem_spin_on_owner and mutex_spin_on_owner. These spin_on_onwer variant also cause rcu stall before we apply this patch set We also have observed some performace improvements in uninx benchmark tests. PPC test result: 1 copy - 0.94% 2 copy - 7.17% 4 copy - 11.9% 8 copy - 3.04% 16 copy - 15.11% details below: Without patch: 1 copy - File Write 4096 bufsize 8000 maxblocks 2188223.0 KBps (30.0 s, 1 samples) 2 copy - File Write 4096 bufsize 8000 maxblocks 1804433.0 KBps (30.0 s, 1 samples) 4 copy - File Write 4096 bufsize 8000 maxblocks 1237257.0 KBps (30.0 s, 1 samples) 8 copy - File Write 4096 bufsize 8000 maxblocks 1032658.0 KBps (30.0 s, 1 samples) 16 copy - File Write 4096 bufsize 8000 maxblocks 768000.0 KBps (30.1 s, 1 samples) With patch: 1 copy - File Write 4096 bufsize 8000 maxblocks 2209189.0 KBps (30.0 s, 1 samples) 2 copy - File Write 4096 bufsize 8000 maxblocks 1943816.0 KBps (30.0 s, 1 samples) 4 copy - File Write 4096 bufsize 8000 maxblocks 1405591.0 KBps (30.0 s, 1 samples) 8 copy - File Write 4096 bufsize 8000 maxblocks 1065080.0 KBps (30.0 s, 1 samples) 16 copy - File Write 4096 bufsize 8000 maxblocks 904762.0 KBps (30.0 s, 1 samples) X86 test result: test-case after-patch before-patch Execl Throughput | 18307.9 lps | 11701.6 lps File Copy 1024 bufsize 2000 maxblocks | 1352407.3 KBps | 790418.9 KBps File Copy 256 bufsize 500 maxblocks | 367555.6 KBps | 222867.7 KBps File Copy 4096 bufsize 8000 maxblocks | 3675649.7 KBps | 1780614.4 KBps Pipe Throughput | 11872208.7 lps | 11855628.9 lps Pipe-based Context Switching | 1495126.5 lps | 1490533.9 lps Process Creation | 29881.2 lps | 28572.8 lps Shell Scripts (1 concurrent) | 23224.3 lpm | 22607.4 lpm Shell Scripts (8 concurrent) | 3531.4 lpm | 3211.9 lpm System Call Overhead | 10385653.0 lps | 10419979.0 lps Christian Borntraeger (1): s390/spinlock: Provide vcpu_is_preempted Juergen Gross (1): x86, xen: support vcpu preempted check Pan Xinhui (9): kernel/sched: introduce vcpu preempted check interface locking/osq: Drop the overload of osq_lock() kernel/locking: Drop the overload of {mutex,rwsem}_spin_on_owner powerpc/spinlock: support vcpu preempted check x86, paravirt: Add interface to support kvm/xen vcpu preempted check KVM: Introduce kvm_write_guest_offset_cached x86, kvm/x86.c: support vcpu preempted check x86, kernel/kvm.c: support vcpu preempted check Documentation: virtual: kvm: Support vcpu preempted check Documentation/virtual/kvm/msr.txt | 9 ++++++++- arch/powerpc/include/asm/spinlock.h | 8 ++++++++ arch/s390/include/asm/spinlock.h | 8 ++++++++ arch/s390/kernel/smp.c | 9 +++++++-- arch/s390/lib/spinlock.c | 25 ++++++++----------------- arch/x86/include/asm/paravirt_types.h | 2 ++ arch/x86/include/asm/spinlock.h | 8 ++++++++ arch/x86/include/uapi/asm/kvm_para.h | 4 +++- arch/x86/kernel/kvm.c | 12 ++++++++++++ arch/x86/kernel/paravirt-spinlocks.c | 6 ++++++ arch/x86/kvm/x86.c | 16 ++++++++++++++++ arch/x86/xen/spinlock.c | 3 ++- include/linux/kvm_host.h | 2 ++ include/linux/sched.h | 12 ++++++++++++ kernel/locking/mutex.c | 15 +++++++++++++-- kernel/locking/osq_lock.c | 10 +++++++++- kernel/locking/rwsem-xadd.c | 16 +++++++++++++--- virt/kvm/kvm_main.c | 20 ++++++++++++++------ 18 files changed, 151 insertions(+), 34 deletions(-) -- 2.4.11
next reply other threads:[~2016-10-28 4:25 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-28 8:11 Pan Xinhui [this message] 2016-10-28 8:11 ` [PATCH v6 00/11] implement vcpu preempted check Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 01/11] kernel/sched: introduce vcpu preempted check interface Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock() Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-29 16:52 ` Davidlohr Bueso 2016-10-29 16:52 ` Davidlohr Bueso 2016-10-29 16:52 ` Davidlohr Bueso 2016-10-30 14:39 ` Pan Xinhui 2016-10-30 14:39 ` Pan Xinhui 2016-10-30 14:39 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 03/11] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 03/11] kernel/locking: Drop the overload of {mutex,rwsem}_spin_on_owner Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 03/11] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 04/11] powerpc/spinlock: support vcpu preempted check Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 05/11] s390/spinlock: Provide vcpu_is_preempted Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 06/11] x86, paravirt: Add interface to support kvm/xen vcpu preempted check Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 07/11] KVM: Introduce kvm_write_guest_offset_cached Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 08/11] x86, kvm/x86.c: support vcpu preempted check Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 09/11] x86, kernel/kvm.c: " Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 10/11] x86, xen: " Pan Xinhui 2016-10-28 19:43 ` [Xen-devel] " Konrad Rzeszutek Wilk 2016-10-28 19:43 ` Konrad Rzeszutek Wilk 2016-10-29 4:26 ` Pan Xinhui 2016-10-29 4:26 ` [Xen-devel] " Pan Xinhui 2016-10-29 4:26 ` Pan Xinhui 2016-10-28 19:43 ` Konrad Rzeszutek Wilk 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` [PATCH v6 11/11] Documentation: virtual: kvm: Support " Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 8:11 ` Pan Xinhui 2016-10-28 9:57 ` [PATCH v6 00/11] implement " Paolo Bonzini 2016-10-28 9:57 ` Paolo Bonzini 2016-10-28 9:57 ` Paolo Bonzini 2016-10-28 19:38 ` Konrad Rzeszutek Wilk 2016-10-28 19:38 ` [Xen-devel] " Konrad Rzeszutek Wilk 2016-10-28 19:38 ` Konrad Rzeszutek Wilk 2016-10-29 4:37 ` Pan Xinhui 2016-10-29 4:37 ` Pan Xinhui 2016-10-29 4:37 ` Pan Xinhui -- strict thread matches above, loose matches on Subject: below -- 2016-10-28 8:11 Pan Xinhui
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1477642287-24104-1-git-send-email-xinhui.pan@linux.vnet.ibm.com \ --to=xinhui.pan@linux.vnet.ibm.com \ --cc=David.Laight@ACULAB.COM \ --cc=benh@kernel.crashing.org \ --cc=boqun.feng@gmail.com \ --cc=borntraeger@de.ibm.com \ --cc=bsingharora@gmail.com \ --cc=jgross@suse.com \ --cc=kernellwp@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=paulmck@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=pbonzini@redhat.com \ --cc=peterz@infradead.org \ --cc=rkrcmar@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ --cc=xen-devel-request@lists.xenproject.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.