All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64
@ 2016-10-28 10:07 ting.liu
  2016-10-28 15:07 ` Christopher Larson
  0 siblings, 1 reply; 5+ messages in thread
From: ting.liu @ 2016-10-28 10:07 UTC (permalink / raw)
  To: openembedded-devel; +Cc: otavio.salvador

From: Ting Liu <ting.liu@nxp.com>

xterm installs files into PREFIX/lib/X11/app-defaults by default.
This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
ERROR: QA Issue: xterm: Files/directories were installed but not shipped in any package:
  /usr/lib
  /usr/lib/X11
  /usr/lib/X11/app-defaults
  /usr/lib/X11/app-defaults/UXTerm
  /usr/lib/X11/app-defaults/KOI8RXTerm-color
  /usr/lib/X11/app-defaults/XTerm-color
  /usr/lib/X11/app-defaults/UXTerm-color
  /usr/lib/X11/app-defaults/KOI8RXTerm
  /usr/lib/X11/app-defaults/XTerm

Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to configure.

Signed-off-by: Ting Liu <ting.liu@nxp.com>
---
 meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
index e0baf3c..48556c7 100644
--- a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
+++ b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
@@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft fontconfig fre
 
 EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
                  --x-libraries=${STAGING_LIBDIR} \
+                 --with-app-defaults=${libdir}/X11/app-defaults \
                  FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config \
                  --disable-imake \
                  --disable-rpath-hack \
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64
  2016-10-28 10:07 [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64 ting.liu
@ 2016-10-28 15:07 ` Christopher Larson
  2016-10-28 15:32   ` Otavio Salvador
  2016-10-31  4:15   ` Ting Liu
  0 siblings, 2 replies; 5+ messages in thread
From: Christopher Larson @ 2016-10-28 15:07 UTC (permalink / raw)
  To: Openembedded Discussion; +Cc: Otavio Salvador

On Fri, Oct 28, 2016 at 3:07 AM, <ting.liu@nxp.com> wrote:

> xterm installs files into PREFIX/lib/X11/app-defaults by default.
> This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
> ERROR: QA Issue: xterm: Files/directories were installed but not shipped
> in any package:
>   /usr/lib
>   /usr/lib/X11
>   /usr/lib/X11/app-defaults
>   /usr/lib/X11/app-defaults/UXTerm
>   /usr/lib/X11/app-defaults/KOI8RXTerm-color
>   /usr/lib/X11/app-defaults/XTerm-color
>   /usr/lib/X11/app-defaults/UXTerm-color
>   /usr/lib/X11/app-defaults/KOI8RXTerm
>   /usr/lib/X11/app-defaults/XTerm
>
> Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to
> configure.
>
> Signed-off-by: Ting Liu <ting.liu@nxp.com>
> ---
>  meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> index e0baf3c..48556c7 100644
> --- a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> +++ b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> @@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft
> fontconfig fre
>
>  EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
>                   --x-libraries=${STAGING_LIBDIR} \
> +                 --with-app-defaults=${libdir}/X11/app-defaults \
>                   FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config
> \
>                   --disable-imake \
>                   --disable-rpath-hack \
>

Are you sure this is correct? I highly doubt those files are actually
multilib specific. Would it not be better to just package these files in
their current location?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64
  2016-10-28 15:07 ` Christopher Larson
@ 2016-10-28 15:32   ` Otavio Salvador
  2016-10-31  4:15   ` Ting Liu
  1 sibling, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2016-10-28 15:32 UTC (permalink / raw)
  To: OpenEmbedded Devel List

On Fri, Oct 28, 2016 at 1:07 PM, Christopher Larson <clarson@kergoth.com> wrote:
> On Fri, Oct 28, 2016 at 3:07 AM, <ting.liu@nxp.com> wrote:
>
>> xterm installs files into PREFIX/lib/X11/app-defaults by default.
>> This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
>> ERROR: QA Issue: xterm: Files/directories were installed but not shipped
>> in any package:
>>   /usr/lib
>>   /usr/lib/X11
>>   /usr/lib/X11/app-defaults
>>   /usr/lib/X11/app-defaults/UXTerm
>>   /usr/lib/X11/app-defaults/KOI8RXTerm-color
>>   /usr/lib/X11/app-defaults/XTerm-color
>>   /usr/lib/X11/app-defaults/UXTerm-color
>>   /usr/lib/X11/app-defaults/KOI8RXTerm
>>   /usr/lib/X11/app-defaults/XTerm
>>
>> Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to
>> configure.
>>
>> Signed-off-by: Ting Liu <ting.liu@nxp.com>
>> ---
>>  meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
>> b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
>> index e0baf3c..48556c7 100644
>> --- a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
>> +++ b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
>> @@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft
>> fontconfig fre
>>
>>  EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
>>                   --x-libraries=${STAGING_LIBDIR} \
>> +                 --with-app-defaults=${libdir}/X11/app-defaults \
>>                   FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config
>> \
>>                   --disable-imake \
>>                   --disable-rpath-hack \
>>
>
> Are you sure this is correct? I highly doubt those files are actually
> multilib specific. Would it not be better to just package these files in
> their current location?

Or use datadir

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64
  2016-10-28 15:07 ` Christopher Larson
  2016-10-28 15:32   ` Otavio Salvador
@ 2016-10-31  4:15   ` Ting Liu
  1 sibling, 0 replies; 5+ messages in thread
From: Ting Liu @ 2016-10-31  4:15 UTC (permalink / raw)
  To: openembedded-devel

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On
> Behalf Of Christopher Larson
> Sent: Friday, October 28, 2016 11:07 PM
> To: Openembedded Discussion <openembedded-
> devel@lists.openembedded.org>
> Cc: Otavio Salvador <otavio.salvador@ossystems.com.br>
> Subject: Re: [oe] [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-
> shipped error on ppc64
> 
> On Fri, Oct 28, 2016 at 3:07 AM, <ting.liu@nxp.com> wrote:
> 
> > xterm installs files into PREFIX/lib/X11/app-defaults by default.
> > This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
> > ERROR: QA Issue: xterm: Files/directories were installed but not
> > shipped in any package:
> >   /usr/lib
> >   /usr/lib/X11
> >   /usr/lib/X11/app-defaults
> >   /usr/lib/X11/app-defaults/UXTerm
> >   /usr/lib/X11/app-defaults/KOI8RXTerm-color
> >   /usr/lib/X11/app-defaults/XTerm-color
> >   /usr/lib/X11/app-defaults/UXTerm-color
> >   /usr/lib/X11/app-defaults/KOI8RXTerm
> >   /usr/lib/X11/app-defaults/XTerm
> >
> > Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to
> > configure.
> >
> > Signed-off-by: Ting Liu <ting.liu@nxp.com>
> > ---
> >  meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> > b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> > index e0baf3c..48556c7 100644
> > --- a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> > +++ b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> > @@ -14,6 +14,7 @@ PACKAGECONFIG[xft] =
> > "--enable-freetype,--disable-freetype,libxft
> > fontconfig fre
> >
> >  EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
> >                   --x-libraries=${STAGING_LIBDIR} \
> > +                 --with-app-defaults=${libdir}/X11/app-defaults \
> >
> > FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config
> > \
> >                   --disable-imake \
> >                   --disable-rpath-hack \
> >
> 
> Are you sure this is correct? I highly doubt those files are actually multilib
> specific. Would it not be better to just package these files in their current
> location?
[Liu Ting-B28495] I have sent another patch to package these files in their current location. Thanks.

> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior
> Software Engineer, Mentor Graphics
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64
       [not found] <1476803797-18279-1-git-send-email-ting.liu@nxp.com>
@ 2016-10-18 15:24 ` Otavio Salvador
  0 siblings, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2016-10-18 15:24 UTC (permalink / raw)
  To: Ting Liu; +Cc: OpenEmbedded Devel List

On Tue, Oct 18, 2016 at 1:16 PM,  <ting.liu@nxp.com> wrote:
> From: Ting Liu <ting.liu@nxp.com>
>
> xterm installs files into PREFIX/lib/X11/app-defaults by default.
> This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
> ERROR: QA Issue: xterm: Files/directories were installed but not shipped in any package:
>   /usr/lib
>   /usr/lib/X11
>   /usr/lib/X11/app-defaults
>   /usr/lib/X11/app-defaults/UXTerm
>   /usr/lib/X11/app-defaults/KOI8RXTerm-color
>   /usr/lib/X11/app-defaults/XTerm-color
>   /usr/lib/X11/app-defaults/UXTerm-color
>   /usr/lib/X11/app-defaults/KOI8RXTerm
>   /usr/lib/X11/app-defaults/XTerm
>
> Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to configure.
>
> Signed-off-by: Ting Liu <ting.liu@nxp.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Armin/Martin: this is an important fix as ppc64 machines are currently
broken. Please apply this onto master and morty branches.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-31  8:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-28 10:07 [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64 ting.liu
2016-10-28 15:07 ` Christopher Larson
2016-10-28 15:32   ` Otavio Salvador
2016-10-31  4:15   ` Ting Liu
     [not found] <1476803797-18279-1-git-send-email-ting.liu@nxp.com>
2016-10-18 15:24 ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.