[PATCH net-next] genetlink: fix error return code in genl_register_family()

From: Wei Yongjun <weiyj.lk@gmail.com>
To: stephen hemminger <stephen@networkplumber.org>,
	Matti Vaittinen <matti.vaittinen@nokia.com>,
	Tom Herbert <tom@herbertland.com>,
	Johannes Berg <johannes.berg@intel.com>,
	pravin shelar <pshelar@ovn.org>,
	Tycho Andersen <tycho.andersen@canonical.com>,
	Florian Westphal <fw@strlen.de>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, netdev@vger.kernel.org
Subject: [PATCH net-next] genetlink: fix error return code in genl_register_family()
Date: Mon, 31 Oct 2016 14:53:03 +0000	[thread overview]
Message-ID: <1477925583-7956-1-git-send-email-weiyj.lk@gmail.com> (raw)

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return error code -ENOMEM from the idr_alloc() error handling
case instead of 0, as done elsewhere in this function.

Fixes: 2ae0f17df1cd ("genetlink: use idr to track families")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 net/netlink/genetlink.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index caf04d7..305730d 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -362,8 +362,10 @@ int genl_register_family(struct genl_family *family)
 
 	family->id = idr_alloc(&genl_fam_idr, family,
 			       start, end + 1, GFP_KERNEL);
-	if (!family->id)
+	if (!family->id) {
+		err = -ENOMEM;
 		goto errout_locked;
+	}
 
 	err = genl_validate_assign_mc_groups(family);
 	if (err)
