From: David Miller <davem@davemloft.net>
To: weiyj.lk@gmail.com
Cc: stephen@networkplumber.org, tom@herbertland.com, fw@strlen.de,
johannes.berg@intel.com, pshelar@ovn.org,
tycho.andersen@canonical.com, matti.vaittinen@nokia.com,
weiyongjun1@huawei.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] genetlink: fix error return code in genl_register_family()
Date: Tue, 01 Nov 2016 12:13:51 -0400 (EDT) [thread overview]
Message-ID: <20161101.121351.1287443789684060786.davem@davemloft.net> (raw)
In-Reply-To: <1478011552-24957-1-git-send-email-weiyj.lk@gmail.com>
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 1 Nov 2016 14:45:52 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the idr_alloc() error handling
> case instead of 0, as done elsewhere in this function.
>
> Also fix the return value check of idr_alloc() since idr_alloc return
> negative errors on failure, not zero.
>
> Fixes: 2ae0f17df1cd ("genetlink: use idr to track families")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: fix the return value check and return idr_alloc's err code
Applied, thanks.
prev parent reply other threads:[~2016-11-01 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 14:53 [PATCH net-next] genetlink: fix error return code in genl_register_family() Wei Yongjun
2016-10-31 20:29 ` David Miller
2016-11-01 14:45 ` [PATCH net-next v2] " Wei Yongjun
2016-11-01 16:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101.121351.1287443789684060786.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=johannes.berg@intel.com \
--cc=matti.vaittinen@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=stephen@networkplumber.org \
--cc=tom@herbertland.com \
--cc=tycho.andersen@canonical.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.