* [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor
@ 2016-10-31 17:51 Ashijeet Acharya
2016-10-31 18:48 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Ashijeet Acharya @ 2016-10-31 17:51 UTC (permalink / raw)
To: kwolf; +Cc: mreitz, pbonzini, qemu-devel, qemu-block, Ashijeet Acharya
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it.
Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index 8ef1438..ff9d01a 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -545,6 +545,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options)
qdict_put(opts, "tls-creds", qstring_from_str(s->tlscredsid));
}
+ visit_free(ov);
qdict_flatten(opts);
bs->full_open_options = opts;
}
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor
2016-10-31 17:51 [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor Ashijeet Acharya
@ 2016-10-31 18:48 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2016-10-31 18:48 UTC (permalink / raw)
To: Ashijeet Acharya, kwolf; +Cc: pbonzini, qemu-devel, qemu-block, mreitz
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On 10/31/2016 12:51 PM, Ashijeet Acharya wrote:
> This patch frees the leaked visitor in nbd_refresh_filename() and uses
> visit_free() to fix it.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
> ---
> block/nbd.c | 1 +
> 1 file changed, 1 insertion(+)
Would be nice to mention that it was commit 491d6c7 that introduced the
leak.
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/nbd.c b/block/nbd.c
> index 8ef1438..ff9d01a 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -545,6 +545,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options)
> qdict_put(opts, "tls-creds", qstring_from_str(s->tlscredsid));
> }
>
> + visit_free(ov);
> qdict_flatten(opts);
> bs->full_open_options = opts;
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-31 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-31 17:51 [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor Ashijeet Acharya
2016-10-31 18:48 ` Eric Blake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.