All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/20] rockchip: video: Correct VOP clock selection
Date: Mon, 31 Oct 2016 14:39:18 -0600	[thread overview]
Message-ID: <1477946376-29471-3-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1477946376-29471-1-git-send-email-sjg@chromium.org>

This code incorrectly uses the oscillator. It should use the clock
selected in the device tree.

Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: 135aa95 (clk: convert API to match reset/mailbox style)
---

 drivers/video/rockchip/rk_vop.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c
index c6d88d9..130dace 100644
--- a/drivers/video/rockchip/rk_vop.c
+++ b/drivers/video/rockchip/rk_vop.c
@@ -195,7 +195,6 @@ int rk_display_init(struct udevice *dev, ulong fbbase,
 	struct udevice *disp;
 	int ret, remote, i, offset;
 	struct display_plat *disp_uc_plat;
-	struct udevice *dev_clk;
 	struct clk clk;
 
 	vop_id = fdtdec_get_int(blob, ep_node, "reg", -1);
@@ -238,11 +237,7 @@ int rk_display_init(struct udevice *dev, ulong fbbase,
 		return ret;
 	}
 
-	ret = rockchip_get_clk(&dev_clk);
-	if (!ret) {
-		clk.id = DCLK_VOP0 + remote_vop_id;
-		ret = clk_request(dev_clk, &clk);
-	}
+	ret = clk_get_by_index(dev, 1, &clk);
 	if (!ret)
 		ret = clk_set_rate(&clk, timing.pixelclock.typ);
 	if (ret) {
-- 
2.8.0.rc3.226.g39d4020

  parent reply	other threads:[~2016-10-31 20:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 20:39 [U-Boot] [PATCH 00/20] rockchip: Add support for Asus Chromebit Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 01/20] rockchip: video: Correct HDMI data source selection Simon Glass
2016-10-31 20:57   ` Andrew F. Davis
2016-10-31 20:39 ` Simon Glass [this message]
2016-10-31 20:39 ` [U-Boot] [PATCH 03/20] rockchip: Allow jerry to use of-platdata Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 04/20] dm: core: Handle global_data moving in SPL Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 05/20] stdio: Correct code style nits Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 06/20] stdio: Correct numbering logic in stdio_probe_device() Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 07/20] spi: Add of-platdata support to SPI and SPI flash Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 08/20] rockchip: spi: Add support for of-platdata Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 09/20] rockchip: spi: Honour the deactivation delay Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 10/20] spi: Add error checking for invalid bus widths Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 11/20] spi: Add a debug() on bind failure Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 12/20] video: Use cache-alignment in video_sync() Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 13/20] video: Track whether a display is in use Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 14/20] rockchip: video: Check for device " Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 15/20] rockchip: Move jerry to use of-platdata Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 16/20] rockchip: Rename jerry files to veyron Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 17/20] rockchip: Move jerry SDRAM settings into its own .dts file Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 18/20] rockchip: clk: Support setting ACLK Simon Glass
2016-11-04  1:05   ` Kever Yang
2016-10-31 20:39 ` [U-Boot] [PATCH 19/20] rockchip: veyron: Adjust ARM clock after relocation Simon Glass
2016-10-31 20:39 ` [U-Boot] [PATCH 20/20] rockchip: Add support for veyron-mickey (Chromebit) Simon Glass
2021-06-22 15:50 [U-Boot] [PATCH 02/20] rockchip: video: Correct VOP clock selection SHAHZAD ALI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477946376-29471-3-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.