* [PATCHv3 0/4] Add Altera A10SR Status & Control Monitor @ 2016-11-02 14:32 ` tthayer 0 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> his patch series adds the Altera Arria10 DevKit System Resource chip's Status and Control Monitor to the A10SR Multi-Function Device. An earlier patch added this to the hwmon class which wasn't the proper place so this functionality is added to the misc directory. Version 2 changes the DT names from -mon to -monitor for better readability and clarity and changed the previous version from modular to built-in. Version 3 improves the DT bindings naming and removes an unused variable. Thor Thayer (4): dt-bindings: mfd: Add Altera Arria10 SR Monitor misc: Add Altera Arria10 System Resource Control mfd: altr-a10sr: Add Arria10 SR Monitor ARM: socfpga: dts: Add Monitor to A10-SR MFD .../devicetree/bindings/mfd/altera-a10sr.txt | 11 +- MAINTAINERS | 1 + arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 + drivers/mfd/altera-a10sr.c | 6 +- drivers/misc/Kconfig | 7 + drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-monitor.c | 175 +++++++++++++++++++++ 7 files changed, 203 insertions(+), 2 deletions(-) create mode 100644 drivers/misc/altera-a10sr-monitor.c -- 1.9.1 ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 0/4] Add Altera A10SR Status & Control Monitor @ 2016-11-02 14:32 ` tthayer 0 siblings, 0 replies; 25+ messages in thread From: tthayer at opensource.altera.com @ 2016-11-02 14:32 UTC (permalink / raw) To: linux-arm-kernel From: Thor Thayer <tthayer@opensource.altera.com> his patch series adds the Altera Arria10 DevKit System Resource chip's Status and Control Monitor to the A10SR Multi-Function Device. An earlier patch added this to the hwmon class which wasn't the proper place so this functionality is added to the misc directory. Version 2 changes the DT names from -mon to -monitor for better readability and clarity and changed the previous version from modular to built-in. Version 3 improves the DT bindings naming and removes an unused variable. Thor Thayer (4): dt-bindings: mfd: Add Altera Arria10 SR Monitor misc: Add Altera Arria10 System Resource Control mfd: altr-a10sr: Add Arria10 SR Monitor ARM: socfpga: dts: Add Monitor to A10-SR MFD .../devicetree/bindings/mfd/altera-a10sr.txt | 11 +- MAINTAINERS | 1 + arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 + drivers/mfd/altera-a10sr.c | 6 +- drivers/misc/Kconfig | 7 + drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-monitor.c | 175 +++++++++++++++++++++ 7 files changed, 203 insertions(+), 2 deletions(-) create mode 100644 drivers/misc/altera-a10sr-monitor.c -- 1.9.1 ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 0/4] Add Altera A10SR Status & Control Monitor @ 2016-11-02 14:32 ` tthayer 0 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> his patch series adds the Altera Arria10 DevKit System Resource chip's Status and Control Monitor to the A10SR Multi-Function Device. An earlier patch added this to the hwmon class which wasn't the proper place so this functionality is added to the misc directory. Version 2 changes the DT names from -mon to -monitor for better readability and clarity and changed the previous version from modular to built-in. Version 3 improves the DT bindings naming and removes an unused variable. Thor Thayer (4): dt-bindings: mfd: Add Altera Arria10 SR Monitor misc: Add Altera Arria10 System Resource Control mfd: altr-a10sr: Add Arria10 SR Monitor ARM: socfpga: dts: Add Monitor to A10-SR MFD .../devicetree/bindings/mfd/altera-a10sr.txt | 11 +- MAINTAINERS | 1 + arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 + drivers/mfd/altera-a10sr.c | 6 +- drivers/misc/Kconfig | 7 + drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-monitor.c | 175 +++++++++++++++++++++ 7 files changed, 203 insertions(+), 2 deletions(-) create mode 100644 drivers/misc/altera-a10sr-monitor.c -- 1.9.1 ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> Add the Arria10 DevKit System Resource Chip register and state monitoring module to the MFD. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- Note: This needs to be applied to the bindings document that was Acked & Applied but didn't reach the for-next branch. See https://patchwork.ozlabs.org/patch/629397/ --- v2 Change compatible string -mon to -monitor for clarity v3 Replace node name a10sr_monitor with just monitor. Replace node name a10sr_gpio with just gpio. --- Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt index ea151f2..69243d2 100644 --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt @@ -17,7 +17,8 @@ The A10SR consists of these sub-devices: Device Description ------ ---------- -a10sr_gpio GPIO Controller +gpio GPIO Controller +monitor Register and State Monitoring Arria10 GPIO Required Properties: @@ -27,6 +28,10 @@ Required Properties: the second cell is used to specify flags. See ../gpio/gpio.txt for more information. +Arria10 Register and State Monitor +Required Properties: +- compatible : Should be "altr,a10sr-monitor" + Example: resource-manager@0 { @@ -43,4 +48,8 @@ Example: gpio-controller; #gpio-cells = <2>; }; + + monitor { + compatible = "altr,a10sr-monitor"; + }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer at opensource.altera.com @ 2016-11-02 14:32 UTC (permalink / raw) To: linux-arm-kernel From: Thor Thayer <tthayer@opensource.altera.com> Add the Arria10 DevKit System Resource Chip register and state monitoring module to the MFD. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- Note: This needs to be applied to the bindings document that was Acked & Applied but didn't reach the for-next branch. See https://patchwork.ozlabs.org/patch/629397/ --- v2 Change compatible string -mon to -monitor for clarity v3 Replace node name a10sr_monitor with just monitor. Replace node name a10sr_gpio with just gpio. --- Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt index ea151f2..69243d2 100644 --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt @@ -17,7 +17,8 @@ The A10SR consists of these sub-devices: Device Description ------ ---------- -a10sr_gpio GPIO Controller +gpio GPIO Controller +monitor Register and State Monitoring Arria10 GPIO Required Properties: @@ -27,6 +28,10 @@ Required Properties: the second cell is used to specify flags. See ../gpio/gpio.txt for more information. +Arria10 Register and State Monitor +Required Properties: +- compatible : Should be "altr,a10sr-monitor" + Example: resource-manager at 0 { @@ -43,4 +48,8 @@ Example: gpio-controller; #gpio-cells = <2>; }; + + monitor { + compatible = "altr,a10sr-monitor"; + }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, linux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thor Thayer From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Add the Arria10 DevKit System Resource Chip register and state monitoring module to the MFD. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- Note: This needs to be applied to the bindings document that was Acked & Applied but didn't reach the for-next branch. See https://patchwork.ozlabs.org/patch/629397/ --- v2 Change compatible string -mon to -monitor for clarity v3 Replace node name a10sr_monitor with just monitor. Replace node name a10sr_gpio with just gpio. --- Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt index ea151f2..69243d2 100644 --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt @@ -17,7 +17,8 @@ The A10SR consists of these sub-devices: Device Description ------ ---------- -a10sr_gpio GPIO Controller +gpio GPIO Controller +monitor Register and State Monitoring Arria10 GPIO Required Properties: @@ -27,6 +28,10 @@ Required Properties: the second cell is used to specify flags. See ../gpio/gpio.txt for more information. +Arria10 Register and State Monitor +Required Properties: +- compatible : Should be "altr,a10sr-monitor" + Example: resource-manager@0 { @@ -43,4 +48,8 @@ Example: gpio-controller; #gpio-cells = <2>; }; + + monitor { + compatible = "altr,a10sr-monitor"; + }; }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-11-03 14:39 ` Lee Jones -1 siblings, 0 replies; 25+ messages in thread From: Lee Jones @ 2016-11-03 14:39 UTC (permalink / raw) To: tthayer Cc: robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh, davem, geert, devicetree, linux-kernel, linux-arm-kernel On Wed, 02 Nov 2016, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > v2 Change compatible string -mon to -monitor for clarity > v3 Replace node name a10sr_monitor with just monitor. > Replace node name a10sr_gpio with just gpio. > --- > Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > index ea151f2..69243d2 100644 > --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > @@ -17,7 +17,8 @@ The A10SR consists of these sub-devices: > > Device Description > ------ ---------- > -a10sr_gpio GPIO Controller > +gpio GPIO Controller > +monitor Register and State Monitoring > > Arria10 GPIO > Required Properties: > @@ -27,6 +28,10 @@ Required Properties: > the second cell is used to specify flags. > See ../gpio/gpio.txt for more information. > > +Arria10 Register and State Monitor > +Required Properties: > +- compatible : Should be "altr,a10sr-monitor" > + > Example: > > resource-manager@0 { > @@ -43,4 +48,8 @@ Example: > gpio-controller; > #gpio-cells = <2>; > }; > + > + monitor { > + compatible = "altr,a10sr-monitor"; > + }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-03 14:39 ` Lee Jones 0 siblings, 0 replies; 25+ messages in thread From: Lee Jones @ 2016-11-03 14:39 UTC (permalink / raw) To: linux-arm-kernel On Wed, 02 Nov 2016, tthayer at opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > v2 Change compatible string -mon to -monitor for clarity > v3 Replace node name a10sr_monitor with just monitor. > Replace node name a10sr_gpio with just gpio. > --- > Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > index ea151f2..69243d2 100644 > --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > @@ -17,7 +17,8 @@ The A10SR consists of these sub-devices: > > Device Description > ------ ---------- > -a10sr_gpio GPIO Controller > +gpio GPIO Controller > +monitor Register and State Monitoring > > Arria10 GPIO > Required Properties: > @@ -27,6 +28,10 @@ Required Properties: > the second cell is used to specify flags. > See ../gpio/gpio.txt for more information. > > +Arria10 Register and State Monitor > +Required Properties: > +- compatible : Should be "altr,a10sr-monitor" > + > Example: > > resource-manager at 0 { > @@ -43,4 +48,8 @@ Example: > gpio-controller; > #gpio-cells = <2>; > }; > + > + monitor { > + compatible = "altr,a10sr-monitor"; > + }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-09 18:26 ` Rob Herring 0 siblings, 0 replies; 25+ messages in thread From: Rob Herring @ 2016-11-09 18:26 UTC (permalink / raw) To: tthayer Cc: lee.jones, mark.rutland, dinguyen, linux, arnd, gregkh, davem, geert, devicetree, linux-kernel, linux-arm-kernel On Wed, Nov 02, 2016 at 09:32:55AM -0500, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > v2 Change compatible string -mon to -monitor for clarity > v3 Replace node name a10sr_monitor with just monitor. > Replace node name a10sr_gpio with just gpio. > --- > Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-09 18:26 ` Rob Herring 0 siblings, 0 replies; 25+ messages in thread From: Rob Herring @ 2016-11-09 18:26 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 02, 2016 at 09:32:55AM -0500, tthayer at opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > v2 Change compatible string -mon to -monitor for clarity > v3 Replace node name a10sr_monitor with just monitor. > Replace node name a10sr_gpio with just gpio. > --- > Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor @ 2016-11-09 18:26 ` Rob Herring 0 siblings, 0 replies; 25+ messages in thread From: Rob Herring @ 2016-11-09 18:26 UTC (permalink / raw) To: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, linux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Nov 02, 2016 at 09:32:55AM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: > From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > v2 Change compatible string -mon to -monitor for clarity > v3 Replace node name a10sr_monitor with just monitor. > Replace node name a10sr_gpio with just gpio. > --- > Documentation/devicetree/bindings/mfd/altera-a10sr.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 2/4] misc: Add Altera Arria10 System Resource Control @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> This patch adds the Altera Arria10 control & monitoring functions to the Arria10 System Resource chip. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- v2 Change compatible string and filename from -mon to -monitor Change CONFIG from module to builtin. Make wm_rst register writeable. v3 Remove unused ret variable. Shorten driver name (remove altr_). --- MAINTAINERS | 1 + drivers/misc/Kconfig | 7 ++ drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-monitor.c | 175 ++++++++++++++++++++++++++++++++++++ 4 files changed, 184 insertions(+) create mode 100644 drivers/misc/altera-a10sr-monitor.c diff --git a/MAINTAINERS b/MAINTAINERS index b180821..baf2404 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -635,6 +635,7 @@ M: Thor Thayer <tthayer@opensource.altera.com> S: Maintained F: drivers/gpio/gpio-altera-a10sr.c F: drivers/mfd/altera-a10sr.c +F: drivers/misc/altera-a10sr-monitor.c F: include/linux/mfd/altera-a10sr.h ALTERA TRIPLE SPEED ETHERNET DRIVER diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 64971ba..f42d459 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -766,6 +766,13 @@ config PANEL_BOOT_MESSAGE An empty message will only clear the display at driver init time. Any other printf()-formatted message is valid with newline and escape codes. +config ALTERA_A10SR_MONITOR + bool "Altera Arria10 System Resource Monitor" + depends on MFD_ALTERA_A10SR + help + This enables the System Resource monitor driver for the Altera + Arria10 DevKit. + source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 3198336..9f6e77a 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -43,6 +43,7 @@ obj-y += ti-st/ obj-y += lis3lv02d/ obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ +obj-$(CONFIG_ALTERA_A10SR_MONITOR) += altera-a10sr-monitor.o obj-$(CONFIG_INTEL_MEI) += mei/ obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o diff --git a/drivers/misc/altera-a10sr-monitor.c b/drivers/misc/altera-a10sr-monitor.c new file mode 100644 index 0000000..66338e0 --- /dev/null +++ b/drivers/misc/altera-a10sr-monitor.c @@ -0,0 +1,175 @@ +/* + * Altera Arria10 DevKit System Resource Chip Monitor Driver + * + * Author: Thor Thayer <tthayer@opensource.altera.com> + * + * Copyright Intel Corporation (C) 2014-2016. All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see <http://www.gnu.org/licenses/>. + * + * Monitor driver for the Altera Arria10 MAX5 System Resource Chip + * Adapted from ics932s401.c + */ + +#include <linux/err.h> +#include <linux/mfd/altera-a10sr.h> +#include <linux/init.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +struct altr_a10sr_regs { + struct regmap *regmap; + struct attribute_group attr_grp; +}; + +static ssize_t a10sr_show(struct device *dev, + struct device_attribute *devattr, char *buf); +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count); + +/* Define FS entries */ +static DEVICE_ATTR(max5_version, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_led, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_button, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_button_irq, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pg1, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg2, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg3, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_fmcab, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_hps_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_per_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpa, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpb, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_i2c_master, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst_key, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pmbus, 0644, a10sr_show, a10sr_store); + +static struct attribute *altr_a10sr_attr[] = { + &dev_attr_max5_version.attr, + &dev_attr_max5_led.attr, + &dev_attr_max5_button.attr, + &dev_attr_max5_button_irq.attr, + &dev_attr_max5_pg1.attr, + &dev_attr_max5_pg2.attr, + &dev_attr_max5_pg3.attr, + &dev_attr_max5_fmcab.attr, + &dev_attr_max5_hps_resets.attr, + &dev_attr_max5_per_resets.attr, + &dev_attr_max5_sfpa.attr, + &dev_attr_max5_sfpb.attr, + &dev_attr_max5_i2c_master.attr, + &dev_attr_max5_wm_rst.attr, + &dev_attr_max5_wm_rst_key.attr, + &dev_attr_max5_pmbus.attr, + NULL +}; + +static const struct attribute_group a10sr_attr_group = { + .attrs = altr_a10sr_attr, +}; + +static ssize_t a10sr_show(struct device *dev, struct device_attribute *devattr, + char *buf) +{ + int i, ret; + unsigned int val; + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit set by regmap for Read */ + i <<= 1; + ret = regmap_read(a10sr_regs->regmap, i, &val); + if (ret < 0) + return ret; + + return sprintf(buf, "0x%X\n", val); +} + +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count) +{ + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + unsigned long val; + int i, ret; + + ret = kstrtol(buf, 0, &val); + if (ret < 0) + return ret; + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit cleared by regmap for Write */ + i <<= 1; + ret = regmap_write(a10sr_regs->regmap, i, val); + if (ret < 0) + return ret; + + return count; +} + +static int altr_a10sr_regs_probe(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs; + struct altr_a10sr *a10sr = dev_get_drvdata(pdev->dev.parent); + + a10regs = devm_kzalloc(&pdev->dev, sizeof(*a10regs), GFP_KERNEL); + if (!a10regs) + return -ENOMEM; + + a10regs->regmap = a10sr->regmap; + a10regs->attr_grp = a10sr_attr_group; + + platform_set_drvdata(pdev, a10regs); + + return sysfs_create_group(&pdev->dev.kobj, &a10sr_attr_group); +} + +static int altr_a10sr_regs_remove(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs = platform_get_drvdata(pdev); + + sysfs_remove_group(&pdev->dev.kobj, &a10regs->attr_grp); + + return 0; +} + +static const struct of_device_id altr_a10sr_regs_of_match[] = { + { .compatible = "altr,a10sr-monitor" }, + { }, +}; + +static struct platform_driver altr_a10sr_regs_driver = { + .probe = altr_a10sr_regs_probe, + .remove = altr_a10sr_regs_remove, + .driver = { + .name = "a10sr_monitor", + .of_match_table = altr_a10sr_regs_of_match, + }, +}; + +builtin_platform_driver(altr_a10sr_regs_driver); -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 2/4] misc: Add Altera Arria10 System Resource Control @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer at opensource.altera.com @ 2016-11-02 14:32 UTC (permalink / raw) To: linux-arm-kernel From: Thor Thayer <tthayer@opensource.altera.com> This patch adds the Altera Arria10 control & monitoring functions to the Arria10 System Resource chip. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- v2 Change compatible string and filename from -mon to -monitor Change CONFIG from module to builtin. Make wm_rst register writeable. v3 Remove unused ret variable. Shorten driver name (remove altr_). --- MAINTAINERS | 1 + drivers/misc/Kconfig | 7 ++ drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-monitor.c | 175 ++++++++++++++++++++++++++++++++++++ 4 files changed, 184 insertions(+) create mode 100644 drivers/misc/altera-a10sr-monitor.c diff --git a/MAINTAINERS b/MAINTAINERS index b180821..baf2404 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -635,6 +635,7 @@ M: Thor Thayer <tthayer@opensource.altera.com> S: Maintained F: drivers/gpio/gpio-altera-a10sr.c F: drivers/mfd/altera-a10sr.c +F: drivers/misc/altera-a10sr-monitor.c F: include/linux/mfd/altera-a10sr.h ALTERA TRIPLE SPEED ETHERNET DRIVER diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 64971ba..f42d459 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -766,6 +766,13 @@ config PANEL_BOOT_MESSAGE An empty message will only clear the display at driver init time. Any other printf()-formatted message is valid with newline and escape codes. +config ALTERA_A10SR_MONITOR + bool "Altera Arria10 System Resource Monitor" + depends on MFD_ALTERA_A10SR + help + This enables the System Resource monitor driver for the Altera + Arria10 DevKit. + source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 3198336..9f6e77a 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -43,6 +43,7 @@ obj-y += ti-st/ obj-y += lis3lv02d/ obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ +obj-$(CONFIG_ALTERA_A10SR_MONITOR) += altera-a10sr-monitor.o obj-$(CONFIG_INTEL_MEI) += mei/ obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o diff --git a/drivers/misc/altera-a10sr-monitor.c b/drivers/misc/altera-a10sr-monitor.c new file mode 100644 index 0000000..66338e0 --- /dev/null +++ b/drivers/misc/altera-a10sr-monitor.c @@ -0,0 +1,175 @@ +/* + * Altera Arria10 DevKit System Resource Chip Monitor Driver + * + * Author: Thor Thayer <tthayer@opensource.altera.com> + * + * Copyright Intel Corporation (C) 2014-2016. All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see <http://www.gnu.org/licenses/>. + * + * Monitor driver for the Altera Arria10 MAX5 System Resource Chip + * Adapted from ics932s401.c + */ + +#include <linux/err.h> +#include <linux/mfd/altera-a10sr.h> +#include <linux/init.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +struct altr_a10sr_regs { + struct regmap *regmap; + struct attribute_group attr_grp; +}; + +static ssize_t a10sr_show(struct device *dev, + struct device_attribute *devattr, char *buf); +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count); + +/* Define FS entries */ +static DEVICE_ATTR(max5_version, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_led, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_button, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_button_irq, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pg1, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg2, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg3, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_fmcab, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_hps_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_per_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpa, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpb, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_i2c_master, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst_key, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pmbus, 0644, a10sr_show, a10sr_store); + +static struct attribute *altr_a10sr_attr[] = { + &dev_attr_max5_version.attr, + &dev_attr_max5_led.attr, + &dev_attr_max5_button.attr, + &dev_attr_max5_button_irq.attr, + &dev_attr_max5_pg1.attr, + &dev_attr_max5_pg2.attr, + &dev_attr_max5_pg3.attr, + &dev_attr_max5_fmcab.attr, + &dev_attr_max5_hps_resets.attr, + &dev_attr_max5_per_resets.attr, + &dev_attr_max5_sfpa.attr, + &dev_attr_max5_sfpb.attr, + &dev_attr_max5_i2c_master.attr, + &dev_attr_max5_wm_rst.attr, + &dev_attr_max5_wm_rst_key.attr, + &dev_attr_max5_pmbus.attr, + NULL +}; + +static const struct attribute_group a10sr_attr_group = { + .attrs = altr_a10sr_attr, +}; + +static ssize_t a10sr_show(struct device *dev, struct device_attribute *devattr, + char *buf) +{ + int i, ret; + unsigned int val; + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit set by regmap for Read */ + i <<= 1; + ret = regmap_read(a10sr_regs->regmap, i, &val); + if (ret < 0) + return ret; + + return sprintf(buf, "0x%X\n", val); +} + +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count) +{ + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + unsigned long val; + int i, ret; + + ret = kstrtol(buf, 0, &val); + if (ret < 0) + return ret; + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit cleared by regmap for Write */ + i <<= 1; + ret = regmap_write(a10sr_regs->regmap, i, val); + if (ret < 0) + return ret; + + return count; +} + +static int altr_a10sr_regs_probe(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs; + struct altr_a10sr *a10sr = dev_get_drvdata(pdev->dev.parent); + + a10regs = devm_kzalloc(&pdev->dev, sizeof(*a10regs), GFP_KERNEL); + if (!a10regs) + return -ENOMEM; + + a10regs->regmap = a10sr->regmap; + a10regs->attr_grp = a10sr_attr_group; + + platform_set_drvdata(pdev, a10regs); + + return sysfs_create_group(&pdev->dev.kobj, &a10sr_attr_group); +} + +static int altr_a10sr_regs_remove(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs = platform_get_drvdata(pdev); + + sysfs_remove_group(&pdev->dev.kobj, &a10regs->attr_grp); + + return 0; +} + +static const struct of_device_id altr_a10sr_regs_of_match[] = { + { .compatible = "altr,a10sr-monitor" }, + { }, +}; + +static struct platform_driver altr_a10sr_regs_driver = { + .probe = altr_a10sr_regs_probe, + .remove = altr_a10sr_regs_remove, + .driver = { + .name = "a10sr_monitor", + .of_match_table = altr_a10sr_regs_of_match, + }, +}; + +builtin_platform_driver(altr_a10sr_regs_driver); -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 2/4] misc: Add Altera Arria10 System Resource Control @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, linux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thor Thayer From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> This patch adds the Altera Arria10 control & monitoring functions to the Arria10 System Resource chip. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- v2 Change compatible string and filename from -mon to -monitor Change CONFIG from module to builtin. Make wm_rst register writeable. v3 Remove unused ret variable. Shorten driver name (remove altr_). --- MAINTAINERS | 1 + drivers/misc/Kconfig | 7 ++ drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-monitor.c | 175 ++++++++++++++++++++++++++++++++++++ 4 files changed, 184 insertions(+) create mode 100644 drivers/misc/altera-a10sr-monitor.c diff --git a/MAINTAINERS b/MAINTAINERS index b180821..baf2404 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -635,6 +635,7 @@ M: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> S: Maintained F: drivers/gpio/gpio-altera-a10sr.c F: drivers/mfd/altera-a10sr.c +F: drivers/misc/altera-a10sr-monitor.c F: include/linux/mfd/altera-a10sr.h ALTERA TRIPLE SPEED ETHERNET DRIVER diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 64971ba..f42d459 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -766,6 +766,13 @@ config PANEL_BOOT_MESSAGE An empty message will only clear the display at driver init time. Any other printf()-formatted message is valid with newline and escape codes. +config ALTERA_A10SR_MONITOR + bool "Altera Arria10 System Resource Monitor" + depends on MFD_ALTERA_A10SR + help + This enables the System Resource monitor driver for the Altera + Arria10 DevKit. + source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 3198336..9f6e77a 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -43,6 +43,7 @@ obj-y += ti-st/ obj-y += lis3lv02d/ obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ +obj-$(CONFIG_ALTERA_A10SR_MONITOR) += altera-a10sr-monitor.o obj-$(CONFIG_INTEL_MEI) += mei/ obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o diff --git a/drivers/misc/altera-a10sr-monitor.c b/drivers/misc/altera-a10sr-monitor.c new file mode 100644 index 0000000..66338e0 --- /dev/null +++ b/drivers/misc/altera-a10sr-monitor.c @@ -0,0 +1,175 @@ +/* + * Altera Arria10 DevKit System Resource Chip Monitor Driver + * + * Author: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> + * + * Copyright Intel Corporation (C) 2014-2016. All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see <http://www.gnu.org/licenses/>. + * + * Monitor driver for the Altera Arria10 MAX5 System Resource Chip + * Adapted from ics932s401.c + */ + +#include <linux/err.h> +#include <linux/mfd/altera-a10sr.h> +#include <linux/init.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +struct altr_a10sr_regs { + struct regmap *regmap; + struct attribute_group attr_grp; +}; + +static ssize_t a10sr_show(struct device *dev, + struct device_attribute *devattr, char *buf); +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count); + +/* Define FS entries */ +static DEVICE_ATTR(max5_version, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_led, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_button, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_button_irq, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pg1, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg2, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg3, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_fmcab, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_hps_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_per_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpa, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpb, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_i2c_master, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst_key, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pmbus, 0644, a10sr_show, a10sr_store); + +static struct attribute *altr_a10sr_attr[] = { + &dev_attr_max5_version.attr, + &dev_attr_max5_led.attr, + &dev_attr_max5_button.attr, + &dev_attr_max5_button_irq.attr, + &dev_attr_max5_pg1.attr, + &dev_attr_max5_pg2.attr, + &dev_attr_max5_pg3.attr, + &dev_attr_max5_fmcab.attr, + &dev_attr_max5_hps_resets.attr, + &dev_attr_max5_per_resets.attr, + &dev_attr_max5_sfpa.attr, + &dev_attr_max5_sfpb.attr, + &dev_attr_max5_i2c_master.attr, + &dev_attr_max5_wm_rst.attr, + &dev_attr_max5_wm_rst_key.attr, + &dev_attr_max5_pmbus.attr, + NULL +}; + +static const struct attribute_group a10sr_attr_group = { + .attrs = altr_a10sr_attr, +}; + +static ssize_t a10sr_show(struct device *dev, struct device_attribute *devattr, + char *buf) +{ + int i, ret; + unsigned int val; + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit set by regmap for Read */ + i <<= 1; + ret = regmap_read(a10sr_regs->regmap, i, &val); + if (ret < 0) + return ret; + + return sprintf(buf, "0x%X\n", val); +} + +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count) +{ + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + unsigned long val; + int i, ret; + + ret = kstrtol(buf, 0, &val); + if (ret < 0) + return ret; + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit cleared by regmap for Write */ + i <<= 1; + ret = regmap_write(a10sr_regs->regmap, i, val); + if (ret < 0) + return ret; + + return count; +} + +static int altr_a10sr_regs_probe(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs; + struct altr_a10sr *a10sr = dev_get_drvdata(pdev->dev.parent); + + a10regs = devm_kzalloc(&pdev->dev, sizeof(*a10regs), GFP_KERNEL); + if (!a10regs) + return -ENOMEM; + + a10regs->regmap = a10sr->regmap; + a10regs->attr_grp = a10sr_attr_group; + + platform_set_drvdata(pdev, a10regs); + + return sysfs_create_group(&pdev->dev.kobj, &a10sr_attr_group); +} + +static int altr_a10sr_regs_remove(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs = platform_get_drvdata(pdev); + + sysfs_remove_group(&pdev->dev.kobj, &a10regs->attr_grp); + + return 0; +} + +static const struct of_device_id altr_a10sr_regs_of_match[] = { + { .compatible = "altr,a10sr-monitor" }, + { }, +}; + +static struct platform_driver altr_a10sr_regs_driver = { + .probe = altr_a10sr_regs_probe, + .remove = altr_a10sr_regs_remove, + .driver = { + .name = "a10sr_monitor", + .of_match_table = altr_a10sr_regs_of_match, + }, +}; + +builtin_platform_driver(altr_a10sr_regs_driver); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCHv3 2/4] misc: Add Altera Arria10 System Resource Control 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-11-10 14:33 ` Greg KH -1 siblings, 0 replies; 25+ messages in thread From: Greg KH @ 2016-11-10 14:33 UTC (permalink / raw) To: tthayer Cc: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, davem, geert, devicetree, linux-kernel, linux-arm-kernel On Wed, Nov 02, 2016 at 09:32:56AM -0500, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > This patch adds the Altera Arria10 control & monitoring > functions to the Arria10 System Resource chip. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > v2 Change compatible string and filename from -mon to -monitor > Change CONFIG from module to builtin. > Make wm_rst register writeable. > v3 Remove unused ret variable. > Shorten driver name (remove altr_). > --- > MAINTAINERS | 1 + > drivers/misc/Kconfig | 7 ++ > drivers/misc/Makefile | 1 + > drivers/misc/altera-a10sr-monitor.c | 175 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 184 insertions(+) > create mode 100644 drivers/misc/altera-a10sr-monitor.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index b180821..baf2404 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -635,6 +635,7 @@ M: Thor Thayer <tthayer@opensource.altera.com> > S: Maintained > F: drivers/gpio/gpio-altera-a10sr.c > F: drivers/mfd/altera-a10sr.c > +F: drivers/misc/altera-a10sr-monitor.c > F: include/linux/mfd/altera-a10sr.h > > ALTERA TRIPLE SPEED ETHERNET DRIVER > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 64971ba..f42d459 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -766,6 +766,13 @@ config PANEL_BOOT_MESSAGE > An empty message will only clear the display at driver init time. Any other > printf()-formatted message is valid with newline and escape codes. > > +config ALTERA_A10SR_MONITOR > + bool "Altera Arria10 System Resource Monitor" > + depends on MFD_ALTERA_A10SR > + help > + This enables the System Resource monitor driver for the Altera > + Arria10 DevKit. > + > source "drivers/misc/c2port/Kconfig" > source "drivers/misc/eeprom/Kconfig" > source "drivers/misc/cb710/Kconfig" > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index 3198336..9f6e77a 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -43,6 +43,7 @@ obj-y += ti-st/ > obj-y += lis3lv02d/ > obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o > obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ > +obj-$(CONFIG_ALTERA_A10SR_MONITOR) += altera-a10sr-monitor.o > obj-$(CONFIG_INTEL_MEI) += mei/ > obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ > obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o > diff --git a/drivers/misc/altera-a10sr-monitor.c b/drivers/misc/altera-a10sr-monitor.c > new file mode 100644 > index 0000000..66338e0 > --- /dev/null > +++ b/drivers/misc/altera-a10sr-monitor.c > @@ -0,0 +1,175 @@ > +/* > + * Altera Arria10 DevKit System Resource Chip Monitor Driver > + * > + * Author: Thor Thayer <tthayer@opensource.altera.com> > + * > + * Copyright Intel Corporation (C) 2014-2016. All Rights Reserved > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program. If not, see <http://www.gnu.org/licenses/>. > + * > + * Monitor driver for the Altera Arria10 MAX5 System Resource Chip > + * Adapted from ics932s401.c > + */ > + > +#include <linux/err.h> > +#include <linux/mfd/altera-a10sr.h> > +#include <linux/init.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > + > +struct altr_a10sr_regs { > + struct regmap *regmap; > + struct attribute_group attr_grp; > +}; > + > +static ssize_t a10sr_show(struct device *dev, > + struct device_attribute *devattr, char *buf); > +static ssize_t a10sr_store(struct device *dev, > + struct device_attribute *devattr, const char *buf, > + size_t count); > + > +/* Define FS entries */ > +static DEVICE_ATTR(max5_version, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_led, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_button, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_button_irq, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_pg1, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_pg2, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_pg3, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_fmcab, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_hps_resets, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_per_resets, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_sfpa, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_sfpb, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_i2c_master, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_wm_rst, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_wm_rst_key, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_pmbus, 0644, a10sr_show, a10sr_store); Please add a Documentation/ABI file to describe all of thes new sysfs files that you are saying will be present for all of time. And do you really want userspace access like this to these values? Shouldn't things like the led and button use the proper led and input layers instead? > +static int altr_a10sr_regs_probe(struct platform_device *pdev) > +{ > + struct altr_a10sr_regs *a10regs; > + struct altr_a10sr *a10sr = dev_get_drvdata(pdev->dev.parent); > + > + a10regs = devm_kzalloc(&pdev->dev, sizeof(*a10regs), GFP_KERNEL); > + if (!a10regs) > + return -ENOMEM; > + > + a10regs->regmap = a10sr->regmap; > + a10regs->attr_grp = a10sr_attr_group; > + > + platform_set_drvdata(pdev, a10regs); > + > + return sysfs_create_group(&pdev->dev.kobj, &a10sr_attr_group); You just raced userspace and lost :( Please set the group file properly, and then the driver core should set this up for you correctly. thanks, greg k-h ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 2/4] misc: Add Altera Arria10 System Resource Control @ 2016-11-10 14:33 ` Greg KH 0 siblings, 0 replies; 25+ messages in thread From: Greg KH @ 2016-11-10 14:33 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 02, 2016 at 09:32:56AM -0500, tthayer at opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > This patch adds the Altera Arria10 control & monitoring > functions to the Arria10 System Resource chip. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > v2 Change compatible string and filename from -mon to -monitor > Change CONFIG from module to builtin. > Make wm_rst register writeable. > v3 Remove unused ret variable. > Shorten driver name (remove altr_). > --- > MAINTAINERS | 1 + > drivers/misc/Kconfig | 7 ++ > drivers/misc/Makefile | 1 + > drivers/misc/altera-a10sr-monitor.c | 175 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 184 insertions(+) > create mode 100644 drivers/misc/altera-a10sr-monitor.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index b180821..baf2404 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -635,6 +635,7 @@ M: Thor Thayer <tthayer@opensource.altera.com> > S: Maintained > F: drivers/gpio/gpio-altera-a10sr.c > F: drivers/mfd/altera-a10sr.c > +F: drivers/misc/altera-a10sr-monitor.c > F: include/linux/mfd/altera-a10sr.h > > ALTERA TRIPLE SPEED ETHERNET DRIVER > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 64971ba..f42d459 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -766,6 +766,13 @@ config PANEL_BOOT_MESSAGE > An empty message will only clear the display at driver init time. Any other > printf()-formatted message is valid with newline and escape codes. > > +config ALTERA_A10SR_MONITOR > + bool "Altera Arria10 System Resource Monitor" > + depends on MFD_ALTERA_A10SR > + help > + This enables the System Resource monitor driver for the Altera > + Arria10 DevKit. > + > source "drivers/misc/c2port/Kconfig" > source "drivers/misc/eeprom/Kconfig" > source "drivers/misc/cb710/Kconfig" > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index 3198336..9f6e77a 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -43,6 +43,7 @@ obj-y += ti-st/ > obj-y += lis3lv02d/ > obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o > obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ > +obj-$(CONFIG_ALTERA_A10SR_MONITOR) += altera-a10sr-monitor.o > obj-$(CONFIG_INTEL_MEI) += mei/ > obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ > obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o > diff --git a/drivers/misc/altera-a10sr-monitor.c b/drivers/misc/altera-a10sr-monitor.c > new file mode 100644 > index 0000000..66338e0 > --- /dev/null > +++ b/drivers/misc/altera-a10sr-monitor.c > @@ -0,0 +1,175 @@ > +/* > + * Altera Arria10 DevKit System Resource Chip Monitor Driver > + * > + * Author: Thor Thayer <tthayer@opensource.altera.com> > + * > + * Copyright Intel Corporation (C) 2014-2016. All Rights Reserved > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program. If not, see <http://www.gnu.org/licenses/>. > + * > + * Monitor driver for the Altera Arria10 MAX5 System Resource Chip > + * Adapted from ics932s401.c > + */ > + > +#include <linux/err.h> > +#include <linux/mfd/altera-a10sr.h> > +#include <linux/init.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > + > +struct altr_a10sr_regs { > + struct regmap *regmap; > + struct attribute_group attr_grp; > +}; > + > +static ssize_t a10sr_show(struct device *dev, > + struct device_attribute *devattr, char *buf); > +static ssize_t a10sr_store(struct device *dev, > + struct device_attribute *devattr, const char *buf, > + size_t count); > + > +/* Define FS entries */ > +static DEVICE_ATTR(max5_version, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_led, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_button, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_button_irq, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_pg1, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_pg2, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_pg3, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_fmcab, 0444, a10sr_show, NULL); > +static DEVICE_ATTR(max5_hps_resets, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_per_resets, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_sfpa, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_sfpb, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_i2c_master, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_wm_rst, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_wm_rst_key, 0644, a10sr_show, a10sr_store); > +static DEVICE_ATTR(max5_pmbus, 0644, a10sr_show, a10sr_store); Please add a Documentation/ABI file to describe all of thes new sysfs files that you are saying will be present for all of time. And do you really want userspace access like this to these values? Shouldn't things like the led and button use the proper led and input layers instead? > +static int altr_a10sr_regs_probe(struct platform_device *pdev) > +{ > + struct altr_a10sr_regs *a10regs; > + struct altr_a10sr *a10sr = dev_get_drvdata(pdev->dev.parent); > + > + a10regs = devm_kzalloc(&pdev->dev, sizeof(*a10regs), GFP_KERNEL); > + if (!a10regs) > + return -ENOMEM; > + > + a10regs->regmap = a10sr->regmap; > + a10regs->attr_grp = a10sr_attr_group; > + > + platform_set_drvdata(pdev, a10regs); > + > + return sysfs_create_group(&pdev->dev.kobj, &a10sr_attr_group); You just raced userspace and lost :( Please set the group file properly, and then the driver core should set this up for you correctly. thanks, greg k-h ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor 2016-11-02 14:32 ` tthayer (?) @ 2016-11-02 14:32 ` tthayer -1 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> Add the Altera Arria10 DevKit System Resource Monitor functionality to the MFD device. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> --- v2 Change from -mon to -monitor for clarity v3 Shorten driver name (remove altr_). --- drivers/mfd/altera-a10sr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c index 06e1f7f..2ddf235 100644 --- a/drivers/mfd/altera-a10sr.c +++ b/drivers/mfd/altera-a10sr.c @@ -30,9 +30,13 @@ static const struct mfd_cell altr_a10sr_subdev_info[] = { { - .name = "altr_a10sr_gpio", + .name = "a10sr_gpio", .of_compatible = "altr,a10sr-gpio", }, + { + .name = "a10sr_monitor", + .of_compatible = "altr,a10sr-monitor", + }, }; static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor @ 2016-11-02 14:32 ` tthayer 0 siblings, 0 replies; 25+ messages in thread From: tthayer at opensource.altera.com @ 2016-11-02 14:32 UTC (permalink / raw) To: linux-arm-kernel From: Thor Thayer <tthayer@opensource.altera.com> Add the Altera Arria10 DevKit System Resource Monitor functionality to the MFD device. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> --- v2 Change from -mon to -monitor for clarity v3 Shorten driver name (remove altr_). --- drivers/mfd/altera-a10sr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c index 06e1f7f..2ddf235 100644 --- a/drivers/mfd/altera-a10sr.c +++ b/drivers/mfd/altera-a10sr.c @@ -30,9 +30,13 @@ static const struct mfd_cell altr_a10sr_subdev_info[] = { { - .name = "altr_a10sr_gpio", + .name = "a10sr_gpio", .of_compatible = "altr,a10sr-gpio", }, + { + .name = "a10sr_monitor", + .of_compatible = "altr,a10sr-monitor", + }, }; static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor @ 2016-11-02 14:32 ` tthayer 0 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> Add the Altera Arria10 DevKit System Resource Monitor functionality to the MFD device. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> --- v2 Change from -mon to -monitor for clarity v3 Shorten driver name (remove altr_). --- drivers/mfd/altera-a10sr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c index 06e1f7f..2ddf235 100644 --- a/drivers/mfd/altera-a10sr.c +++ b/drivers/mfd/altera-a10sr.c @@ -30,9 +30,13 @@ static const struct mfd_cell altr_a10sr_subdev_info[] = { { - .name = "altr_a10sr_gpio", + .name = "a10sr_gpio", .of_compatible = "altr,a10sr-gpio", }, + { + .name = "a10sr_monitor", + .of_compatible = "altr,a10sr-monitor", + }, }; static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> Add the Monitor functionality to the Arria10 DevKit System Resource chip. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- v2 Change from -mon to -monitor for clarity. v3 Change node name from a10_monitor to monitor. --- arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi index eb00ae3..996e745 100644 --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi @@ -121,6 +121,10 @@ gpio-controller; #gpio-cells = <2>; }; + + monitor { + compatible = "altr,a10sr-monitor"; + }; }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer at opensource.altera.com @ 2016-11-02 14:32 UTC (permalink / raw) To: linux-arm-kernel From: Thor Thayer <tthayer@opensource.altera.com> Add the Monitor functionality to the Arria10 DevKit System Resource chip. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- v2 Change from -mon to -monitor for clarity. v3 Change node name from a10_monitor to monitor. --- arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi index eb00ae3..996e745 100644 --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi @@ -121,6 +121,10 @@ gpio-controller; #gpio-cells = <2>; }; + + monitor { + compatible = "altr,a10sr-monitor"; + }; }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD @ 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 25+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-11-02 14:32 UTC (permalink / raw) To: lee.jones-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, linux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thor Thayer From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Add the Monitor functionality to the Arria10 DevKit System Resource chip. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- v2 Change from -mon to -monitor for clarity. v3 Change node name from a10_monitor to monitor. --- arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi index eb00ae3..996e745 100644 --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi @@ -121,6 +121,10 @@ gpio-controller; #gpio-cells = <2>; }; + + monitor { + compatible = "altr,a10sr-monitor"; + }; }; }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx (?) @ 2016-11-03 19:49 ` Dinh Nguyen -1 siblings, 0 replies; 25+ messages in thread From: Dinh Nguyen @ 2016-11-03 19:49 UTC (permalink / raw) To: tthayer, lee.jones, robh+dt, mark.rutland, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel On 11/02/2016 09:32 AM, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Monitor functionality to the Arria10 DevKit > System Resource chip. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > v2 Change from -mon to -monitor for clarity. > v3 Change node name from a10_monitor to monitor. > --- > arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > index eb00ae3..996e745 100644 > --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > @@ -121,6 +121,10 @@ > gpio-controller; > #gpio-cells = <2>; > }; > + > + monitor { > + compatible = "altr,a10sr-monitor"; > + }; > }; > }; > > Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com> ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD @ 2016-11-03 19:49 ` Dinh Nguyen 0 siblings, 0 replies; 25+ messages in thread From: Dinh Nguyen @ 2016-11-03 19:49 UTC (permalink / raw) To: linux-arm-kernel On 11/02/2016 09:32 AM, tthayer at opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Monitor functionality to the Arria10 DevKit > System Resource chip. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > v2 Change from -mon to -monitor for clarity. > v3 Change node name from a10_monitor to monitor. > --- > arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > index eb00ae3..996e745 100644 > --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > @@ -121,6 +121,10 @@ > gpio-controller; > #gpio-cells = <2>; > }; > + > + monitor { > + compatible = "altr,a10sr-monitor"; > + }; > }; > }; > > Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com> ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD @ 2016-11-03 19:49 ` Dinh Nguyen 0 siblings, 0 replies; 25+ messages in thread From: Dinh Nguyen @ 2016-11-03 19:49 UTC (permalink / raw) To: tthayer, lee.jones, robh+dt, mark.rutland, linux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel On 11/02/2016 09:32 AM, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Monitor functionality to the Arria10 DevKit > System Resource chip. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > v2 Change from -mon to -monitor for clarity. > v3 Change node name from a10_monitor to monitor. > --- > arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > index eb00ae3..996e745 100644 > --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi > @@ -121,6 +121,10 @@ > gpio-controller; > #gpio-cells = <2>; > }; > + > + monitor { > + compatible = "altr,a10sr-monitor"; > + }; > }; > }; > > Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com> ^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2016-11-10 14:33 UTC | newest] Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-11-02 14:32 [PATCHv3 0/4] Add Altera A10SR Status & Control Monitor tthayer 2016-11-02 14:32 ` tthayer at opensource.altera.com 2016-11-02 14:32 ` tthayer 2016-11-02 14:32 ` [PATCHv3 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor tthayer 2016-11-02 14:32 ` tthayer at opensource.altera.com 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-11-03 14:39 ` Lee Jones 2016-11-03 14:39 ` Lee Jones 2016-11-09 18:26 ` Rob Herring 2016-11-09 18:26 ` Rob Herring 2016-11-09 18:26 ` Rob Herring 2016-11-02 14:32 ` [PATCHv3 2/4] misc: Add Altera Arria10 System Resource Control tthayer 2016-11-02 14:32 ` tthayer at opensource.altera.com 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-11-10 14:33 ` Greg KH 2016-11-10 14:33 ` Greg KH 2016-11-02 14:32 ` [PATCHv3 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor tthayer 2016-11-02 14:32 ` tthayer at opensource.altera.com 2016-11-02 14:32 ` tthayer 2016-11-02 14:32 ` [PATCHv3 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD tthayer 2016-11-02 14:32 ` tthayer at opensource.altera.com 2016-11-02 14:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-11-03 19:49 ` Dinh Nguyen 2016-11-03 19:49 ` Dinh Nguyen 2016-11-03 19:49 ` Dinh Nguyen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.