All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings" has been added to the 4.8-stable tree
@ 2016-11-06 11:56 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-11-06 11:56 UTC (permalink / raw)
  To: david.wu, andy.yan, dianders, gregkh, wsa; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings

to the 4.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     i2c-rk3x-give-the-tuning-value-0-during-rk3x_i2c_v0_calc_timings.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 399c168ab5ab5e12ed55b6c91d61c24eb84c9164 Mon Sep 17 00:00:00 2001
From: David Wu <david.wu@rock-chips.com>
Date: Sat, 22 Oct 2016 16:43:42 +0800
Subject: i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings

From: David Wu <david.wu@rock-chips.com>

commit 399c168ab5ab5e12ed55b6c91d61c24eb84c9164 upstream.

We found a bug that i2c transfer sometimes failed on 3066a board with
stabel-4.8, the con register would be updated by uninitialized tuning
value, it made the i2c transfer failed.

So give the tuning value to be zero during rk3x_i2c_v0_calc_timings.

Signed-off-by: David Wu <david.wu@rock-chips.com>
Tested-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/i2c/busses/i2c-rk3x.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -694,6 +694,8 @@ static int rk3x_i2c_v0_calc_timings(unsi
 	t_calc->div_low--;
 	t_calc->div_high--;
 
+	/* Give the tuning value 0, that would not update con register */
+	t_calc->tuning = 0;
 	/* Maximum divider supported by hw is 0xffff */
 	if (t_calc->div_low > 0xffff) {
 		t_calc->div_low = 0xffff;


Patches currently in stable-queue which might be from david.wu@rock-chips.com are

queue-4.8/i2c-rk3x-give-the-tuning-value-0-during-rk3x_i2c_v0_calc_timings.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-06 11:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-06 11:56 Patch "i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings" has been added to the 4.8-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.