All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL v2 12/34] intel_iommu: fix incorrect assert
Date: Fri, 11 Nov 2016 20:10:41 +0200	[thread overview]
Message-ID: <1478887767-31980-13-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1478887767-31980-1-git-send-email-mst@redhat.com>

From: Peter Xu <peterx@redhat.com>

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/i386/intel_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 20c4d2c..1b706ad 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2463,7 +2463,7 @@ static AddressSpace *vtd_host_dma_iommu(PCIBus *bus, void *opaque, int devfn)
     IntelIOMMUState *s = opaque;
     VTDAddressSpace *vtd_as;
 
-    assert(0 <= devfn && devfn <= X86_IOMMU_PCI_DEVFN_MAX);
+    assert(0 <= devfn && devfn < X86_IOMMU_PCI_DEVFN_MAX);
 
     vtd_as = vtd_find_add_as(s, bus, devfn);
     return &vtd_as->as;
-- 
MST

  parent reply	other threads:[~2016-11-11 18:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 18:09 [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 01/34] tests/vhost-user-bridge: remove false comment Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 02/34] tests/vhost-user-bridge: remove unnecessary dispatcher_remove Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 03/34] tests/vhost-user-bridge: indicate peer disconnected Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 04/34] tests/vhost-user-bridge: do not accept more than one connection Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 05/34] contrib: add libvhost-user Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 06/34] tests/vhost-user-bridge: use contrib/libvhost-user Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 07/34] intel_iommu: fixing source id during IOTLB hash key calculation Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 08/34] virtio: rename virtqueue_discard to virtqueue_unpop Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 09/34] virtio: make virtqueue_alloc_element static Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 10/34] virtio-crypto: tag as not hotpluggable and migration Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 11/34] intel_iommu: fix several incorrect endianess and bit fields Michael S. Tsirkin
2016-11-11 18:10 ` Michael S. Tsirkin [this message]
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 13/34] acpi: fix DMAR device scope for IOAPIC Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 14/34] virtio: allow per-device-class legacy features Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 15/34] virtio-net: mark VIRTIO_NET_F_GSO as legacy Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 16/34] vhost: migration blocker only if shared log is used Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 17/34] qdev: hotplug: drop HotplugHandler.post_plug callback Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 18/34] nvdimm acpi: drop the lock of fit buffer Michael S. Tsirkin
2016-11-11 18:10 ` [Qemu-devel] [PULL v2 19/34] pc: memhp: move nvdimm hotplug out of memory hotplug Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 20/34] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 21/34] nvdimm acpi: clean up nvdimm_build_acpi Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 22/34] docs: improve the doc of Read FIT method Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 23/34] nvdimm acpi: rename nvdimm_plugged_device_list Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 24/34] nvdimm acpi: cleanup nvdimm_build_fit Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 25/34] nvdimm acpi: rename nvdimm_acpi_hotplug Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 26/34] nvdimm acpi: define DSM return codes Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 27/34] nvdimm acpi: fix two comments Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 28/34] nvdimm acpi: rename nvdimm_dsm_reserved_root Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 29/34] nvdimm acpi: use aml_name_decl to define named object Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 30/34] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 31/34] vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 32/34] vhost: drop legacy vring layout bits Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 33/34] virtio: drop virtio_queue_get_ring_{size, addr}() Michael S. Tsirkin
2016-11-11 18:11 ` [Qemu-devel] [PULL v2 34/34] docs: add PCIe devices placement guidelines Michael S. Tsirkin
2016-11-14 15:52 ` [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups Stefan Hajnoczi
2016-11-14 23:19   ` Michael S. Tsirkin
2016-11-15 10:56     ` Stefan Hajnoczi
2016-11-17 14:16 ` no-reply
2016-11-17 16:44   ` Michael S. Tsirkin
2016-11-17 17:04     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478887767-31980-13-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.