Re: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
Type: series
Message-id: 1478887767-31980-1-git-send-email-mst@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
45f34d2 docs: add PCIe devices placement guidelines
df1e6a9 virtio: drop virtio_queue_get_ring_{size, addr}()
eb0df16 vhost: drop legacy vring layout bits
818af64 vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout
308b194 nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE
5ac8f61 nvdimm acpi: use aml_name_decl to define named object
b603da1 nvdimm acpi: rename nvdimm_dsm_reserved_root
7ce6581 nvdimm acpi: fix two comments
d99e1c8 nvdimm acpi: define DSM return codes
ef66dc6 nvdimm acpi: rename nvdimm_acpi_hotplug
09f6d99 nvdimm acpi: cleanup nvdimm_build_fit
c0a7b88 nvdimm acpi: rename nvdimm_plugged_device_list
814cf09 docs: improve the doc of Read FIT method
bfeb57f nvdimm acpi: clean up nvdimm_build_acpi
68edcd7 pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug
5263390 pc: memhp: move nvdimm hotplug out of memory hotplug
e7941d1 nvdimm acpi: drop the lock of fit buffer
32f27c8 qdev: hotplug: drop HotplugHandler.post_plug callback
1e6d47a vhost: migration blocker only if shared log is used
1420f16 virtio-net: mark VIRTIO_NET_F_GSO as legacy
b7f1187 virtio: allow per-device-class legacy features
618ddad acpi: fix DMAR device scope for IOAPIC
9a7a369 intel_iommu: fix incorrect assert
5afe773 intel_iommu: fix several incorrect endianess and bit fields
3996250 virtio-crypto: tag as not hotpluggable and migration
5fef2e2 virtio: make virtqueue_alloc_element static
729797a virtio: rename virtqueue_discard to virtqueue_unpop
02b2113 intel_iommu: fixing source id during IOTLB hash key calculation
19767b7 tests/vhost-user-bridge: use contrib/libvhost-user
c191724 contrib: add libvhost-user
fb24b50 tests/vhost-user-bridge: do not accept more than one connection
4669d69 tests/vhost-user-bridge: indicate peer disconnected
437db77 tests/vhost-user-bridge: remove unnecessary dispatcher_remove
5cb40ef tests/vhost-user-bridge: remove false comment

=== OUTPUT BEGIN ===
Checking PATCH 1/34: tests/vhost-user-bridge: remove false comment...
Checking PATCH 2/34: tests/vhost-user-bridge: remove unnecessary dispatcher_remove...
Checking PATCH 3/34: tests/vhost-user-bridge: indicate peer disconnected...
Checking PATCH 4/34: tests/vhost-user-bridge: do not accept more than one connection...
Checking PATCH 5/34: contrib: add libvhost-user...
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#75: FILE: contrib/libvhost-user/libvhost-user.c:9:
+ *  Marc-Andr Lureau <mlureau@redhat.com>
              ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#1579: FILE: contrib/libvhost-user/libvhost-user.h:8:
+ *  Marc-Andr Lureau <mlureau@redhat.com>
              ^

total: 2 errors, 0 warnings, 1950 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/34: tests/vhost-user-bridge: use contrib/libvhost-user...
Checking PATCH 7/34: intel_iommu: fixing source id during IOTLB hash key calculation...
Checking PATCH 8/34: virtio: rename virtqueue_discard to virtqueue_unpop...
Checking PATCH 9/34: virtio: make virtqueue_alloc_element static...
WARNING: line over 80 characters
#24: FILE: hw/virtio/virtio.c:635:
+static void *virtqueue_alloc_element(size_t sz, unsigned out_num, unsigned in_num)

total: 0 errors, 1 warnings, 15 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/34: virtio-crypto: tag as not hotpluggable and migration...
Checking PATCH 11/34: intel_iommu: fix several incorrect endianess and bit fields...
Checking PATCH 12/34: intel_iommu: fix incorrect assert...
Checking PATCH 13/34: acpi: fix DMAR device scope for IOAPIC...
Checking PATCH 14/34: virtio: allow per-device-class legacy features...
Checking PATCH 15/34: virtio-net: mark VIRTIO_NET_F_GSO as legacy...
Checking PATCH 16/34: vhost: migration blocker only if shared log is used...
Checking PATCH 17/34: qdev: hotplug: drop HotplugHandler.post_plug callback...
Checking PATCH 18/34: nvdimm acpi: drop the lock of fit buffer...
Checking PATCH 19/34: pc: memhp: move nvdimm hotplug out of memory hotplug...
Checking PATCH 20/34: pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug...
Checking PATCH 21/34: nvdimm acpi: clean up nvdimm_build_acpi...
Checking PATCH 22/34: docs: improve the doc of Read FIT method...
Checking PATCH 23/34: nvdimm acpi: rename nvdimm_plugged_device_list...
Checking PATCH 24/34: nvdimm acpi: cleanup nvdimm_build_fit...
Checking PATCH 25/34: nvdimm acpi: rename nvdimm_acpi_hotplug...
Checking PATCH 26/34: nvdimm acpi: define DSM return codes...
Checking PATCH 27/34: nvdimm acpi: fix two comments...
Checking PATCH 28/34: nvdimm acpi: rename nvdimm_dsm_reserved_root...
Checking PATCH 29/34: nvdimm acpi: use aml_name_decl to define named object...
Checking PATCH 30/34: nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE...
Checking PATCH 31/34: vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout...
Checking PATCH 32/34: vhost: drop legacy vring layout bits...
Checking PATCH 33/34: virtio: drop virtio_queue_get_ring_{size, addr}()...
Checking PATCH 34/34: docs: add PCIe devices placement guidelines...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org