* [PATCH] sparc64: fix compile warning section mismatch in find_node()
@ 2016-11-12 0:41 Thomas Tai
2016-11-14 18:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Tai @ 2016-11-12 0:41 UTC (permalink / raw)
To: sparclinux
A compile warning is introduced by a commit to fix the find_node().
This patch fix the compile warning by moving find_node() into __init
section. Because find_node() is only used by memblock_nid_range() which
is only used by a __init add_node_ranges(). find_node() and
memblock_nid_range() should also be inside __init section.
Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
---
arch/sparc/mm/init_64.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index 068eb3d..37aa537 100644
--- a/arch/sparc/mm/init_64.c
+++ b/arch/sparc/mm/init_64.c
@@ -805,7 +805,7 @@ static int num_mblocks;
static int find_numa_node_for_addr(unsigned long pa,
struct node_mem_mask *pnode_mask);
-static unsigned long ra_to_pa(unsigned long addr)
+static unsigned long __init ra_to_pa(unsigned long addr)
{
int i;
@@ -821,7 +821,7 @@ static unsigned long ra_to_pa(unsigned long addr)
return addr;
}
-static int find_node(unsigned long addr)
+static int __init find_node(unsigned long addr)
{
static bool search_mdesc = true;
static struct node_mem_mask last_mem_mask = { ~0UL, ~0UL };
@@ -858,7 +858,7 @@ static int find_node(unsigned long addr)
return last_index;
}
-static u64 memblock_nid_range(u64 start, u64 end, int *nid)
+static u64 __init memblock_nid_range(u64 start, u64 end, int *nid)
{
*nid = find_node(start);
start += PAGE_SIZE;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sparc64: fix compile warning section mismatch in find_node()
2016-11-12 0:41 [PATCH] sparc64: fix compile warning section mismatch in find_node() Thomas Tai
@ 2016-11-14 18:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-14 18:40 UTC (permalink / raw)
To: sparclinux
From: Thomas Tai <thomas.tai@oracle.com>
Date: Fri, 11 Nov 2016 16:41:00 -0800
> A compile warning is introduced by a commit to fix the find_node().
> This patch fix the compile warning by moving find_node() into __init
> section. Because find_node() is only used by memblock_nid_range() which
> is only used by a __init add_node_ranges(). find_node() and
> memblock_nid_range() should also be inside __init section.
>
> Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-14 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-12 0:41 [PATCH] sparc64: fix compile warning section mismatch in find_node() Thomas Tai
2016-11-14 18:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.