All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: rmk+kernel@armlinux.org.uk, arnd@arndb.de, horms@verge.net.au,
	magnus.damm@gmail.com, geert+renesas@glider.be,
	vireshk@kernel.org, shiraz.linux.kernel@gmail.com,
	krzk@kernel.org, thomas.ab@samsung.com,
	Pankaj Dubey <pankaj.dubey@samsung.com>,
	Russell King <linux@armlinux.org.uk>
Subject: [PATCH 04/16] ARM: realview: use generic API for enabling SCU
Date: Mon, 14 Nov 2016 10:31:59 +0530	[thread overview]
Message-ID: <1479099731-28108-5-git-send-email-pankaj.dubey@samsung.com> (raw)
In-Reply-To: <1479099731-28108-1-git-send-email-pankaj.dubey@samsung.com>

Now as we have of_scu_enable which takes care of mapping
scu base from DT, lets use it.

Also this patch removes computation of number of cores
from SCU, as for DT platform it will be taken care from
DT CPU device nodes.

CC: Russell King <linux@armlinux.org.uk>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm/mach-realview/platsmp-dt.c | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/arch/arm/mach-realview/platsmp-dt.c b/arch/arm/mach-realview/platsmp-dt.c
index 70ca99e..b2dbf77 100644
--- a/arch/arm/mach-realview/platsmp-dt.c
+++ b/arch/arm/mach-realview/platsmp-dt.c
@@ -23,8 +23,6 @@
 
 static const struct of_device_id realview_scu_match[] = {
 	{ .compatible = "arm,arm11mp-scu", },
-	{ .compatible = "arm,cortex-a9-scu", },
-	{ .compatible = "arm,cortex-a5-scu", },
 	{ }
 };
 
@@ -41,27 +39,18 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus)
 	struct device_node *np;
 	void __iomem *scu_base;
 	struct regmap *map;
-	unsigned int ncores;
 	int i;
 
-	np = of_find_matching_node(NULL, realview_scu_match);
-	if (!np) {
-		pr_err("PLATSMP: No SCU base address\n");
-		return;
+	if (of_scu_enable()) {
+		np = of_find_matching_node(NULL, realview_scu_match);
+		scu_base = of_iomap(np, 0);
+		of_node_put(np);
+		if (!scu_base) {
+			pr_err("PLATSMP: No SCU remap\n");
+			return;
+		}
+		scu_enable(scu_base);
 	}
-	scu_base = of_iomap(np, 0);
-	of_node_put(np);
-	if (!scu_base) {
-		pr_err("PLATSMP: No SCU remap\n");
-		return;
-	}
-
-	scu_enable(scu_base);
-	ncores = scu_get_core_count(scu_base);
-	pr_info("SCU: %d cores detected\n", ncores);
-	for (i = 0; i < ncores; i++)
-		set_cpu_possible(i, true);
-	iounmap(scu_base);
 
 	/* The syscon contains the magic SMP start address registers */
 	np = of_find_matching_node(NULL, realview_syscon_match);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: pankaj.dubey@samsung.com (Pankaj Dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/16] ARM: realview: use generic API for enabling SCU
Date: Mon, 14 Nov 2016 10:31:59 +0530	[thread overview]
Message-ID: <1479099731-28108-5-git-send-email-pankaj.dubey@samsung.com> (raw)
In-Reply-To: <1479099731-28108-1-git-send-email-pankaj.dubey@samsung.com>

Now as we have of_scu_enable which takes care of mapping
scu base from DT, lets use it.

Also this patch removes computation of number of cores
from SCU, as for DT platform it will be taken care from
DT CPU device nodes.

CC: Russell King <linux@armlinux.org.uk>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm/mach-realview/platsmp-dt.c | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/arch/arm/mach-realview/platsmp-dt.c b/arch/arm/mach-realview/platsmp-dt.c
index 70ca99e..b2dbf77 100644
--- a/arch/arm/mach-realview/platsmp-dt.c
+++ b/arch/arm/mach-realview/platsmp-dt.c
@@ -23,8 +23,6 @@
 
 static const struct of_device_id realview_scu_match[] = {
 	{ .compatible = "arm,arm11mp-scu", },
-	{ .compatible = "arm,cortex-a9-scu", },
-	{ .compatible = "arm,cortex-a5-scu", },
 	{ }
 };
 
@@ -41,27 +39,18 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus)
 	struct device_node *np;
 	void __iomem *scu_base;
 	struct regmap *map;
-	unsigned int ncores;
 	int i;
 
-	np = of_find_matching_node(NULL, realview_scu_match);
-	if (!np) {
-		pr_err("PLATSMP: No SCU base address\n");
-		return;
+	if (of_scu_enable()) {
+		np = of_find_matching_node(NULL, realview_scu_match);
+		scu_base = of_iomap(np, 0);
+		of_node_put(np);
+		if (!scu_base) {
+			pr_err("PLATSMP: No SCU remap\n");
+			return;
+		}
+		scu_enable(scu_base);
 	}
-	scu_base = of_iomap(np, 0);
-	of_node_put(np);
-	if (!scu_base) {
-		pr_err("PLATSMP: No SCU remap\n");
-		return;
-	}
-
-	scu_enable(scu_base);
-	ncores = scu_get_core_count(scu_base);
-	pr_info("SCU: %d cores detected\n", ncores);
-	for (i = 0; i < ncores; i++)
-		set_cpu_possible(i, true);
-	iounmap(scu_base);
 
 	/* The syscon contains the magic SMP start address registers */
 	np = of_find_matching_node(NULL, realview_syscon_match);
-- 
2.7.4

  parent reply	other threads:[~2016-11-14  4:59 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14  5:01 [PATCH 00/16] Provide support of generic function for SCU enable Pankaj Dubey
2016-11-14  5:01 ` Pankaj Dubey
2016-11-14  5:01 ` [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Pankaj Dubey
2016-11-14  5:01   ` Pankaj Dubey
2016-11-14  6:12   ` Jisheng Zhang
2016-11-14  6:12     ` Jisheng Zhang
2016-11-14  6:54     ` Jisheng Zhang
2016-11-14  6:54       ` Jisheng Zhang
2016-11-14  8:23       ` pankaj.dubey
2016-11-14  8:23         ` pankaj.dubey
2016-11-14  8:47       ` Jisheng Zhang
2016-11-14  8:47         ` Jisheng Zhang
2016-11-14  8:40     ` pankaj.dubey
2016-11-14  8:40       ` pankaj.dubey
2016-11-14 12:03       ` Arnd Bergmann
2016-11-14 12:03         ` Arnd Bergmann
2016-11-14 13:50         ` Russell King - ARM Linux
2016-11-14 13:50           ` Russell King - ARM Linux
2016-11-14 14:37           ` Arnd Bergmann
2016-11-14 14:37             ` Arnd Bergmann
2016-11-14 14:51             ` Russell King - ARM Linux
2016-11-14 14:51               ` Russell King - ARM Linux
2016-11-17  4:20               ` pankaj.dubey
2016-11-17  4:20                 ` pankaj.dubey
2016-11-17 17:03                 ` Arnd Bergmann
2016-11-17 17:03                   ` Arnd Bergmann
2016-11-18  3:24                   ` pankaj.dubey
2016-11-18  3:24                     ` pankaj.dubey
2016-11-18 12:14                     ` Arnd Bergmann
2016-11-18 12:14                       ` Arnd Bergmann
2016-11-18 12:48                       ` Russell King - ARM Linux
2016-11-18 12:48                         ` Russell King - ARM Linux
2016-11-18 13:32                         ` Arnd Bergmann
2016-11-18 13:32                           ` Arnd Bergmann
2016-12-08 15:18                           ` Pankaj Dubey
2016-12-08 15:18                             ` Pankaj Dubey
2016-11-14 13:48   ` Russell King - ARM Linux
2016-11-14 13:48     ` Russell King - ARM Linux
2016-11-17  2:22     ` pankaj.dubey
2016-11-17  2:22       ` pankaj.dubey
2016-11-14  5:01 ` [PATCH 02/16] ARM: EXYNOS: use generic API " Pankaj Dubey
2016-11-14  5:01   ` Pankaj Dubey
2016-11-14  5:01   ` Pankaj Dubey
2016-11-15 18:59   ` Krzysztof Kozlowski
2016-11-15 18:59     ` Krzysztof Kozlowski
2016-11-17  2:15     ` pankaj.dubey
2016-11-17  2:15       ` pankaj.dubey
2016-11-14  5:01 ` [PATCH 03/16] ARM: berlin: use generic API for enabling SCU Pankaj Dubey
2016-11-14  5:01   ` Pankaj Dubey
2016-11-14  8:51   ` Jisheng Zhang
2016-11-14  8:51     ` Jisheng Zhang
2016-11-14 16:20     ` Pankaj Dubey
2016-11-14 16:20       ` Pankaj Dubey
2016-11-14  5:01 ` Pankaj Dubey [this message]
2016-11-14  5:01   ` [PATCH 04/16] ARM: realview: " Pankaj Dubey
2016-11-14 11:56   ` Arnd Bergmann
2016-11-14 11:56     ` Arnd Bergmann
2016-11-14 12:06     ` pankaj.dubey
2016-11-14 12:06       ` pankaj.dubey
2016-11-14 14:28       ` Arnd Bergmann
2016-11-14 14:28         ` Arnd Bergmann
2016-11-14 13:19     ` Pankaj Dubey
2016-11-14 13:19       ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 05/16] ARM: socfpga: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 06/16] ARM: STi: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 07/16] ARM: ux500: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 08/16] ARM: vexpress: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-16 14:34   ` Sudeep Holla
2016-11-16 14:34     ` Sudeep Holla
2016-11-17  2:12     ` pankaj.dubey
2016-11-17  2:12       ` pankaj.dubey
2016-11-14  5:02 ` [PATCH 09/16] ARM: BCM: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  6:10   ` Florian Fainelli
2016-11-14  6:10     ` Florian Fainelli
2016-11-14  5:02 ` [PATCH 10/16] ARM: tegra: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 11/16] ARM: rockchip: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 12/16] ARM: imx: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14 14:26   ` Shawn Guo
2016-11-14 14:26     ` Shawn Guo
2016-11-17  4:29     ` pankaj.dubey
2016-11-17  4:29       ` pankaj.dubey
2016-11-14  5:02 ` [PATCH 13/16] ARM: zynq: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 14/16] ARM: hisi: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 15/16] ARM: mvebu: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey
2016-11-14  5:02 ` [PATCH 16/16] ARM: zx: " Pankaj Dubey
2016-11-14  5:02   ` Pankaj Dubey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479099731-28108-5-git-send-email-pankaj.dubey@samsung.com \
    --to=pankaj.dubey@samsung.com \
    --cc=arnd@arndb.de \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=shiraz.linux.kernel@gmail.com \
    --cc=thomas.ab@samsung.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.