* [PATCH v2 0/5] Fixes for Exynos5433 TM2 board [not found] <CGME20161117085810eucas1p20d425d73d1c1e0de96d2995b96968de7@eucas1p2.samsung.com> @ 2016-11-17 8:57 ` Marek Szyprowski [not found] ` <CGME20161117085810eucas1p2e6cfa6b12c7505e4d6a39fe7423b796b@eucas1p2.samsung.com> ` (5 more replies) 0 siblings, 6 replies; 8+ messages in thread From: Marek Szyprowski @ 2016-11-17 8:57 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi Hi! This is a collection of various fixes (mainly related to clocks configuration) for Exynos 5433 based TM2 board dts. I'm really sorry that I missed those issues in the initial board submission, but most of those issue were detected while testing improved clocks driver. Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v2: - added missing assigned DRD/HOST usb clocks - collected tags - rearanged nodes in alphabetical order Patch summary: Marek Szyprowski (4): arm64: dts: exynos: Fix FSYS CMU parent clocks in Exynos 5433 SoC arm64: dts: exynos: Add missing parent clocks to audio block in Exynos 5433 SoC arm64: dts: exynos: Move FSYS CMU configuration from Exynos5433 dtsi to TM2 dts arm64: dts: exynos: TM2 - remove unused UART3 and set clocks directly on CMU Sylwester Nawrocki (1): arm64: dts: exynos: Assign parent clock of the clkout clock for TM2 board arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 37 +++++++++++++++++++++++---- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 34 +++--------------------- 2 files changed, 36 insertions(+), 35 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20161117085810eucas1p2e6cfa6b12c7505e4d6a39fe7423b796b@eucas1p2.samsung.com>]
* [PATCH v2 1/5] arm64: dts: exynos: Fix FSYS CMU parent clocks in Exynos 5433 SoC [not found] ` <CGME20161117085810eucas1p2e6cfa6b12c7505e4d6a39fe7423b796b@eucas1p2.samsung.com> @ 2016-11-17 8:57 ` Marek Szyprowski 2016-11-17 12:56 ` Chanwoo Choi 0 siblings, 1 reply; 8+ messages in thread From: Marek Szyprowski @ 2016-11-17 8:57 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi This patch corrects FSYS CMU parent clocks specified in clock controller node to let improved Exynos 5433 clocks driver to control proper clocks on FSYS<->TOP CMU boundary. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 1188630823a7..6564875344fa 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -312,7 +312,7 @@ clock-names = "oscclk", "sclk_ufs_mphy", - "div_aclk_fsys_200", + "aclk_fsys_200", "sclk_pcie_100_fsys", "sclk_ufsunipro_fsys", "sclk_mmc2_fsys", @@ -322,7 +322,7 @@ "sclk_usbdrd30_fsys"; clocks = <&xxti>, <&cmu_cpif CLK_SCLK_UFS_MPHY>, - <&cmu_top CLK_DIV_ACLK_FSYS_200>, + <&cmu_top CLK_ACLK_FSYS_200>, <&cmu_top CLK_SCLK_PCIE_100_FSYS>, <&cmu_top CLK_SCLK_UFSUNIPRO_FSYS>, <&cmu_top CLK_SCLK_MMC2_FSYS>, -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/5] arm64: dts: exynos: Fix FSYS CMU parent clocks in Exynos 5433 SoC 2016-11-17 8:57 ` [PATCH v2 1/5] arm64: dts: exynos: Fix FSYS CMU parent clocks in Exynos 5433 SoC Marek Szyprowski @ 2016-11-17 12:56 ` Chanwoo Choi 0 siblings, 0 replies; 8+ messages in thread From: Chanwoo Choi @ 2016-11-17 12:56 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi Hi Marek, 2016-11-17 17:57 GMT+09:00 Marek Szyprowski <m.szyprowski@samsung.com>: > This patch corrects FSYS CMU parent clocks specified in clock controller > node to let improved Exynos 5433 clocks driver to control proper clocks > on FSYS<->TOP CMU boundary. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) [snip] Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20161117085811eucas1p12d1530da1de3dc2b9693ecb25fb038ea@eucas1p1.samsung.com>]
* [PATCH v2 2/5] arm64: dts: exynos: Add missing parent clocks to audio block in Exynos 5433 SoC [not found] ` <CGME20161117085811eucas1p12d1530da1de3dc2b9693ecb25fb038ea@eucas1p1.samsung.com> @ 2016-11-17 8:57 ` Marek Szyprowski 0 siblings, 0 replies; 8+ messages in thread From: Marek Szyprowski @ 2016-11-17 8:57 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi Audio PLL and oscillator clocks are proper parent clocks for AUD CMU. They are not visible as such on first glance on Exynos 5433 SoC docs, but they are needed for this CMU to operate properly. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 6564875344fa..a80eb4c22c7a 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -374,6 +374,8 @@ compatible = "samsung,exynos5433-cmu-aud"; reg = <0x114c0000 0x1000>; #clock-cells = <1>; + clock-names = "oscclk", "fout_aud_pll"; + clocks = <&xxti>, <&cmu_top CLK_FOUT_AUD_PLL>; }; cmu_bus0: clock-controller@13600000 { -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <CGME20161117085811eucas1p1b1fcdd080d43f46ef44558ba0e62e4d3@eucas1p1.samsung.com>]
* [PATCH v2 3/5] arm64: dts: exynos: Move FSYS CMU configuration from Exynos5433 dtsi to TM2 dts [not found] ` <CGME20161117085811eucas1p1b1fcdd080d43f46ef44558ba0e62e4d3@eucas1p1.samsung.com> @ 2016-11-17 8:57 ` Marek Szyprowski 0 siblings, 0 replies; 8+ messages in thread From: Marek Szyprowski @ 2016-11-17 8:57 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi Move initial FSYS CMU (related to USB 3.0 devices) clocks configuration from generic exynos5433.dtsi file to exynos5433-tm2.dts, as this is a board specific item. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 23 ++++++++++++++++++++++ arch/arm64/boot/dts/exynos/exynos5433.dtsi | 28 --------------------------- 2 files changed, 23 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index d3fa03fd0230..0f93e795ab2e 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -165,6 +165,29 @@ }; }; +&cmu_fsys { + assigned-clocks = <&cmu_top CLK_MOUT_SCLK_USBDRD30>, + <&cmu_top CLK_MOUT_SCLK_USBHOST30>, + <&cmu_fsys CLK_MOUT_SCLK_USBDRD30_USER>, + <&cmu_fsys CLK_MOUT_SCLK_USBHOST30_USER>, + <&cmu_fsys CLK_MOUT_PHYCLK_USBDRD30_UDRD30_PIPE_PCLK_USER>, + <&cmu_fsys CLK_MOUT_PHYCLK_USBHOST30_UHOST30_PIPE_PCLK_USER>, + <&cmu_fsys CLK_MOUT_PHYCLK_USBDRD30_UDRD30_PHYCLOCK_USER>, + <&cmu_fsys CLK_MOUT_PHYCLK_USBHOST30_UHOST30_PHYCLOCK_USER>, + <&cmu_top CLK_DIV_SCLK_USBDRD30>, + <&cmu_top CLK_DIV_SCLK_USBHOST30>; + assigned-clock-parents = <&cmu_top CLK_MOUT_BUS_PLL_USER>, + <&cmu_top CLK_MOUT_BUS_PLL_USER>, + <&cmu_top CLK_SCLK_USBDRD30_FSYS>, + <&cmu_top CLK_SCLK_USBHOST30_FSYS>, + <&cmu_fsys CLK_PHYCLK_USBDRD30_UDRD30_PIPE_PCLK_PHY>, + <&cmu_fsys CLK_PHYCLK_USBHOST30_UHOST30_PIPE_PCLK_PHY>, + <&cmu_fsys CLK_PHYCLK_USBDRD30_UDRD30_PHYCLOCK_PHY>, + <&cmu_fsys CLK_PHYCLK_USBHOST30_UHOST30_PHYCLOCK_PHY>; + assigned-clock-rates = <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>, + <66700000>, <66700000>; +}; + &cpu0 { cpu-supply = <&buck3_reg>; }; diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index a80eb4c22c7a..ab2935253cca 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -1134,14 +1134,6 @@ clocks = <&cmu_fsys CLK_ACLK_USBDRD30>, <&cmu_fsys CLK_SCLK_USBDRD30>; clock-names = "usbdrd30", "usbdrd30_susp_clk"; - assigned-clocks = - <&cmu_fsys CLK_MOUT_SCLK_USBDRD30_USER>, - <&cmu_top CLK_MOUT_SCLK_USBDRD30>, - <&cmu_top CLK_DIV_SCLK_USBDRD30>; - assigned-clock-parents = - <&cmu_top CLK_SCLK_USBDRD30_FSYS>, - <&cmu_top CLK_MOUT_BUS_PLL_USER>; - assigned-clock-rates = <0>, <0>, <66700000>; #address-cells = <1>; #size-cells = <1>; ranges; @@ -1165,12 +1157,6 @@ <&cmu_fsys CLK_SCLK_USBDRD30>; clock-names = "phy", "ref", "phy_utmi", "phy_pipe", "itp"; - assigned-clocks = - <&cmu_fsys CLK_MOUT_PHYCLK_USBDRD30_UDRD30_PIPE_PCLK_USER>, - <&cmu_fsys CLK_MOUT_PHYCLK_USBDRD30_UDRD30_PHYCLOCK_USER>; - assigned-clock-parents = - <&cmu_fsys CLK_PHYCLK_USBDRD30_UDRD30_PIPE_PCLK_PHY>, - <&cmu_fsys CLK_PHYCLK_USBDRD30_UDRD30_PHYCLOCK_PHY>; #phy-cells = <1>; samsung,pmu-syscon = <&pmu_system_controller>; status = "disabled"; @@ -1185,12 +1171,6 @@ <&cmu_fsys CLK_SCLK_USBHOST30>; clock-names = "phy", "ref", "phy_utmi", "phy_pipe", "itp"; - assigned-clocks = - <&cmu_fsys CLK_MOUT_PHYCLK_USBHOST30_UHOST30_PIPE_PCLK_USER>, - <&cmu_fsys CLK_MOUT_PHYCLK_USBHOST30_UHOST30_PHYCLOCK_USER>; - assigned-clock-parents = - <&cmu_fsys CLK_PHYCLK_USBHOST30_UHOST30_PIPE_PCLK_PHY>, - <&cmu_fsys CLK_PHYCLK_USBHOST30_UHOST30_PHYCLOCK_PHY>; #phy-cells = <1>; samsung,pmu-syscon = <&pmu_system_controller>; status = "disabled"; @@ -1201,14 +1181,6 @@ clocks = <&cmu_fsys CLK_ACLK_USBHOST30>, <&cmu_fsys CLK_SCLK_USBHOST30>; clock-names = "usbdrd30", "usbdrd30_susp_clk"; - assigned-clocks = - <&cmu_fsys CLK_MOUT_SCLK_USBHOST30_USER>, - <&cmu_top CLK_MOUT_SCLK_USBHOST30>, - <&cmu_top CLK_DIV_SCLK_USBHOST30>; - assigned-clock-parents = - <&cmu_top CLK_SCLK_USBHOST30_FSYS>, - <&cmu_top CLK_MOUT_BUS_PLL_USER>; - assigned-clock-rates = <0>, <0>, <66700000>; #address-cells = <1>; #size-cells = <1>; ranges; -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <CGME20161117085812eucas1p18c55c33c2d4dcafc5d6cd7e4aecac51b@eucas1p1.samsung.com>]
* [PATCH v2 4/5] arm64: dts: exynos: Assign parent clock of the clkout clock for TM2 board [not found] ` <CGME20161117085812eucas1p18c55c33c2d4dcafc5d6cd7e4aecac51b@eucas1p1.samsung.com> @ 2016-11-17 8:58 ` Marek Szyprowski 0 siblings, 0 replies; 8+ messages in thread From: Marek Szyprowski @ 2016-11-17 8:58 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi From: Sylwester Nawrocki <s.nawrocki@samsung.com> Without this patch the clkout clock is orphaned and sound doesn't work properly. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 0f93e795ab2e..a0ccc9d3a716 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -979,6 +979,11 @@ }; }; +&pmu_system_controller { + assigned-clocks = <&pmu_system_controller 0>; + assigned-clock-parents = <&xxti>; +}; + &serial_1 { status = "okay"; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <CGME20161117085812eucas1p2688dd5a172c52796b43001b108180d6e@eucas1p2.samsung.com>]
* [PATCH v2 5/5] arm64: dts: exynos: TM2 - remove unused UART3 and set clocks directly on CMU [not found] ` <CGME20161117085812eucas1p2688dd5a172c52796b43001b108180d6e@eucas1p2.samsung.com> @ 2016-11-17 8:58 ` Marek Szyprowski 0 siblings, 0 replies; 8+ messages in thread From: Marek Szyprowski @ 2016-11-17 8:58 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi UART3 device is not really needed for enabling audio block on TM2. Enabling it made it working by enabling some common parent clocks, what is now handled by improved exynos5433 clocks driver. Thus the UART3 device node can be safely disabled. The assigned-clocks entries are however still needed, so move them under the respective CMU node. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index a0ccc9d3a716..48da2095e381 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -165,6 +165,11 @@ }; }; +&cmu_aud { + assigned-clocks = <&cmu_aud CLK_MOUT_AUD_PLL_USER>; + assigned-clock-parents = <&cmu_top CLK_FOUT_AUD_PLL>; +}; + &cmu_fsys { assigned-clocks = <&cmu_top CLK_MOUT_SCLK_USBDRD30>, <&cmu_top CLK_MOUT_SCLK_USBHOST30>, @@ -988,12 +993,6 @@ status = "okay"; }; -&serial_3 { - assigned-clocks = <&cmu_aud CLK_MOUT_AUD_PLL_USER>; - assigned-clock-parents = <&cmu_top CLK_FOUT_AUD_PLL>; - status = "okay"; -}; - &spi_1 { cs-gpios = <&gpd6 3 GPIO_ACTIVE_HIGH>; status = "okay"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/5] Fixes for Exynos5433 TM2 board 2016-11-17 8:57 ` [PATCH v2 0/5] Fixes for Exynos5433 TM2 board Marek Szyprowski ` (4 preceding siblings ...) [not found] ` <CGME20161117085812eucas1p2688dd5a172c52796b43001b108180d6e@eucas1p2.samsung.com> @ 2016-11-18 11:39 ` Krzysztof Kozlowski 5 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2016-11-18 11:39 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Chanwoo Choi On Thu, Nov 17, 2016 at 09:57:56AM +0100, Marek Szyprowski wrote: > Hi! > > This is a collection of various fixes (mainly related to clocks > configuration) for Exynos 5433 based TM2 board dts. I'm really sorry > that I missed those issues in the initial board submission, but > most of those issue were detected while testing improved clocks driver. > > Best regards > Marek Szyprowski > Samsung R&D Institute Poland > > > Changelog: > v2: > - added missing assigned DRD/HOST usb clocks > - collected tags > - rearanged nodes in alphabetical order > > Patch summary: Applied series, thanks! Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-11-18 11:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20161117085810eucas1p20d425d73d1c1e0de96d2995b96968de7@eucas1p2.samsung.com>
2016-11-17 8:57 ` [PATCH v2 0/5] Fixes for Exynos5433 TM2 board Marek Szyprowski
[not found] ` <CGME20161117085810eucas1p2e6cfa6b12c7505e4d6a39fe7423b796b@eucas1p2.samsung.com>
2016-11-17 8:57 ` [PATCH v2 1/5] arm64: dts: exynos: Fix FSYS CMU parent clocks in Exynos 5433 SoC Marek Szyprowski
2016-11-17 12:56 ` Chanwoo Choi
[not found] ` <CGME20161117085811eucas1p12d1530da1de3dc2b9693ecb25fb038ea@eucas1p1.samsung.com>
2016-11-17 8:57 ` [PATCH v2 2/5] arm64: dts: exynos: Add missing parent clocks to audio block " Marek Szyprowski
[not found] ` <CGME20161117085811eucas1p1b1fcdd080d43f46ef44558ba0e62e4d3@eucas1p1.samsung.com>
2016-11-17 8:57 ` [PATCH v2 3/5] arm64: dts: exynos: Move FSYS CMU configuration from Exynos5433 dtsi to TM2 dts Marek Szyprowski
[not found] ` <CGME20161117085812eucas1p18c55c33c2d4dcafc5d6cd7e4aecac51b@eucas1p1.samsung.com>
2016-11-17 8:58 ` [PATCH v2 4/5] arm64: dts: exynos: Assign parent clock of the clkout clock for TM2 board Marek Szyprowski
[not found] ` <CGME20161117085812eucas1p2688dd5a172c52796b43001b108180d6e@eucas1p2.samsung.com>
2016-11-17 8:58 ` [PATCH v2 5/5] arm64: dts: exynos: TM2 - remove unused UART3 and set clocks directly on CMU Marek Szyprowski
2016-11-18 11:39 ` [PATCH v2 0/5] Fixes for Exynos5433 TM2 board Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.