All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	devicetree@vger.kernel.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org, vinod.koul@intel.com,
	dmaengine@vger.kernel.org, linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support
Date: Fri, 18 Nov 2016 21:27:04 +0200	[thread overview]
Message-ID: <1479497224.22212.42.camel@linux.intel.com> (raw)
In-Reply-To: <1479496356-27834-2-git-send-email-Eugeniy.Paltsev@synopsys.com>

On Fri, 2016-11-18 at 22:12 +0300, Eugeniy Paltsev wrote:
> All known devices, which use DT for configuration, support
> memory-to-memory transfers. So enable it by default, if we read
> configuration from DT.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>

You missed the given tag(s).

> ---
>  drivers/dma/dw/platform.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index 5bda0eb..aa7a5c1 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -129,6 +129,12 @@ dw_dma_parse_dt(struct platform_device *pdev)
>  	if (of_property_read_bool(np, "is_private"))
>  		pdata->is_private = true;
>  
> +	/*
> +	 * All known devices, which use DT for configuration, support
> +	 * memory-to-memory transfers. So enable it by default.
> +	 */
> +	pdata->is_memcpy = true;
> +
>  	if (!of_property_read_u32(np, "chan_allocation_order", &tmp))
>  		pdata->chan_allocation_order = (unsigned char)tmp;
>  

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Eugeniy Paltsev
	<Eugeniy.Paltsev-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support
Date: Fri, 18 Nov 2016 21:27:04 +0200	[thread overview]
Message-ID: <1479497224.22212.42.camel@linux.intel.com> (raw)
In-Reply-To: <1479496356-27834-2-git-send-email-Eugeniy.Paltsev-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>

On Fri, 2016-11-18 at 22:12 +0300, Eugeniy Paltsev wrote:
> All known devices, which use DT for configuration, support
> memory-to-memory transfers. So enable it by default, if we read
> configuration from DT.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>

You missed the given tag(s).

> ---
>  drivers/dma/dw/platform.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index 5bda0eb..aa7a5c1 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -129,6 +129,12 @@ dw_dma_parse_dt(struct platform_device *pdev)
>  	if (of_property_read_bool(np, "is_private"))
>  		pdata->is_private = true;
>  
> +	/*
> +	 * All known devices, which use DT for configuration, support
> +	 * memory-to-memory transfers. So enable it by default.
> +	 */
> +	pdata->is_memcpy = true;
> +
>  	if (!of_property_read_u32(np, "chan_allocation_order", &tmp))
>  		pdata->chan_allocation_order = (unsigned char)tmp;
>  

-- 
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support
Date: Fri, 18 Nov 2016 21:27:04 +0200	[thread overview]
Message-ID: <1479497224.22212.42.camel@linux.intel.com> (raw)
In-Reply-To: <1479496356-27834-2-git-send-email-Eugeniy.Paltsev@synopsys.com>

On Fri, 2016-11-18@22:12 +0300, Eugeniy Paltsev wrote:
> All known devices, which use DT for configuration, support
> memory-to-memory transfers. So enable it by default, if we read
> configuration from DT.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>

You missed the given tag(s).

> ---
> ?drivers/dma/dw/platform.c | 6 ++++++
> ?1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index 5bda0eb..aa7a5c1 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -129,6 +129,12 @@ dw_dma_parse_dt(struct platform_device *pdev)
> ?	if (of_property_read_bool(np, "is_private"))
> ?		pdata->is_private = true;
> ?
> +	/*
> +	?* All known devices, which use DT for configuration, support
> +	?* memory-to-memory transfers. So enable it by default.
> +	?*/
> +	pdata->is_memcpy = true;
> +
> ?	if (!of_property_read_u32(np, "chan_allocation_order", &tmp))
> ?		pdata->chan_allocation_order = (unsigned char)tmp;
> ?

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2016-11-18 19:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 19:12 [PATCH v3 0/2] DW DMAC: update device tree Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:12 ` Eugeniy Paltsev
2016-11-18 19:12 ` [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support Eugeniy Paltsev
2016-11-18 19:12   ` Eugeniy Paltsev
2016-11-18 19:12   ` Eugeniy Paltsev
2016-11-18 19:27   ` Andy Shevchenko [this message]
2016-11-18 19:27     ` Andy Shevchenko
2016-11-18 19:27     ` Andy Shevchenko
2016-11-18 19:12 ` [PATCH v3 2/2] DW DMAC: add multi-block property to device tree Eugeniy Paltsev
2016-11-18 19:12   ` Eugeniy Paltsev
2016-11-18 19:12   ` Eugeniy Paltsev
2016-11-18 19:33   ` Andy Shevchenko
2016-11-18 19:33     ` Andy Shevchenko
2016-11-18 19:33     ` Andy Shevchenko
2016-11-23  4:15     ` Vinod Koul
2016-11-23  4:15       ` Vinod Koul
2016-11-21 13:53   ` Arnd Bergmann
2016-11-21 13:53     ` Arnd Bergmann
2016-11-21 13:53     ` Arnd Bergmann
2016-11-18 19:26 ` [PATCH v3 0/2] DW DMAC: update " Andy Shevchenko
2016-11-18 19:26   ` Andy Shevchenko
2016-11-18 19:26   ` Andy Shevchenko
2016-11-21 10:02   ` Alexey Brodkin
2016-11-21 10:02     ` Alexey Brodkin
2016-11-21 10:02     ` Alexey Brodkin
2016-11-21 10:37     ` Andy Shevchenko
2016-11-21 10:37       ` Andy Shevchenko
2016-11-21 10:37       ` Andy Shevchenko
2016-11-23  4:06       ` Vinod Koul
2016-11-23  4:06         ` Vinod Koul
2016-11-23  4:06         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479497224.22212.42.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.