All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH v2] serial: Poll USB devices if usbX serial port is missing
Date: Mon, 21 Nov 2016 16:05:19 +0200	[thread overview]
Message-ID: <1479737119.3256.7.camel@linux.intel.com> (raw)
In-Reply-To: <CAA91j0XpFGgx4JvKpOgmCzKXEN_rEr_QFeAZpnw5B3mwj+BAzg@mail.gmail.com>

On pe, 2016-11-18 at 15:21 +0300, Andrei Borzenkov wrote:
> On Fri, Nov 18, 2016 at 1:36 PM, Joonas Lahtinen
> > 
> > v2:
> > - Use grub_term_poll_usb to avoid module dependency (Andrei)
> > 
> 
> Hmm ... note that terminal_input/terminal_output also auto-load
> modules that handle serial ports. So this still will not be
> equivalent, it will require user to manually pre-load USB. Did you
> actually test this version of patch? Do you pre-load USB modules
> somewhere?

Nope, I took your word literally and just changed the function.
Assuming it's a rather direct replacement. Excuse for that.

> 
> The problem is, infrastructure to handle auto-load lists currently
> belongs to normal mode, while serial may sensibly be used before
> normal is loaded. Not sure what we can do here.

I think this is getting more important when we're seeing increasing
amount of devices without even an internal serial port.

Sounds to me like pulling the auto-loading out of just normal mode
would make sense?

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


  reply	other threads:[~2016-11-21 14:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10 13:45 [PATCH 1/2] .gitignore: Add grub-core/build-grub-module-verifier Joonas Lahtinen
2016-11-10 13:45 ` [PATCH 2/2] serial: Poll USB devices if usbX serial port is missing Joonas Lahtinen
2016-11-12  9:18   ` Andrei Borzenkov
2016-11-18 10:36     ` [PATCH v2] " Joonas Lahtinen
2016-11-18 12:21       ` Andrei Borzenkov
2016-11-21 14:05         ` Joonas Lahtinen [this message]
2016-11-21 19:08           ` Andrei Borzenkov
2016-11-12  9:08 ` [PATCH 1/2] .gitignore: Add grub-core/build-grub-module-verifier Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479737119.3256.7.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.