* [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
@ 2016-11-22 18:06 Gautham R. Shenoy
2016-11-22 23:30 ` Michael Ellerman
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Gautham R. Shenoy @ 2016-11-22 18:06 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
Michael Neuling, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: linuxppc-dev, linux-kernel, Gautham R. Shenoy
From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Ensure that PSSCR is set to a safe value corresponding to no
state-loss each time a POWER9 CPU comes online.
Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
---
arch/powerpc/kernel/cpu_setup_power.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/cpu_setup_power.S b/arch/powerpc/kernel/cpu_setup_power.S
index 52ff3f0..37ad045 100644
--- a/arch/powerpc/kernel/cpu_setup_power.S
+++ b/arch/powerpc/kernel/cpu_setup_power.S
@@ -96,6 +96,7 @@ _GLOBAL(__setup_cpu_power9)
mtlr r11
beqlr
li r0,0
+ mtspr SPRN_PSSCR,r0
mtspr SPRN_LPID,r0
mfspr r3,SPRN_LPCR
ori r3, r3, LPCR_PECEDH
@@ -116,6 +117,7 @@ _GLOBAL(__restore_cpu_power9)
mtlr r11
beqlr
li r0,0
+ mtspr SPRN_PSSCR,r0
mtspr SPRN_LPID,r0
mfspr r3,SPRN_LPCR
ori r3, r3, LPCR_PECEDH
--
1.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
2016-11-22 18:06 [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online Gautham R. Shenoy
@ 2016-11-22 23:30 ` Michael Ellerman
2016-11-22 23:35 ` Michael Neuling
2016-11-23 0:32 ` Michael Neuling
2016-11-28 12:15 ` Michael Ellerman
2 siblings, 1 reply; 7+ messages in thread
From: Michael Ellerman @ 2016-11-22 23:30 UTC (permalink / raw)
To: Gautham R. Shenoy, Benjamin Herrenschmidt, Paul Mackerras,
Michael Neuling, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: linuxppc-dev, linux-kernel, Gautham R. Shenoy
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> Ensure that PSSCR is set to a safe value corresponding to no
> state-loss each time a POWER9 CPU comes online.
Is this a bug fix? I can't tell from the change log.
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
2016-11-22 23:30 ` Michael Ellerman
@ 2016-11-22 23:35 ` Michael Neuling
0 siblings, 0 replies; 7+ messages in thread
From: Michael Neuling @ 2016-11-22 23:35 UTC (permalink / raw)
To: Michael Ellerman, Gautham R. Shenoy, Benjamin Herrenschmidt,
Paul Mackerras, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: linuxppc-dev, linux-kernel
On Wed, 2016-11-23 at 10:30 +1100, Michael Ellerman wrote:
> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
>
> > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
> >
> > Ensure that PSSCR is set to a safe value corresponding to no
> > state-loss each time a POWER9 CPU comes online.
>
> Is this a bug fix? I can't tell from the change log.
There are no known bugs it's fixing.
It's just safer to run with a known default value, rather than what we randomly
inherit from previous firmware.
Mikey
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
@ 2016-11-22 23:35 ` Michael Neuling
0 siblings, 0 replies; 7+ messages in thread
From: Michael Neuling @ 2016-11-22 23:35 UTC (permalink / raw)
To: Michael Ellerman, Gautham R. Shenoy, Benjamin Herrenschmidt,
Paul Mackerras, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: linuxppc-dev, linux-kernel
On Wed, 2016-11-23 at 10:30 +1100, Michael Ellerman wrote:
> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
>=20
> > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
> >=20
> > Ensure that PSSCR is set to a safe value corresponding to no
> > state-loss each time a POWER9 CPU comes online.
>=20
> Is this a bug fix? I can't tell from the change log.
There are no known bugs it's fixing. =C2=A0
It's just safer to run with a known default value, rather than what we rand=
omly
inherit from previous firmware.
Mikey
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
2016-11-22 18:06 [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online Gautham R. Shenoy
@ 2016-11-23 0:32 ` Michael Neuling
2016-11-23 0:32 ` Michael Neuling
2016-11-28 12:15 ` Michael Ellerman
2 siblings, 0 replies; 7+ messages in thread
From: Michael Neuling @ 2016-11-23 0:32 UTC (permalink / raw)
To: Gautham R. Shenoy, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: linuxppc-dev, linux-kernel
On Tue, 2016-11-22 at 23:36 +0530, Gautham R. Shenoy wrote:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> Ensure that PSSCR is set to a safe value corresponding to no
> state-loss each time a POWER9 CPU comes online.
>
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Tested here on my configuration... FWIW
Acked-By: Michael Neuling <mikey@neuling.org>
> ---
> arch/powerpc/kernel/cpu_setup_power.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/cpu_setup_power.S
> b/arch/powerpc/kernel/cpu_setup_power.S
> index 52ff3f0..37ad045 100644
> --- a/arch/powerpc/kernel/cpu_setup_power.S
> +++ b/arch/powerpc/kernel/cpu_setup_power.S
> @@ -96,6 +96,7 @@ _GLOBAL(__setup_cpu_power9)
> mtlr r11
> beqlr
> li r0,0
> + mtspr SPRN_PSSCR,r0
> mtspr SPRN_LPID,r0
> mfspr r3,SPRN_LPCR
> ori r3, r3, LPCR_PECEDH
> @@ -116,6 +117,7 @@ _GLOBAL(__restore_cpu_power9)
> mtlr r11
> beqlr
> li r0,0
> + mtspr SPRN_PSSCR,r0
> mtspr SPRN_LPID,r0
> mfspr r3,SPRN_LPCR
> ori r3, r3, LPCR_PECEDH
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
@ 2016-11-23 0:32 ` Michael Neuling
0 siblings, 0 replies; 7+ messages in thread
From: Michael Neuling @ 2016-11-23 0:32 UTC (permalink / raw)
To: Gautham R. Shenoy, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: linuxppc-dev, linux-kernel
On Tue, 2016-11-22 at 23:36 +0530, Gautham R. Shenoy wrote:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>=20
> Ensure that PSSCR is set to a safe value corresponding to no
> state-loss each time a POWER9 CPU comes online.
>=20
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Tested here on my configuration... FWIW
Acked-By: Michael Neuling <mikey@neuling.org>
> ---
> =C2=A0arch/powerpc/kernel/cpu_setup_power.S | 2 ++
> =C2=A01 file changed, 2 insertions(+)
>=20
> diff --git a/arch/powerpc/kernel/cpu_setup_power.S
> b/arch/powerpc/kernel/cpu_setup_power.S
> index 52ff3f0..37ad045 100644
> --- a/arch/powerpc/kernel/cpu_setup_power.S
> +++ b/arch/powerpc/kernel/cpu_setup_power.S
> @@ -96,6 +96,7 @@ _GLOBAL(__setup_cpu_power9)
> =C2=A0 mtlr r11
> =C2=A0 beqlr
> =C2=A0 li r0,0
> + mtspr SPRN_PSSCR,r0
> =C2=A0 mtspr SPRN_LPID,r0
> =C2=A0 mfspr r3,SPRN_LPCR
> =C2=A0 ori r3, r3, LPCR_PECEDH
> @@ -116,6 +117,7 @@ _GLOBAL(__restore_cpu_power9)
> =C2=A0 mtlr r11
> =C2=A0 beqlr
> =C2=A0 li r0,0
> + mtspr SPRN_PSSCR,r0
> =C2=A0 mtspr SPRN_LPID,r0
> =C2=A0 mfspr=C2=A0=C2=A0=C2=A0r3,SPRN_LPCR
> =C2=A0 ori r3, r3, LPCR_PECEDH
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
2016-11-22 18:06 [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online Gautham R. Shenoy
2016-11-22 23:30 ` Michael Ellerman
2016-11-23 0:32 ` Michael Neuling
@ 2016-11-28 12:15 ` Michael Ellerman
2 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2016-11-28 12:15 UTC (permalink / raw)
To: Gautham R. Shenoy, Benjamin Herrenschmidt, Paul Mackerras,
Michael Neuling, Vaidyanathan Srinivasan, Shreyas B. Prabhu
Cc: Gautham R. Shenoy, linuxppc-dev, linux-kernel
On Tue, 2016-11-22 at 18:06:40 UTC, "Gautham R. Shenoy" wrote:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> Ensure that PSSCR is set to a safe value corresponding to no
> state-loss each time a POWER9 CPU comes online.
>
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> Acked-By: Michael Neuling <mikey@neuling.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/378f96d3cd442d5cb8e2692d8767a4
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-28 12:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-22 18:06 [PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online Gautham R. Shenoy
2016-11-22 23:30 ` Michael Ellerman
2016-11-22 23:35 ` Michael Neuling
2016-11-22 23:35 ` Michael Neuling
2016-11-23 0:32 ` Michael Neuling
2016-11-23 0:32 ` Michael Neuling
2016-11-28 12:15 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.